| Message ID | 346611b3ec6f47cb10e538d6cbe52056f535f965.1710226514.git.andrea.porta@suse.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | dmaengine: bcm2835: add BCM2711 40-bit DMA support | expand |
On 17:17 Tue 12 Mar , Krzysztof Kozlowski wrote: > On 12/03/2024 10:12, Andrea della Porta wrote: > > Add BCM2711 dma engine compatible. > > > > Signed-off-by: Andrea della Porta <andrea.porta@suse.com> > > --- > > Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml > > index c9b9a5490826..4271a6fedf54 100644 > > --- a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml > > +++ b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml > > @@ -20,7 +20,9 @@ allOf: > > > > properties: > > compatible: > > - const: brcm,bcm2835-dma > > + enum: > > + - brcm,bcm2835-dma > > + - brcm,bcm2711-dma > > Please keep the entries alphabetically sorted. Probably same comment > applies to your driver device ID table. > > With sorting fixed: > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sure, I'll fix the order in the next version, after collecting guidelines for dma_map_resource() issue. Please ignore the patchset sent today since it still contains the dt binding in the incorrect order: thge patchset has been sent as is just to reach all teh parties since it was splitted due to a problem with my imap server. > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml index c9b9a5490826..4271a6fedf54 100644 --- a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml +++ b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml @@ -20,7 +20,9 @@ allOf: properties: compatible: - const: brcm,bcm2835-dma + enum: + - brcm,bcm2835-dma + - brcm,bcm2711-dma reg: maxItems: 1
Add BCM2711 dma engine compatible. Signed-off-by: Andrea della Porta <andrea.porta@suse.com> --- Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)