Message ID | 20240314123346.461350-1-herve.codina@bootlin.com (mailing list archive) |
---|---|
State | Accepted |
Commit | badc9e33c79541cd62fc8238c2eb564d41feac56 |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | net: wan: fsl_qmc_hdlc: Fix module compilation | expand |
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Thu, 14 Mar 2024 13:33:46 +0100 you wrote: > The fsl_qmc_driver does not compile as module: > error: ‘qmc_hdlc_driver’ undeclared here (not in a function); > 405 | MODULE_DEVICE_TABLE(of, qmc_hdlc_driver); > | ^~~~~~~~~~~~~~~ > > Fix the typo. > > [...] Here is the summary with links: - net: wan: fsl_qmc_hdlc: Fix module compilation https://git.kernel.org/netdev/net/c/badc9e33c795 You are awesome, thank you!
diff --git a/drivers/net/wan/fsl_qmc_hdlc.c b/drivers/net/wan/fsl_qmc_hdlc.c index 960371df470a..f69b1f579a0c 100644 --- a/drivers/net/wan/fsl_qmc_hdlc.c +++ b/drivers/net/wan/fsl_qmc_hdlc.c @@ -780,7 +780,7 @@ static const struct of_device_id qmc_hdlc_id_table[] = { { .compatible = "fsl,qmc-hdlc" }, {} /* sentinel */ }; -MODULE_DEVICE_TABLE(of, qmc_hdlc_driver); +MODULE_DEVICE_TABLE(of, qmc_hdlc_id_table); static struct platform_driver qmc_hdlc_driver = { .driver = {
The fsl_qmc_driver does not compile as module: error: ‘qmc_hdlc_driver’ undeclared here (not in a function); 405 | MODULE_DEVICE_TABLE(of, qmc_hdlc_driver); | ^~~~~~~~~~~~~~~ Fix the typo. Fixes: b40f00ecd463 ("net: wan: Add support for QMC HDLC") Reported-by: Michael Ellerman <mpe@ellerman.id.au> Closes: https://lore.kernel.org/linux-kernel/87ttl93f7i.fsf@mail.lhotse/ Signed-off-by: Herve Codina <herve.codina@bootlin.com> --- drivers/net/wan/fsl_qmc_hdlc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)