mbox series

[net,v3,0/2] net: veth: ability to toggle GRO and XDP independently

Message ID 20240313183759.87923-1-ignat@cloudflare.com (mailing list archive)
Headers show
Series net: veth: ability to toggle GRO and XDP independently | expand

Message

Ignat Korchagin March 13, 2024, 6:37 p.m. UTC
It is rather confusing that GRO is automatically enabled, when an XDP program
is attached to a veth interface. Moreover, it is not possible to disable GRO
on a veth, if an XDP program is attached (which might be desirable in some use
cases).

Make GRO and XDP independent for a veth interface. udpgro_fwd

Changes in v3:
  * adjust udpgro_fwd selftest to explicitly enable GRO on veth interfaces,
    where it expects GRO to happen

Changes in v2:
  * add Fixes reference to commit description
  * fix commit message spelling

Ignat Korchagin (2):
  net: veth: do not manipulate GRO when using XDP
  selftests: net: veth: test the ability to independently manipulate GRO
    and XDP

 drivers/net/veth.c                        | 18 -----------------
 tools/testing/selftests/net/udpgro_fwd.sh |  4 ++++
 tools/testing/selftests/net/veth.sh       | 24 ++++++++++++++++++++---
 3 files changed, 25 insertions(+), 21 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org March 18, 2024, 12:30 p.m. UTC | #1
Hello:

This series was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Wed, 13 Mar 2024 19:37:57 +0100 you wrote:
> It is rather confusing that GRO is automatically enabled, when an XDP program
> is attached to a veth interface. Moreover, it is not possible to disable GRO
> on a veth, if an XDP program is attached (which might be desirable in some use
> cases).
> 
> Make GRO and XDP independent for a veth interface. udpgro_fwd
> 
> [...]

Here is the summary with links:
  - [net,v3,1/2] net: veth: do not manipulate GRO when using XDP
    https://git.kernel.org/netdev/net/c/d7db7775ea2e
  - [net,v3,2/2] selftests: net: veth: test the ability to independently manipulate GRO and XDP
    https://git.kernel.org/netdev/net/c/ba5a6476e386

You are awesome, thank you!