| Message ID | 20240315002108.523232-1-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9966e329d6756ea80832376991eb5b0d5ff2cf6b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] tools: ynl: add header guards for nlctrl | expand |
Jakub Kicinski <kuba@kernel.org> writes: > I "extracted" YNL C into a GitHub repo to make it easier > to use in other projects: https://github.com/linux-netdev/ynl-c > > GitHub actions use Ubuntu by default, and the kernel headers > there are missing f329a0ebeaba ("genetlink: correct uAPI defines"). > Add the direct include workaround for nlctrl. > > Fixes: 768e044a5fd4 ("doc/netlink/specs: Add spec for nlctrl netlink family") > Signed-off-by: Jakub Kicinski <kuba@kernel.org> Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni <pabeni@redhat.com>: On Thu, 14 Mar 2024 17:21:08 -0700 you wrote: > I "extracted" YNL C into a GitHub repo to make it easier > to use in other projects: https://github.com/linux-netdev/ynl-c > > GitHub actions use Ubuntu by default, and the kernel headers > there are missing f329a0ebeaba ("genetlink: correct uAPI defines"). > Add the direct include workaround for nlctrl. > > [...] Here is the summary with links: - [net] tools: ynl: add header guards for nlctrl https://git.kernel.org/netdev/net/c/9966e329d675 You are awesome, thank you!
diff --git a/tools/net/ynl/Makefile.deps b/tools/net/ynl/Makefile.deps index 07373c5a7afe..f4e8eb79c1b8 100644 --- a/tools/net/ynl/Makefile.deps +++ b/tools/net/ynl/Makefile.deps @@ -20,6 +20,7 @@ CFLAGS_ethtool:=$(call get_hdr_inc,_LINUX_ETHTOOL_NETLINK_H_,ethtool_netlink.h) CFLAGS_handshake:=$(call get_hdr_inc,_LINUX_HANDSHAKE_H,handshake.h) CFLAGS_mptcp_pm:=$(call get_hdr_inc,_LINUX_MPTCP_PM_H,mptcp_pm.h) CFLAGS_netdev:=$(call get_hdr_inc,_LINUX_NETDEV_H,netdev.h) +CFLAGS_nlctrl:=$(call get_hdr_inc,__LINUX_GENERIC_NETLINK_H,genetlink.h) CFLAGS_nfsd:=$(call get_hdr_inc,_LINUX_NFSD_NETLINK_H,nfsd_netlink.h) CFLAGS_ovs_datapath:=$(call get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h) CFLAGS_ovs_flow:=$(call get_hdr_inc,__LINUX_OPENVSWITCH_H,openvswitch.h)
I "extracted" YNL C into a GitHub repo to make it easier to use in other projects: https://github.com/linux-netdev/ynl-c GitHub actions use Ubuntu by default, and the kernel headers there are missing f329a0ebeaba ("genetlink: correct uAPI defines"). Add the direct include workaround for nlctrl. Fixes: 768e044a5fd4 ("doc/netlink/specs: Add spec for nlctrl netlink family") Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- The Fixes tag is a bit unfair here, we never promised very old headers will work. At the same time Ubuntu may be fairly popular so seems worth making it work. --- CC: jiri@resnulli.us CC: chuck.lever@oracle.com CC: donald.hunter@gmail.com --- tools/net/ynl/Makefile.deps | 1 + 1 file changed, 1 insertion(+)