| Message ID | 20240318133757.1479189-1-luciano.coelho@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/i915/display: DMC wakelock implementation | expand |
Hi, This bug I'm hitting is unrelated to my patch and after a bit of investigation with JaniS, we noticed that this is happening in order machines from time to time. So this possible regression: > Possible regressions * igt@i915_selftest@live@hangcheck:bat-adln-1: PASS -> ABORT ..is the same problem that is happening from time to time in adlp-6: > Possible fixes * igt@i915_selftest@live@hangcheck:bat-adlp-6: ABORT (i915#10021) - > > PASS It is the same failure as this one: http://gfx-ci.igk.intel.com/cibuglog-ng/issue/10977?query_key=6ae0d29cf197dafc63e8bf36c8e1c04fe395749f Can you please add ADL_N machines to the filter as well? Thanks! -- Cheers, Luca. On Mon, 2024-03-18 at 21:55 +0000, Patchwork wrote: > Patch Details > Series:drm/i915/display: DMC wakelock implementation (rev2) > URL:https://patchwork.freedesktop.org/series/131124/ > State:failure > Details: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131124v2/index.html > CI Bug Log - changes from CI_DRM_14443 -> Patchwork_131124v2SummaryFAILURE > Serious unknown changes coming with Patchwork_131124v2 absolutely > need to be > verified manually. > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_131124v2, please notify your bug team (I915- > ci-infra@lists.freedesktop.org) to allow them > to document this new failure mode, which will reduce false positives > in CI. > External URL: https://intel-gfx-ci.01.org/tree/drm- > tip/Patchwork_131124v2/index.html > Participating hosts (35 -> 35)Additional (2): bat-arls-4 bat-jsl-1 > Missing (2): bat-dg2-11 fi-snb-2520m > Possible new issuesHere are the unknown changes that may have been introduced in > Patchwork_131124v2: > IGT changesPossible regressions * igt@i915_selftest@live@hangcheck:bat-adln-1: PASS -> ABORT > Known issuesHere are the changes found in Patchwork_131124v2 that come from known > issues: > CI changesIssues hit * boot:bat-arls-3: PASS -> FAIL (i915#10234)bat-jsl-1: NOTRUN -> FAIL > (i915#8293)fi-apl-guc: PASS -> FAIL (i915#8293) > Possible fixes * boot:fi-cfl-8109u: FAIL (i915#8293) -> PASS > IGT changesIssues hit * igt@dmabuf@all-tests@dma_fence_chain:fi-kbl-8809g: PASS -> > INCOMPLETE (i915#10454) > * igt@gem_huc_copy@huc-copy:fi-cfl-8109u: NOTRUN -> SKIP (i915#2190) > * igt@gem_lmem_swapping@verify-random:fi-cfl-8109u: NOTRUN -> SKIP > (i915#4613) +3 other tests skip > * igt@i915_selftest@live@gem:bat-dg2-8: PASS -> ABORT (i915#10366) > * igt@kms_pm_backlight@basic-brightness:fi-cfl-8109u: NOTRUN -> SKIP > +11 other tests skip > Possible fixes * igt@i915_selftest@live@hangcheck:bat-adlp-6: ABORT (i915#10021) -> > PASS > {name}: This element is suppressed. This means it is ignored when > computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > Build changes * Linux: CI_DRM_14443 -> Patchwork_131124v2 > CI-20190529: 20190529 > CI_DRM_14443: ce8cc731d53f9197a853b0d00386d7835f2b80e6 @ > git://anongit.freedesktop.org/gfx-ci/linux > IGT_7769: 7769 > Patchwork_131124v2: ce8cc731d53f9197a853b0d00386d7835f2b80e6 @ > git://anongit.freedesktop.org/gfx-ci/linux > Linux commits2ef377f406a9 drm/i915/display: tie DMC wakelock to DC5/6 state > transitions > 65265f211717 drm/i915/display: add module parameter to enable DMC > wakelock > b6649b71e886 drm/i915/display: don't allow DMC wakelock on older > hardware > 42bb743a04e4 drm/i915/display: add support for DMC wakelocks
Hi, This is the fifth version of my series, the third as a proper patchset. These are the changes: In v3: * Fixed some checkpatch issues. In v2: * Enable/disable the wakelocks on DC5-6 entry and exit instead of on DMC load and unload; * Added bspec link to the commit message; * A bunch of other small changes; * For the complete list of changes and discussions, please look at the patchset in patchwork: https://patchwork.freedesktop.org/series/128628/ Please review. Cheers, Luca. Luca Coelho (4): drm/i915/display: add support for DMC wakelocks drm/i915/display: don't allow DMC wakelock on older hardware drm/i915/display: add module parameter to enable DMC wakelock drm/i915/display: tie DMC wakelock to DC5/6 state transitions drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_de.h | 97 ++++++- .../gpu/drm/i915/display/intel_display_core.h | 2 + .../drm/i915/display/intel_display_driver.c | 1 + .../drm/i915/display/intel_display_params.c | 5 + .../drm/i915/display/intel_display_params.h | 1 + .../i915/display/intel_display_power_well.c | 7 + drivers/gpu/drm/i915/display/intel_dmc.c | 4 + drivers/gpu/drm/i915/display/intel_dmc_regs.h | 6 + drivers/gpu/drm/i915/display/intel_dmc_wl.c | 242 ++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dmc_wl.h | 30 +++ drivers/gpu/drm/xe/Makefile | 1 + 12 files changed, 389 insertions(+), 8 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_dmc_wl.c create mode 100644 drivers/gpu/drm/i915/display/intel_dmc_wl.h