diff mbox series

nouveau/gsp: don't check devinit disable on GSP.

Message ID 20240314014521.2695233-1-airlied@gmail.com (mailing list archive)
State New, archived
Headers show
Series nouveau/gsp: don't check devinit disable on GSP. | expand

Commit Message

Dave Airlie March 14, 2024, 1:45 a.m. UTC
From: Dave Airlie <airlied@redhat.com>

GSP should be handling this and I can see no evidence in opengpu
driver that this register should be touched.

Fixed acceleration on 2080 Ti GPUs.

Fixes: 15740541e8f0 ("drm/nouveau/devinit/tu102-: prepare for GSP-RM")

Signed-off-by: Dave Airlie <airlied@redhat.com>
---
 drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Timothy Maden March 19, 2024, 5:38 p.m. UTC | #1
Hello

Can this be merged please ?

On 3/14/24 03:45, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
> 
> GSP should be handling this and I can see no evidence in opengpu
> driver that this register should be touched.
> 
> Fixed acceleration on 2080 Ti GPUs.
> 
> Fixes: 15740541e8f0 ("drm/nouveau/devinit/tu102-: prepare for GSP-RM")
> 
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> ---
>   drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c
> index 666eb93b1742..11b4c9c274a1 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c
> @@ -41,7 +41,6 @@ r535_devinit_new(const struct nvkm_devinit_func *hw,
>   
>   	rm->dtor = r535_devinit_dtor;
>   	rm->post = hw->post;
> -	rm->disable = hw->disable;
>   
>   	ret = nv50_devinit_new_(rm, device, type, inst, pdevinit);
>   	if (ret)
Danilo Krummrich March 19, 2024, 5:39 p.m. UTC | #2
On 3/19/24 18:38, Timothy Maden wrote:
> Hello
> 
> Can this be merged please ?

Applied this to drm-misc-next-fixes a couple of hours ago.

- Danilo

> 
> On 3/14/24 03:45, Dave Airlie wrote:
>> From: Dave Airlie <airlied@redhat.com>
>>
>> GSP should be handling this and I can see no evidence in opengpu
>> driver that this register should be touched.
>>
>> Fixed acceleration on 2080 Ti GPUs.
>>
>> Fixes: 15740541e8f0 ("drm/nouveau/devinit/tu102-: prepare for GSP-RM")
>>
>> Signed-off-by: Dave Airlie <airlied@redhat.com>
>> ---
>>   drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c
>> index 666eb93b1742..11b4c9c274a1 100644
>> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c
>> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c
>> @@ -41,7 +41,6 @@ r535_devinit_new(const struct nvkm_devinit_func *hw,
>>       rm->dtor = r535_devinit_dtor;
>>       rm->post = hw->post;
>> -    rm->disable = hw->disable;
>>       ret = nv50_devinit_new_(rm, device, type, inst, pdevinit);
>>       if (ret)
> 
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c
index 666eb93b1742..11b4c9c274a1 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/devinit/r535.c
@@ -41,7 +41,6 @@  r535_devinit_new(const struct nvkm_devinit_func *hw,
 
 	rm->dtor = r535_devinit_dtor;
 	rm->post = hw->post;
-	rm->disable = hw->disable;
 
 	ret = nv50_devinit_new_(rm, device, type, inst, pdevinit);
 	if (ret)