| Message ID | 20240306073016.2163-4-quic_okukatla@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for QoS configuration | expand |
On 06/03/2024 08:30, Odelu Kukatla wrote: > Added clock property to enable clocks required for accessing > qos registers. > > Signed-off-by: Odelu Kukatla <quic_okukatla@quicinc.com> > --- > .../interconnect/qcom,sc7280-rpmh.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml > index b135597d9489..758a6e924037 100644 > --- a/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml > +++ b/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml > @@ -53,10 +53,50 @@ allOf: > required: > - reg > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sc7280-aggre1-noc > + then: > + properties: > + clocks: All properties must be defined in top-level. > + items: > + - description: aggre UFS PHY AXI clock > + - description: aggre USB3 PRIM AXI clock > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sc7280-aggre2-noc > + then: > + properties: > + clocks: > + items: > + - description: RPMH CC IPA clock > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sc7280-aggre1-noc > + - qcom,sc7280-aggre2-noc > + then: > + required: > + - clocks That's an ABI break without reason. This is a stable and already used platform, so clear NAK. Best regards, Krzysztof
On 3/6/2024 1:56 PM, Krzysztof Kozlowski wrote: > On 06/03/2024 08:30, Odelu Kukatla wrote: >> Added clock property to enable clocks required for accessing >> qos registers. >> >> Signed-off-by: Odelu Kukatla <quic_okukatla@quicinc.com> >> --- >> .../interconnect/qcom,sc7280-rpmh.yaml | 49 +++++++++++++++++++ >> 1 file changed, 49 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml >> index b135597d9489..758a6e924037 100644 >> --- a/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml >> +++ b/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml >> @@ -53,10 +53,50 @@ allOf: >> required: >> - reg >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,sc7280-aggre1-noc >> + then: >> + properties: >> + clocks: > > All properties must be defined in top-level. > I will address this in v4, "clocks" property could be optional. >> + items: >> + - description: aggre UFS PHY AXI clock >> + - description: aggre USB3 PRIM AXI clock >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,sc7280-aggre2-noc >> + then: >> + properties: >> + clocks: >> + items: >> + - description: RPMH CC IPA clock >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,sc7280-aggre1-noc >> + - qcom,sc7280-aggre2-noc >> + then: >> + required: >> + - clocks > > That's an ABI break without reason. This is a stable and already used > platform, so clear NAK. > > Best regards, > Krzysztof > Thanks, Odelu
diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml index b135597d9489..758a6e924037 100644 --- a/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml +++ b/Documentation/devicetree/bindings/interconnect/qcom,sc7280-rpmh.yaml @@ -53,10 +53,50 @@ allOf: required: - reg + - if: + properties: + compatible: + contains: + enum: + - qcom,sc7280-aggre1-noc + then: + properties: + clocks: + items: + - description: aggre UFS PHY AXI clock + - description: aggre USB3 PRIM AXI clock + + - if: + properties: + compatible: + contains: + enum: + - qcom,sc7280-aggre2-noc + then: + properties: + clocks: + items: + - description: RPMH CC IPA clock + + - if: + properties: + compatible: + contains: + enum: + - qcom,sc7280-aggre1-noc + - qcom,sc7280-aggre2-noc + then: + required: + - clocks + else: + properties: + clocks: false + unevaluatedProperties: false examples: - | + #include <dt-bindings/clock/qcom,gcc-sc7280.h> interconnect { compatible = "qcom,sc7280-clk-virt"; #interconnect-cells = <2>; @@ -69,3 +109,12 @@ examples: #interconnect-cells = <2>; qcom,bcm-voters = <&apps_bcm_voter>; }; + + interconnect@16e0000 { + reg = <0x016e0000 0x1c080>; + compatible = "qcom,sc7280-aggre1-noc"; + #interconnect-cells = <2>; + qcom,bcm-voters = <&apps_bcm_voter>; + clocks = <&gcc GCC_AGGRE_UFS_PHY_AXI_CLK>, + <&gcc GCC_AGGRE_USB3_PRIM_AXI_CLK>; + };
Added clock property to enable clocks required for accessing qos registers. Signed-off-by: Odelu Kukatla <quic_okukatla@quicinc.com> --- .../interconnect/qcom,sc7280-rpmh.yaml | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+)