| Message ID | 20240318110602.37166-1-xuanzhuo@linux.alibaba.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | virtio-net: support device stats | expand |
Mon, Mar 18, 2024 at 12:05:53PM CET, xuanzhuo@linux.alibaba.com wrote: >As the spec: > >https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 > >The virtio net supports to get device stats. > >Please review. net-next is closed. Please resubmit next week.
On Mon, 18 Mar 2024 12:52:18 +0100, Jiri Pirko <jiri@resnulli.us> wrote: > Mon, Mar 18, 2024 at 12:05:53PM CET, xuanzhuo@linux.alibaba.com wrote: > >As the spec: > > > >https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 > > > >The virtio net supports to get device stats. > > > >Please review. > > net-next is closed. Please resubmit next week. For review. Thanks.
Mon, Mar 18, 2024 at 12:53:38PM CET, xuanzhuo@linux.alibaba.com wrote: >On Mon, 18 Mar 2024 12:52:18 +0100, Jiri Pirko <jiri@resnulli.us> wrote: >> Mon, Mar 18, 2024 at 12:05:53PM CET, xuanzhuo@linux.alibaba.com wrote: >> >As the spec: >> > >> >https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 >> > >> >The virtio net supports to get device stats. >> > >> >Please review. >> >> net-next is closed. Please resubmit next week. > > >For review. RFC, or wait. > >Thanks.
On Mon, 2024-03-18 at 13:19 +0100, Jiri Pirko wrote: > Mon, Mar 18, 2024 at 12:53:38PM CET, xuanzhuo@linux.alibaba.com wrote: > > On Mon, 18 Mar 2024 12:52:18 +0100, Jiri Pirko <jiri@resnulli.us> wrote: > > > Mon, Mar 18, 2024 at 12:05:53PM CET, xuanzhuo@linux.alibaba.com wrote: > > > > As the spec: > > > > > > > > https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 > > > > > > > > The virtio net supports to get device stats. > > > > > > > > Please review. > > > > > > net-next is closed. Please resubmit next week. > > > > > > For review. > > RFC, or wait. @Xuan, please note that you received exactly the same feedback on your previous submission, a few days ago. While I do understand the legit interest in reviews, ignoring explicit feedback tend to bring no feedback at all. Paolo
On Tue, 19 Mar 2024 11:12:23 +0100, Paolo Abeni <pabeni@redhat.com> wrote: > On Mon, 2024-03-18 at 13:19 +0100, Jiri Pirko wrote: > > Mon, Mar 18, 2024 at 12:53:38PM CET, xuanzhuo@linux.alibaba.com wrote: > > > On Mon, 18 Mar 2024 12:52:18 +0100, Jiri Pirko <jiri@resnulli.us> wrote: > > > > Mon, Mar 18, 2024 at 12:05:53PM CET, xuanzhuo@linux.alibaba.com wrote: > > > > > As the spec: > > > > > > > > > > https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 > > > > > > > > > > The virtio net supports to get device stats. > > > > > > > > > > Please review. > > > > > > > > net-next is closed. Please resubmit next week. > > > > > > > > > For review. > > > > RFC, or wait. > > @Xuan, please note that you received exactly the same feedback on your > previous submission, a few days ago. While I do understand the legit > interest in reviews, ignoring explicit feedback tend to bring no > feedback at all. Sorry. I have a question regarding the workflow for feature discussions. If we consistently engage in discussions about a particular feature, this may result in the submission of multiple patch sets. In light of this, should we modify the usage of "PATCH" or "RFC" in our submissions depending on whether the merge window is open or closed? This causes the title of our patch sets to keep changing. Or I miss something. Thanks. > > Paolo >
Hope this in your list. Thanks.
Wed, Mar 20, 2024 at 09:04:21AM CET, xuanzhuo@linux.alibaba.com wrote: >On Tue, 19 Mar 2024 11:12:23 +0100, Paolo Abeni <pabeni@redhat.com> wrote: >> On Mon, 2024-03-18 at 13:19 +0100, Jiri Pirko wrote: >> > Mon, Mar 18, 2024 at 12:53:38PM CET, xuanzhuo@linux.alibaba.com wrote: >> > > On Mon, 18 Mar 2024 12:52:18 +0100, Jiri Pirko <jiri@resnulli.us> wrote: >> > > > Mon, Mar 18, 2024 at 12:05:53PM CET, xuanzhuo@linux.alibaba.com wrote: >> > > > > As the spec: >> > > > > >> > > > > https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 >> > > > > >> > > > > The virtio net supports to get device stats. >> > > > > >> > > > > Please review. >> > > > >> > > > net-next is closed. Please resubmit next week. >> > > >> > > >> > > For review. >> > >> > RFC, or wait. >> >> @Xuan, please note that you received exactly the same feedback on your >> previous submission, a few days ago. While I do understand the legit >> interest in reviews, ignoring explicit feedback tend to bring no >> feedback at all. > >Sorry. > >I have a question regarding the workflow for feature discussions. If we >consistently engage in discussions about a particular feature, this may result >in the submission of multiple patch sets. In light of this, should we modify the >usage of "PATCH" or "RFC" in our submissions depending on whether the merge No, just wait 2 weeks, simple. >window is open or closed? This causes the title of our patch sets to keep >changing. > >Or I miss something. > > >Thanks. > > >> >> Paolo >>
On Wed, 20 Mar 2024 16:04:21 +0800 Xuan Zhuo wrote: > I have a question regarding the workflow for feature discussions. If we > consistently engage in discussions about a particular feature, this may result > in the submission of multiple patch sets. In light of this, should we modify the > usage of "PATCH" or "RFC" in our submissions depending on whether the merge > window is open or closed? This causes the title of our patch sets to keep > changing. Is switching between RFC and PATCH causing issues? Should be a simple modification to the git format-patch argument. But perhaps your workload is different than mine. The merge window is only 2 weeks every 10 weeks, it's not changing often, I don't think.
On Wed, 20 Mar 2024 20:38:01 -0700, Jakub Kicinski <kuba@kernel.org> wrote: > On Wed, 20 Mar 2024 16:04:21 +0800 Xuan Zhuo wrote: > > I have a question regarding the workflow for feature discussions. If we > > consistently engage in discussions about a particular feature, this may result > > in the submission of multiple patch sets. In light of this, should we modify the > > usage of "PATCH" or "RFC" in our submissions depending on whether the merge > > window is open or closed? This causes the title of our patch sets to keep > > changing. > > Is switching between RFC and PATCH causing issues? You know someone may ignore the RFC patches. And for me, that the pathsets for the particular feture have differ prefix "PATCH" or "RFC" is odd. > Should be a simple modification to the git format-patch argument. That is ok. > But perhaps your workload is different than mine. > > The merge window is only 2 weeks every 10 weeks, it's not changing > often, I don't think. YES. I'm ok, if that is a rule. Thanks.
On Thu, Mar 21, 2024 at 11:54:34AM +0800, Xuan Zhuo wrote: > On Wed, 20 Mar 2024 20:38:01 -0700, Jakub Kicinski <kuba@kernel.org> wrote: > > On Wed, 20 Mar 2024 16:04:21 +0800 Xuan Zhuo wrote: > > > I have a question regarding the workflow for feature discussions. If we > > > consistently engage in discussions about a particular feature, this may result > > > in the submission of multiple patch sets. In light of this, should we modify the > > > usage of "PATCH" or "RFC" in our submissions depending on whether the merge > > > window is open or closed? This causes the title of our patch sets to keep > > > changing. > > > > Is switching between RFC and PATCH causing issues? > > You know someone may ignore the RFC patches. > And for me, that the pathsets for the particular feture have differ > prefix "PATCH" or "RFC" is odd. > > > Should be a simple modification to the git format-patch argument. > > That is ok. > > > > But perhaps your workload is different than mine. > > > > The merge window is only 2 weeks every 10 weeks, it's not changing > > often, I don't think. > > YES. I'm ok, if that is a rule. Hi, Maybe this helps: It is a long standing rule that for netdev, during the merge window, net-next is closed. During this time bugfixes may be posted (for net), and RFCs may be posted. https://docs.kernel.org/process/maintainer-netdev.html#git-trees-and-patch-flow
On Mon, Mar 18, 2024 at 07:05:53PM +0800, Xuan Zhuo wrote: > As the spec: > > https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 > > The virtio net supports to get device stats. > > Please review. series: Acked-by: Michael S. Tsirkin <mst@redhat.com> I think you can now repost for net-next. > Thanks. > > v5: > 1. Fix some small problems in last version > 2. Not report stats that will be reported by netlink > 3. remove "_queue" from ethtool -S > > v4: > 1. Support per-queue statistics API > 2. Fix some small problems in last version > > v3: > 1. rebase net-next > > v2: > 1. fix the usage of the leXX_to_cpu() > 2. add comment to the structure virtnet_stats_map > > v1: > 1. fix some definitions of the marco and the struct > > > > > > > Xuan Zhuo (9): > virtio_net: introduce device stats feature and structures > virtio_net: virtnet_send_command supports command-specific-result > virtio_net: remove "_queue" from ethtool -S > virtio_net: support device stats > virtio_net: stats map include driver stats > virtio_net: add the total stats field > virtio_net: rename stat tx_timeout to timeout > netdev: add queue stats > virtio-net: support queue stat > > Documentation/netlink/specs/netdev.yaml | 104 ++++ > drivers/net/virtio_net.c | 755 +++++++++++++++++++++--- > include/net/netdev_queues.h | 27 + > include/uapi/linux/netdev.h | 19 + > include/uapi/linux/virtio_net.h | 143 +++++ > net/core/netdev-genl.c | 23 +- > tools/include/uapi/linux/netdev.h | 19 + > 7 files changed, 1013 insertions(+), 77 deletions(-) > > -- > 2.32.0.3.g01195cf9f
On Mon, 22 Apr 2024 16:33:01 -0400, "Michael S. Tsirkin" <mst@redhat.com> wrote: > On Mon, Mar 18, 2024 at 07:05:53PM +0800, Xuan Zhuo wrote: > > As the spec: > > > > https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 > > > > The virtio net supports to get device stats. > > > > Please review. > > series: > > Acked-by: Michael S. Tsirkin <mst@redhat.com> > > I think you can now repost for net-next. Thanks for your ack. I and Jason discussed a way to remove the "maps". I will post a new patch set with that. Thanks. > > > > Thanks. > > > > v5: > > 1. Fix some small problems in last version > > 2. Not report stats that will be reported by netlink > > 3. remove "_queue" from ethtool -S > > > > v4: > > 1. Support per-queue statistics API > > 2. Fix some small problems in last version > > > > v3: > > 1. rebase net-next > > > > v2: > > 1. fix the usage of the leXX_to_cpu() > > 2. add comment to the structure virtnet_stats_map > > > > v1: > > 1. fix some definitions of the marco and the struct > > > > > > > > > > > > > > Xuan Zhuo (9): > > virtio_net: introduce device stats feature and structures > > virtio_net: virtnet_send_command supports command-specific-result > > virtio_net: remove "_queue" from ethtool -S > > virtio_net: support device stats > > virtio_net: stats map include driver stats > > virtio_net: add the total stats field > > virtio_net: rename stat tx_timeout to timeout > > netdev: add queue stats > > virtio-net: support queue stat > > > > Documentation/netlink/specs/netdev.yaml | 104 ++++ > > drivers/net/virtio_net.c | 755 +++++++++++++++++++++--- > > include/net/netdev_queues.h | 27 + > > include/uapi/linux/netdev.h | 19 + > > include/uapi/linux/virtio_net.h | 143 +++++ > > net/core/netdev-genl.c | 23 +- > > tools/include/uapi/linux/netdev.h | 19 + > > 7 files changed, 1013 insertions(+), 77 deletions(-) > > > > -- > > 2.32.0.3.g01195cf9f >
As the spec: https://github.com/oasis-tcs/virtio-spec/commit/42f389989823039724f95bbbd243291ab0064f82 The virtio net supports to get device stats. Please review. Thanks. v5: 1. Fix some small problems in last version 2. Not report stats that will be reported by netlink 3. remove "_queue" from ethtool -S v4: 1. Support per-queue statistics API 2. Fix some small problems in last version v3: 1. rebase net-next v2: 1. fix the usage of the leXX_to_cpu() 2. add comment to the structure virtnet_stats_map v1: 1. fix some definitions of the marco and the struct Xuan Zhuo (9): virtio_net: introduce device stats feature and structures virtio_net: virtnet_send_command supports command-specific-result virtio_net: remove "_queue" from ethtool -S virtio_net: support device stats virtio_net: stats map include driver stats virtio_net: add the total stats field virtio_net: rename stat tx_timeout to timeout netdev: add queue stats virtio-net: support queue stat Documentation/netlink/specs/netdev.yaml | 104 ++++ drivers/net/virtio_net.c | 755 +++++++++++++++++++++--- include/net/netdev_queues.h | 27 + include/uapi/linux/netdev.h | 19 + include/uapi/linux/virtio_net.h | 143 +++++ net/core/netdev-genl.c | 23 +- tools/include/uapi/linux/netdev.h | 19 + 7 files changed, 1013 insertions(+), 77 deletions(-) -- 2.32.0.3.g01195cf9f