| Message ID | 20240321021925.513182-1-youwan@nfschina.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 97fa2525fb104856c80f67af27cd87af09a41c4d |
| Headers | show |
| Series | [BlueZ] obexd: Remove redundant judgments and fix code style | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=836899 ---Test result--- Test Summary: CheckPatch PASS 0.42 seconds GitLint PASS 0.28 seconds BuildEll PASS 24.09 seconds BluezMake PASS 1679.29 seconds MakeCheck PASS 13.50 seconds MakeDistcheck PASS 173.88 seconds CheckValgrind PASS 243.37 seconds CheckSmatch PASS 344.29 seconds bluezmakeextell PASS 117.17 seconds IncrementalBuild PASS 1440.27 seconds ScanBuild PASS 974.88 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 21 Mar 2024 10:19:25 +0800 you wrote: > Signed-off-by: Youwan Wang <youwan@nfschina.com> > --- > obexd/src/manager.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Here is the summary with links: - [BlueZ] obexd: Remove redundant judgments and fix code style https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=97fa2525fb10 You are awesome, thank you!
diff --git a/obexd/src/manager.c b/obexd/src/manager.c index 73fd6b9af..c393911a7 100644 --- a/obexd/src/manager.c +++ b/obexd/src/manager.c @@ -525,7 +525,7 @@ void manager_cleanup(void) void manager_emit_transfer_property(struct obex_transfer *transfer, char *name) { - if (!transfer->path) + if (transfer->path == NULL) return; g_dbus_emit_property_changed(connection, transfer->path, @@ -542,9 +542,6 @@ void manager_emit_transfer_started(struct obex_transfer *transfer) static void emit_transfer_completed(struct obex_transfer *transfer, gboolean success) { - if (transfer->path == NULL) - return; - transfer->status = success ? TRANSFER_STATUS_COMPLETE : TRANSFER_STATUS_ERROR;
Signed-off-by: Youwan Wang <youwan@nfschina.com> --- obexd/src/manager.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)