| Message ID | 20240320112519.5311-1-dgouarin@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v3] dpaa_eth: fix XDP queue index | expand |
On Wed, 2024-03-20 at 12:25 +0100, David Gouarin wrote: > Make it possible to bind a XDP socket to a queue id. > The DPAA FQ Id was passed to the XDP program in the > xdp_rxq_info->queue_index instead of the Ethernet device queue number, > which made it unusable with bpf_map_redirect. > Instead of the DPAA FQ Id, initialise the XDP rx queue with the queue number. > > Fixes: d57e57d0cd04 ("dpaa_eth: add XDP_TX support") > > Signed-off-by: David Gouarin <dgouarin@gmail.com> The patch LGTM, but you must avoid empty lines in after the 'Fixes' tag. Please have an accurate reading of the process documentation. Thanks, Paolo
diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c index dcbc598b11c6..988dc9237368 100644 --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c @@ -1154,7 +1154,7 @@ static int dpaa_fq_init(struct dpaa_fq *dpaa_fq, bool td_enable) if (dpaa_fq->fq_type == FQ_TYPE_RX_DEFAULT || dpaa_fq->fq_type == FQ_TYPE_RX_PCD) { err = xdp_rxq_info_reg(&dpaa_fq->xdp_rxq, dpaa_fq->net_dev, - dpaa_fq->fqid, 0); + dpaa_fq->channel, 0); if (err) { dev_err(dev, "xdp_rxq_info_reg() = %d\n", err); return err;
Make it possible to bind a XDP socket to a queue id. The DPAA FQ Id was passed to the XDP program in the xdp_rxq_info->queue_index instead of the Ethernet device queue number, which made it unusable with bpf_map_redirect. Instead of the DPAA FQ Id, initialise the XDP rx queue with the queue number. Fixes: d57e57d0cd04 ("dpaa_eth: add XDP_TX support") Signed-off-by: David Gouarin <dgouarin@gmail.com> --- v3: reword commit message v2: add Fixes: in description --- drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)