| Message ID | 20240314-b4-for-net-mt7530-fix-link-local-vlan-v2-0-7dbcf6429ba0@arinc9.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | MT7530 DSA subdriver fix VLAN egress and handling of all link-local frames | expand |
On 14.03.2024 12:33, Arınç ÜNAL via B4 Relay wrote: > Hi. > > This patch series fixes the VLAN tag egress procedure for link-local > frames, and fixes handling of all link-local frames. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- > Changes in v2: > - Add Fixes: tag to both patches. > - Link to v1: https://lore.kernel.org/r/20240311-b4-for-net-mt7530-fix-link-local-vlan-v1-0-d67e6cc31af2@arinc9.com > > --- > Arınç ÜNAL (2): > net: dsa: mt7530: fix link-local frames that ingress vlan filtering ports > net: dsa: mt7530: fix handling of all link-local frames > > drivers/net/dsa/mt7530.c | 52 ++++++++++++++++++++++++++++++++++++++++-------- > drivers/net/dsa/mt7530.h | 22 +++++++++++++++++++- > 2 files changed, 65 insertions(+), 9 deletions(-) > --- > base-commit: d7d75124965aee23e5e4421d78376545cf070b0a > change-id: 20240208-b4-for-net-mt7530-fix-link-local-vlan-af6e9928ad8d > > Best regards, Reminder this patch series is waiting to be applied. Arınç
On Wed, 2024-03-20 at 19:41 +0300, Arınç ÜNAL wrote: > On 14.03.2024 12:33, Arınç ÜNAL via B4 Relay wrote: > > Hi. > > > > This patch series fixes the VLAN tag egress procedure for link-local > > frames, and fixes handling of all link-local frames. > > > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > > --- > > Changes in v2: > > - Add Fixes: tag to both patches. > > - Link to v1: https://lore.kernel.org/r/20240311-b4-for-net-mt7530-fix-link-local-vlan-v1-0-d67e6cc31af2@arinc9.com > > > > --- > > Arınç ÜNAL (2): > > net: dsa: mt7530: fix link-local frames that ingress vlan filtering ports > > net: dsa: mt7530: fix handling of all link-local frames > > > > drivers/net/dsa/mt7530.c | 52 ++++++++++++++++++++++++++++++++++++++++-------- > > drivers/net/dsa/mt7530.h | 22 +++++++++++++++++++- > > 2 files changed, 65 insertions(+), 9 deletions(-) > > --- > > base-commit: d7d75124965aee23e5e4421d78376545cf070b0a > > change-id: 20240208-b4-for-net-mt7530-fix-link-local-vlan-af6e9928ad8d > > > > Best regards, > > Reminder this patch series is waiting to be applied. I hoped to get some feedback from the DSA crew, so it waited a bit in patchwork. Anyway it looks like it staged long enough and I'll go through it soon. Cheers, Paolo
On 21.03.2024 12:29, Paolo Abeni wrote: > On Wed, 2024-03-20 at 19:41 +0300, Arınç ÜNAL wrote: >> On 14.03.2024 12:33, Arınç ÜNAL via B4 Relay wrote: >>> Hi. >>> >>> This patch series fixes the VLAN tag egress procedure for link-local >>> frames, and fixes handling of all link-local frames. >>> >>> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> >>> --- >>> Changes in v2: >>> - Add Fixes: tag to both patches. >>> - Link to v1: https://lore.kernel.org/r/20240311-b4-for-net-mt7530-fix-link-local-vlan-v1-0-d67e6cc31af2@arinc9.com >>> >>> --- >>> Arınç ÜNAL (2): >>> net: dsa: mt7530: fix link-local frames that ingress vlan filtering ports >>> net: dsa: mt7530: fix handling of all link-local frames >>> >>> drivers/net/dsa/mt7530.c | 52 ++++++++++++++++++++++++++++++++++++++++-------- >>> drivers/net/dsa/mt7530.h | 22 +++++++++++++++++++- >>> 2 files changed, 65 insertions(+), 9 deletions(-) >>> --- >>> base-commit: d7d75124965aee23e5e4421d78376545cf070b0a >>> change-id: 20240208-b4-for-net-mt7530-fix-link-local-vlan-af6e9928ad8d >>> >>> Best regards, >> >> Reminder this patch series is waiting to be applied. > > I hoped to get some feedback from the DSA crew, so it waited a bit in > patchwork. Anyway it looks like it staged long enough and I'll go > through it soon. Vladimir used to help me a lot. I hope everything's okay on their end. Arınç
On Wed, 2024-03-20 at 19:41 +0300, Arınç ÜNAL wrote: > On 14.03.2024 12:33, Arınç ÜNAL via B4 Relay wrote: > > Hi. > > > > This patch series fixes the VLAN tag egress procedure for link-local > > frames, and fixes handling of all link-local frames. > > > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> For future memory: I think the SoB in the cover letter is not required, and is, at least to me, a bit confusing. No action needed here, I'll keep this unmodified, but I suggest to omit it in future submission. Thanks! Paolo
Hello: This series was applied to netdev/net.git (main) by Paolo Abeni <pabeni@redhat.com>: On Thu, 14 Mar 2024 12:33:40 +0300 you wrote: > Hi. > > This patch series fixes the VLAN tag egress procedure for link-local > frames, and fixes handling of all link-local frames. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > > [...] Here is the summary with links: - [net,v2,1/2] net: dsa: mt7530: fix link-local frames that ingress vlan filtering ports https://git.kernel.org/netdev/net/c/e8bf353577f3 - [net,v2,2/2] net: dsa: mt7530: fix handling of all link-local frames https://git.kernel.org/netdev/net/c/69ddba9d170b You are awesome, thank you!
On 21.03.2024 14:18, Paolo Abeni wrote: > On Wed, 2024-03-20 at 19:41 +0300, Arınç ÜNAL wrote: >> On 14.03.2024 12:33, Arınç ÜNAL via B4 Relay wrote: >>> Hi. >>> >>> This patch series fixes the VLAN tag egress procedure for link-local >>> frames, and fixes handling of all link-local frames. >>> >>> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > > For future memory: I think the SoB in the cover letter is not required, > and is, at least to me, a bit confusing. > > No action needed here, I'll keep this unmodified, but I suggest to omit > it in future submission. b4 puts it on the cover letter so it's not my doing. Arınç
On Thu, Mar 21, 2024 at 02:29:19PM +0300, Arınç ÜNAL wrote: > > For future memory: I think the SoB in the cover letter is not required, > > and is, at least to me, a bit confusing. > > > > No action needed here, I'll keep this unmodified, but I suggest to omit > > it in future submission. > > b4 puts it on the cover letter so it's not my doing. This is done because many subsystems use the cover letter as the merge commit message. Those subsystems who don't follow this practice don't generally care if there's a Signed-Off-By in the cover letter anyway, so I don't see why this is a concern that it's there. -K
On Thu, 21 Mar 2024 09:19:02 -0400 Konstantin Ryabitsev wrote: > On Thu, Mar 21, 2024 at 02:29:19PM +0300, Arınç ÜNAL wrote: > > > For future memory: I think the SoB in the cover letter is not required, > > > and is, at least to me, a bit confusing. > > > > > > No action needed here, I'll keep this unmodified, but I suggest to omit > > > it in future submission. > > > > b4 puts it on the cover letter so it's not my doing. > > This is done because many subsystems use the cover letter as the merge commit > message. Could be wrong, but I think it was DaveM who originated this practice, in networking.. > Those subsystems who don't follow this practice don't generally care > if there's a Signed-Off-By in the cover letter anyway, so I don't see why this > is a concern that it's there. Because we have to remove it, extra work. And the benefit of adding it in the first place is unclear.
Hi. This patch series fixes the VLAN tag egress procedure for link-local frames, and fixes handling of all link-local frames. Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- Changes in v2: - Add Fixes: tag to both patches. - Link to v1: https://lore.kernel.org/r/20240311-b4-for-net-mt7530-fix-link-local-vlan-v1-0-d67e6cc31af2@arinc9.com --- Arınç ÜNAL (2): net: dsa: mt7530: fix link-local frames that ingress vlan filtering ports net: dsa: mt7530: fix handling of all link-local frames drivers/net/dsa/mt7530.c | 52 ++++++++++++++++++++++++++++++++++++++++-------- drivers/net/dsa/mt7530.h | 22 +++++++++++++++++++- 2 files changed, 65 insertions(+), 9 deletions(-) --- base-commit: d7d75124965aee23e5e4421d78376545cf070b0a change-id: 20240208-b4-for-net-mt7530-fix-link-local-vlan-af6e9928ad8d Best regards,