mbox series

[blktests,v1,00/18] refactoring and various cleanups/fixes

Message ID 20240321094727.6503-1-dwagner@suse.de (mailing list archive)
Headers show
Series refactoring and various cleanups/fixes | expand

Message

Daniel Wagner March 21, 2024, 9:47 a.m. UTC 
While working on two new features I collected a bunch of patches which I think
make sense to review and merge them indepenedly. And I got a few more ideas for
refactoring and cleanups. But one step after the other.

Daniel Wagner (18):
  nvme/rc: silence error on module unload for fc
  nvme/rc: silence fcloop cleanup failures
  nvme/rc: log error if stale configuration is found
  common/xfs: propagate errors from _xfs_run_fio_verify_io
  nvme/{012,013,035}: check return value of _xfs_run_fio_verify_io
  nvme/rc: use long command line option for nvme
  nvme/{014,015,018,019,020,023,024,026,045,046}: use long command line
    option for nvme
  nvme/rc: connect subsys only support long options
  nvme/rc: add nqn/uuid args to target setup/cleanup helper
  nvme/rc: remove unused connect options
  nvme/rc: remove correct port from target
  nvme/031: do not open code target setup/cleanup
  nvme/{rc,031}: do not cleanup external managed loop device
  nvme: drop default trtype argument for _nvmet_connect_subsys
  nvme: drop default subsysnqn argument from
    _nvme_{connect|disconnect}_subsys
  nvme/{041,042,043,044,045,048}: do not pass default host{nqn|id} to
    _nvme_connect_subsys
  nvme: don't assume namespace id
  nvme/028: drop unused nvmedev

 common/xfs     |   9 ++-
 tests/nvme/003 |   4 +-
 tests/nvme/004 |   5 +-
 tests/nvme/005 |   2 +-
 tests/nvme/008 |   4 +-
 tests/nvme/009 |   4 +-
 tests/nvme/010 |  11 ++--
 tests/nvme/011 |  11 ++--
 tests/nvme/012 |  13 ++--
 tests/nvme/013 |  13 ++--
 tests/nvme/014 |  17 +++--
 tests/nvme/015 |  17 +++--
 tests/nvme/018 |  20 +++---
 tests/nvme/019 |  13 ++--
 tests/nvme/020 |  12 ++--
 tests/nvme/021 |  11 ++--
 tests/nvme/022 |   4 +-
 tests/nvme/023 |  11 ++--
 tests/nvme/024 |  12 ++--
 tests/nvme/025 |  11 ++--
 tests/nvme/026 |  11 ++--
 tests/nvme/027 |   4 +-
 tests/nvme/028 |   9 +--
 tests/nvme/029 |  10 +--
 tests/nvme/031 |  14 ++--
 tests/nvme/035 |   4 +-
 tests/nvme/040 |   6 +-
 tests/nvme/041 |  13 ++--
 tests/nvme/042 |  14 ++--
 tests/nvme/043 |  14 ++--
 tests/nvme/044 |  28 +++-----
 tests/nvme/045 |  17 ++---
 tests/nvme/046 |   7 +-
 tests/nvme/047 |  16 ++---
 tests/nvme/048 |   9 +--
 tests/nvme/rc  | 170 +++++++++++++++++++++++++++++++++----------------
 36 files changed, 282 insertions(+), 268 deletions(-)

Comments

Shin'ichiro Kawasaki March 22, 2024, 9:38 a.m. UTC | #1 
On Mar 21, 2024 / 10:47, Daniel Wagner wrote:
> While working on two new features I collected a bunch of patches which I think
> make sense to review and merge them indepenedly. And I got a few more ideas for
> refactoring and cleanups. But one step after the other.

Overall, the patches in this series look reasonable for me. Most of them are
part of the RFC series for the real target support, so it's good to have this
series for separate review.

I made some nit review comments on the patches. I will do trial runs after v2
comes out. Thanks!
Daniel Wagner March 22, 2024, 12:35 p.m. UTC | #2 
On Fri, Mar 22, 2024 at 09:38:16AM +0000, Shinichiro Kawasaki wrote:
> On Mar 21, 2024 / 10:47, Daniel Wagner wrote:
> > While working on two new features I collected a bunch of patches which I think
> > make sense to review and merge them indepenedly. And I got a few more ideas for
> > refactoring and cleanups. But one step after the other.
> 
> Overall, the patches in this series look reasonable for me. Most of them are
> part of the RFC series for the real target support, so it's good to have this
> series for separate review.
> 
> I made some nit review comments on the patches. I will do trial runs after v2
> comes out. Thanks!

Thanks for reviewing. I'm updating the series according your feedback.
I avoid sending 'ok' to every point you made, because you are right
every single time :)