| Message ID | 20240308-puma-diode-pu-v2-0-309f83da110a@theobroma-systems.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | rockchip: small DTS fixes for RK3399 Puma | expand |
On Fri, 08 Mar 2024 16:46:06 +0100, Quentin Schulz wrote: > There's a pull-up missing on a pin that is used as GPIO input for PCIe > which will make the diode/level-shifter not let voltage pass and thus > not allowing the state of the pin to change. > > Also add the missing regulators for the PCIe PHY+connector though this > is purely cosmetic. > > [...] Applied, thanks! [1/3] arm64: dts: rockchip: enable internal pull-up on Q7_USB_ID for RK3399 Puma commit: e6b1168f37e3f86d9966276c5a3fff9eb0df3e5f [2/3] arm64: dts: rockchip: enable internal pull-up on PCIE_WAKE# for RK3399 Puma commit: 945a7c8570916650a415757d15d83e0fa856a686 [3/3] arm64: dts: rockchip: add regulators for PCIe on RK3399 Puma Haikou commit: d7ed698abc28b2886c9fc71d17ca6b023fcf47f3 Best regards,
There's a pull-up missing on a pin that is used as GPIO input for PCIe which will make the diode/level-shifter not let voltage pass and thus not allowing the state of the pin to change. Also add the missing regulators for the PCIe PHY+connector though this is purely cosmetic. There's also a missing PU on the USB ID pin used as a GPIO input, so let's add it for the same reasons as the one used for PCIe listed above. Note there's a light dependency on https://lore.kernel.org/linux-rockchip/43d84aa9-ce0f-406e-82ac-2a691264ee23@theobroma-systems.com/T/#ma0499cbc5e5c20f1a4c6b8452baa2d296abe2d0d to prevent a git conflict for the maintainer(s). Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com> --- Changes in v2: - added underscore in regulator names to match schematics, - reworded commit log for PCIE_WAKE# pull-up as suggested off-list by Heiko, - Link to v1: https://lore.kernel.org/r/20240308-puma-diode-pu-v1-0-2b38457bcdc0@theobroma-systems.com --- Quentin Schulz (3): arm64: dts: rockchip: enable internal pull-up on Q7_USB_ID for RK3399 Puma arm64: dts: rockchip: enable internal pull-up on PCIE_WAKE# for RK3399 Puma arm64: dts: rockchip: add regulators for PCIe on RK3399 Puma Haikou .../arm64/boot/dts/rockchip/rk3399-puma-haikou.dts | 2 ++ arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi | 33 +++++++++++++++++++++- 2 files changed, 34 insertions(+), 1 deletion(-) --- base-commit: 370e52abbf8306f09b0022995ad7ccdff3a834bb change-id: 20240308-puma-diode-pu-1d2f4551be6d Best regards,