| Message ID | 20240325062831.48675-1-kerneljasonxing@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | tcp: make trace of reset logic complete | expand |
On Mon, 25 Mar 2024 14:28:28 +0800 Jason Xing wrote: > Before this, we miss some cases where the TCP layer could send rst but > we cannot trace it. So I decided to complete it :) > > v2 > 1. fix spelling mistakes Not only do you post it before we "officially" open net-next but also ignoring the 24h wait period. https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#tl-dr The main goal of the 24h rule is to stop people from bombarding us with new versions for silly reasons. You show know better than this, it's hardly your first contribution :(
On Tue, Mar 26, 2024 at 9:30 AM Jakub Kicinski <kuba@kernel.org> wrote: > > On Mon, 25 Mar 2024 14:28:28 +0800 Jason Xing wrote: > > Before this, we miss some cases where the TCP layer could send rst but > > we cannot trace it. So I decided to complete it :) > > > > v2 > > 1. fix spelling mistakes > > Not only do you post it before we "officially" open net-next but > also ignoring the 24h wait period. > > https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#tl-dr > > The main goal of the 24h rule is to stop people from bombarding us with > new versions for silly reasons. Sorry, I don't understand what you mean. I definitely know the rules. But the first version of this patch series was sent about two weeks ago (see link [1]) Yesterday, I posted two series to do two kinds of things. They are not the same. Maybe you get me wrong :S link [1]: https://patchwork.kernel.org/project/netdevbpf/list/?series=834178&state=* Thanks, Jason > > You show know better than this, it's hardly your first contribution :( > -- > pv-bot: 24h
On Tue, 26 Mar 2024 10:13:55 +0800 Jason Xing wrote: > Yesterday, I posted two series to do two kinds of things. They are not > the same. Maybe you get me wrong :S Ah, my bad, sorry about that. I see that they are different now. One is v1 the other v2, both targeting tcp tracing... Easy to miss in the post merge window rush :(
On Tue, Mar 26, 2024 at 10:23 AM Jakub Kicinski <kuba@kernel.org> wrote: > > On Tue, 26 Mar 2024 10:13:55 +0800 Jason Xing wrote: > > Yesterday, I posted two series to do two kinds of things. They are not > > the same. Maybe you get me wrong :S > > Ah, my bad, sorry about that. I see that they are different now. That's all right :) > One is v1 the other v2, both targeting tcp tracing... Easy to miss > in the post merge window rush :( Yes, and thanks for the check :)
From: Jason Xing <kernelxing@tencent.com> Before this, we miss some cases where the TCP layer could send rst but we cannot trace it. So I decided to complete it :) v2 1. fix spelling mistakes Jason Xing (3): trace: adjust TP_STORE_ADDR_PORTS_SKB() parameters trace: tcp: fully support trace_tcp_send_reset tcp: add location into reset trace process include/trace/events/tcp.h | 68 ++++++++++++++++++++++++++++++-------- net/ipv4/tcp_ipv4.c | 4 +-- net/ipv4/tcp_output.c | 2 +- net/ipv6/tcp_ipv6.c | 3 +- 4 files changed, 60 insertions(+), 17 deletions(-)