diff mbox series

acpi: EINJ: mark remove callback as non-__exit

Message ID 20240320180302.143707-1-arnd@kernel.org (mailing list archive)
State Mainlined, archived
Headers show
Series acpi: EINJ: mark remove callback as non-__exit | expand

Commit Message

Arnd Bergmann March 20, 2024, 6:02 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The remove callback of a device is called whenever it is unbound,
which may happen during runtime e.g. through sysfs, so this is not
allowed to be dropped from the binary:

WARNING: modpost: vmlinux: section mismatch in reference: einj_driver+0x8 (section: .data) -> einj_remove (section: .exit.text)
ERROR: modpost: Section mismatches detected.

Remove that annotation.

Fixes: 12fb28ea6b1c ("EINJ: Add CXL error type support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/acpi/apei/einj-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dan Williams March 20, 2024, 7:58 p.m. UTC | #1 
Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The remove callback of a device is called whenever it is unbound,
> which may happen during runtime e.g. through sysfs, so this is not
> allowed to be dropped from the binary:
> 
> WARNING: modpost: vmlinux: section mismatch in reference: einj_driver+0x8 (section: .data) -> einj_remove (section: .exit.text)
> ERROR: modpost: Section mismatches detected.
> 
> Remove that annotation.

Looks good, not sure why the build robots missed this while this was
sitting in -next. Yes, this was a side effect of reusing the former
einj_exit() as the device remove callback.

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

Rafael, can you pick this up?
Rafael J. Wysocki March 20, 2024, 8 p.m. UTC | #2 
On Wed, Mar 20, 2024 at 8:58 PM Dan Williams <dan.j.williams@intel.com> wrote:
>
> Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > The remove callback of a device is called whenever it is unbound,
> > which may happen during runtime e.g. through sysfs, so this is not
> > allowed to be dropped from the binary:
> >
> > WARNING: modpost: vmlinux: section mismatch in reference: einj_driver+0x8 (section: .data) -> einj_remove (section: .exit.text)
> > ERROR: modpost: Section mismatches detected.
> >
> > Remove that annotation.
>
> Looks good, not sure why the build robots missed this while this was
> sitting in -next. Yes, this was a side effect of reusing the former
> einj_exit() as the device remove callback.
>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
>
> Rafael, can you pick this up?

I will, thanks!
Rafael J. Wysocki March 26, 2024, 11:18 a.m. UTC | #3 
On Wed, Mar 20, 2024 at 9:00 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Wed, Mar 20, 2024 at 8:58 PM Dan Williams <dan.j.williams@intel.com> wrote:
> >
> > Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >
> > > The remove callback of a device is called whenever it is unbound,
> > > which may happen during runtime e.g. through sysfs, so this is not
> > > allowed to be dropped from the binary:
> > >
> > > WARNING: modpost: vmlinux: section mismatch in reference: einj_driver+0x8 (section: .data) -> einj_remove (section: .exit.text)
> > > ERROR: modpost: Section mismatches detected.
> > >
> > > Remove that annotation.
> >
> > Looks good, not sure why the build robots missed this while this was
> > sitting in -next. Yes, this was a side effect of reusing the former
> > einj_exit() as the device remove callback.
> >
> > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> >
> > Rafael, can you pick this up?
>
> I will, thanks!

Applied now, thanks!
diff mbox series

Patch

diff --git a/drivers/acpi/apei/einj-core.c b/drivers/acpi/apei/einj-core.c
index 66e7f529e92f..01faca3a238a 100644
--- a/drivers/acpi/apei/einj-core.c
+++ b/drivers/acpi/apei/einj-core.c
@@ -851,7 +851,7 @@  static int __init einj_probe(struct platform_device *pdev)
 	return rc;
 }
 
-static void __exit einj_remove(struct platform_device *pdev)
+static void einj_remove(struct platform_device *pdev)
 {
 	struct apei_exec_context ctx;