diff mbox series

net: amd8111e: Drop unused copy of pm_cap

Message ID 20240325220633.1453180-1-helgaas@kernel.org (mailing list archive)
State Accepted
Commit ee36b1e93b11b980e0156bd07cbb9866b7d3e29e
Delegated to: Netdev Maintainers
Headers show
Series net: amd8111e: Drop unused copy of pm_cap | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 944 this patch: 944
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 5 of 5 maintainers
netdev/build_clang success Errors and warnings before: 955 this patch: 955
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 955 this patch: 955
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 14 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-03-27--00-00 (tests: 948)

Commit Message

Bjorn Helgaas March 25, 2024, 10:06 p.m. UTC 
From: Bjorn Helgaas <bhelgaas@google.com>

The copy of pdev->pm_cap in struct amd8111e_priv is never used.  Drop it.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
 drivers/net/ethernet/amd/amd8111e.c | 1 -
 drivers/net/ethernet/amd/amd8111e.h | 1 -
 2 files changed, 2 deletions(-)

Comments

Simon Horman March 26, 2024, 2:51 p.m. UTC | #1 
On Mon, Mar 25, 2024 at 05:06:33PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> The copy of pdev->pm_cap in struct amd8111e_priv is never used.  Drop it.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

Reviewed-by: Simon Horman <horms@kernel.org>
patchwork-bot+netdevbpf@kernel.org March 27, 2024, 4:09 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 25 Mar 2024 17:06:33 -0500 you wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> The copy of pdev->pm_cap in struct amd8111e_priv is never used.  Drop it.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
>  drivers/net/ethernet/amd/amd8111e.c | 1 -
>  drivers/net/ethernet/amd/amd8111e.h | 1 -
>  2 files changed, 2 deletions(-)

Here is the summary with links:
  - net: amd8111e: Drop unused copy of pm_cap
    https://git.kernel.org/netdev/net-next/c/ee36b1e93b11

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/amd/amd8111e.c b/drivers/net/ethernet/amd/amd8111e.c
index ea6cfc2095e1..c1b5e9a94308 100644
--- a/drivers/net/ethernet/amd/amd8111e.c
+++ b/drivers/net/ethernet/amd/amd8111e.c
@@ -1796,7 +1796,6 @@  static int amd8111e_probe_one(struct pci_dev *pdev,
 	lp = netdev_priv(dev);
 	lp->pci_dev = pdev;
 	lp->amd8111e_net_dev = dev;
-	lp->pm_cap = pdev->pm_cap;
 
 	spin_lock_init(&lp->lock);
 
diff --git a/drivers/net/ethernet/amd/amd8111e.h b/drivers/net/ethernet/amd/amd8111e.h
index 9d570adb295b..305232f5476d 100644
--- a/drivers/net/ethernet/amd/amd8111e.h
+++ b/drivers/net/ethernet/amd/amd8111e.h
@@ -764,7 +764,6 @@  struct amd8111e_priv{
 	u32 ext_phy_id;
 
 	struct amd8111e_link_config link_config;
-	int pm_cap;
 
 	struct net_device *next;
 	int mii;