| Message ID | 20240326125849.226765-2-christophe.roullier@foss.st.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add properties in dwmac-stm32 documentation | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Tue, Mar 26, 2024 at 01:58:48PM +0100, Christophe Roullier wrote: > Phandle to a regulator that provides power to the PHY. This > regulator will be managed during the PHY power on/off sequence. > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Christophe Roullier <christophe.roullier@foss.st.com> > --- > Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > index fc8c96b08d7dc..80937b28fa046 100644 > --- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > @@ -82,6 +82,9 @@ properties: > Should be phandle/offset pair. The phandle to the syscon node which > encompases the glue register, and the offset of the control register > > + phy-supply: > + description: PHY regulator ~/linux/drivers/net/ethernet/stmicro/stmmac$ grep regulator_get * dwmac-rk.c: bsp_priv->regulator = devm_regulator_get(dev, "phy"); dwmac-sun8i.c: gmac->regulator = devm_regulator_get_optional(dev, "phy"); dwmac-sunxi.c: gmac->regulator = devm_regulator_get_optional(dev, "phy"); Maybe i'm missing something, but i don't see an actual implementation of this binding? Andrew
On 3/26/24 14:58, Andrew Lunn wrote: > On Tue, Mar 26, 2024 at 01:58:48PM +0100, Christophe Roullier wrote: >> Phandle to a regulator that provides power to the PHY. This >> regulator will be managed during the PHY power on/off sequence. >> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Signed-off-by: Christophe Roullier <christophe.roullier@foss.st.com> >> --- >> Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml >> index fc8c96b08d7dc..80937b28fa046 100644 >> --- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml >> @@ -82,6 +82,9 @@ properties: >> Should be phandle/offset pair. The phandle to the syscon node which >> encompases the glue register, and the offset of the control register >> >> + phy-supply: >> + description: PHY regulator > ~/linux/drivers/net/ethernet/stmicro/stmmac$ grep regulator_get * > dwmac-rk.c: bsp_priv->regulator = devm_regulator_get(dev, "phy"); > dwmac-sun8i.c: gmac->regulator = devm_regulator_get_optional(dev, "phy"); > dwmac-sunxi.c: gmac->regulator = devm_regulator_get_optional(dev, "phy"); > > Maybe i'm missing something, but i don't see an actual implementation > of this binding? > > Andrew Hi Andrew, You are right, my next step is to upstream support of Ethernet MP13 glue and some update like Phy regulator support (it is look like https://lore.kernel.org/linux-arm-kernel/20230928122427.313271-9-christophe.roullier@foss.st.com/) Regards, Christophe
On Tue, Mar 26, 2024 at 03:41:13PM +0100, Christophe ROULLIER wrote: > > On 3/26/24 14:58, Andrew Lunn wrote: > > On Tue, Mar 26, 2024 at 01:58:48PM +0100, Christophe Roullier wrote: > > > Phandle to a regulator that provides power to the PHY. This > > > regulator will be managed during the PHY power on/off sequence. > > > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > Signed-off-by: Christophe Roullier <christophe.roullier@foss.st.com> > > > --- > > > Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > > > index fc8c96b08d7dc..80937b28fa046 100644 > > > --- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > > > +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml > > > @@ -82,6 +82,9 @@ properties: > > > Should be phandle/offset pair. The phandle to the syscon node which > > > encompases the glue register, and the offset of the control register > > > + phy-supply: > > > + description: PHY regulator > > ~/linux/drivers/net/ethernet/stmicro/stmmac$ grep regulator_get * > > dwmac-rk.c: bsp_priv->regulator = devm_regulator_get(dev, "phy"); > > dwmac-sun8i.c: gmac->regulator = devm_regulator_get_optional(dev, "phy"); > > dwmac-sunxi.c: gmac->regulator = devm_regulator_get_optional(dev, "phy"); > > > > Maybe i'm missing something, but i don't see an actual implementation > > of this binding? > > > > Andrew > > Hi Andrew, > > You are right, my next step is to upstream support of Ethernet MP13 glue and > some update like Phy regulator support Then please make this binding patch part of the series which implements the binding. They go together. Andrew
diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml index fc8c96b08d7dc..80937b28fa046 100644 --- a/Documentation/devicetree/bindings/net/stm32-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/stm32-dwmac.yaml @@ -82,6 +82,9 @@ properties: Should be phandle/offset pair. The phandle to the syscon node which encompases the glue register, and the offset of the control register + phy-supply: + description: PHY regulator + st,eth-clk-sel: description: set this property in RGMII PHY when you want to select RCC clock instead of ETH_CLK125.