mbox series

[iproute2-next,v2,0/2] bridge: vlan: add compressvlans manpage

Message ID MAZP287MB05039AA2ECF8022DD501D4BCE4312@MAZP287MB0503.INDP287.PROD.OUTLOOK.COM (mailing list archive)
Headers show
Series bridge: vlan: add compressvlans manpage | expand

Message

Date Huang March 22, 2024, 12:39 p.m. UTC
Hi maintainers

I followed Nikolay and Jiri's comment and updated the patch to v2.
Please check it.

Date Huang (2):
  bridge: vlan: fix compressvlans usage
  bridge: vlan: add compressvlans manpage

 bridge/bridge.c   | 2 +-
 man/man8/bridge.8 | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

Comments

Nikolay Aleksandrov March 22, 2024, 12:58 p.m. UTC | #1
On 3/22/24 14:39, Date Huang wrote:
> Hi maintainers
> 
> I followed Nikolay and Jiri's comment and updated the patch to v2.
> Please check it.
> 

Your cover letter should contain an overview of what the set is doing.

> Date Huang (2):
>    bridge: vlan: fix compressvlans usage
>    bridge: vlan: add compressvlans manpage
> 
>   bridge/bridge.c   | 2 +-
>   man/man8/bridge.8 | 6 ++++++
>   2 files changed, 7 insertions(+), 1 deletion(-)
> 

Generally it is good to give people time to review and wait at least
24 hours before reposting another version. Also please write the
changes between versions, something like:

v3: ...
v2: split the patch into two separate patches
     changed the option in patch 01
     changed the man page description in patch 02

Keep the history from previous postings. Also you can note what changed
in each individual patch for the version under the first ---, for 
example for patch 02:
---
v2: changed the man page description

Cheers,
  Nik
patchwork-bot+netdevbpf@kernel.org March 26, 2024, 5:20 p.m. UTC | #2
Hello:

This series was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:

On Fri, 22 Mar 2024 20:39:21 +0800 you wrote:
> Hi maintainers
> 
> I followed Nikolay and Jiri's comment and updated the patch to v2.
> Please check it.
> 
> Date Huang (2):
>   bridge: vlan: fix compressvlans usage
>   bridge: vlan: add compressvlans manpage
> 
> [...]

Here is the summary with links:
  - [iproute2-next,v2,1/2] bridge: vlan: fix compressvlans usage
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=43b53968634e
  - [iproute2-next,v2,2/2] bridge: vlan: fix compressvlans usage
    https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=9ccf8fa8d4d7

You are awesome, thank you!