diff mbox series

block: Make blk_rq_set_mixed_merge() static

Message ID 20240325083501.2816408-1-john.g.garry@oracle.com (mailing list archive)
State New, archived
Headers show
Series block: Make blk_rq_set_mixed_merge() static | expand

Commit Message

John Garry March 25, 2024, 8:35 a.m. UTC
Since commit 8e756373d7c8 ("block: Move bio merge related functions into
blk-merge.c"), blk_rq_set_mixed_merge() has only been referenced in
blk-merge.c, so make it static.

Signed-off-by: John Garry <john.g.garry@oracle.com>

Comments

Christoph Hellwig March 26, 2024, 7:01 a.m. UTC | #1
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Jens Axboe March 26, 2024, 5:28 p.m. UTC | #2
On Mon, 25 Mar 2024 08:35:01 +0000, John Garry wrote:
> Since commit 8e756373d7c8 ("block: Move bio merge related functions into
> blk-merge.c"), blk_rq_set_mixed_merge() has only been referenced in
> blk-merge.c, so make it static.
> 
> 

Applied, thanks!

[1/1] block: Make blk_rq_set_mixed_merge() static
      commit: dc53d9eac1db76fd27b1fcee1f64c840cf82b468

Best regards,
diff mbox series

Patch

diff --git a/block/blk-merge.c b/block/blk-merge.c
index 2a06fd33039d..4e3483a16b75 100644
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -726,7 +726,7 @@  static int ll_merge_requests_fn(struct request_queue *q, struct request *req,
  *     which can be mixed are set in each bio and mark @rq as mixed
  *     merged.
  */
-void blk_rq_set_mixed_merge(struct request *rq)
+static void blk_rq_set_mixed_merge(struct request *rq)
 {
 	blk_opf_t ff = rq->cmd_flags & REQ_FAILFAST_MASK;
 	struct bio *bio;
diff --git a/block/blk.h b/block/blk.h
index 5cac4e29ae17..d9f584984bc4 100644
--- a/block/blk.h
+++ b/block/blk.h
@@ -339,7 +339,6 @@  int ll_back_merge_fn(struct request *req, struct bio *bio,
 bool blk_attempt_req_merge(struct request_queue *q, struct request *rq,
 				struct request *next);
 unsigned int blk_recalc_rq_segments(struct request *rq);
-void blk_rq_set_mixed_merge(struct request *rq);
 bool blk_rq_merge_ok(struct request *rq, struct bio *bio);
 enum elv_merge blk_try_merge(struct request *rq, struct bio *bio);