| Message ID | 20240327-module-owner-virtio-v1-2-0feffab77d99@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | virtio: store owner from modules with register_virtio_driver() | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | fail | "Bluetooth: " prefix is not specified in the subject |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
On Wed, 2024-03-27 at 13:40 +0100, Krzysztof Kozlowski wrote: > virtio core already sets the .owner, so driver does not need to. > All further patches depend on the first virtio patch, therefore please ack > and this should go via one tree: virtio? Sure. Though it's not really actually necessary, you can set it in the core and merge the other patches in the next cycle; those drivers that _have_ an .owner aren't broken after all. Acked-by: Johannes Berg <johannes@sipsolutions.net> johannes
On 27/03/2024 14:34, Johannes Berg wrote: > On Wed, 2024-03-27 at 13:40 +0100, Krzysztof Kozlowski wrote: >> virtio core already sets the .owner, so driver does not need to. > >> All further patches depend on the first virtio patch, therefore please ack >> and this should go via one tree: virtio? > > Sure. Though it's not really actually necessary, you can set it in the > core and merge the other patches in the next cycle; those drivers that > _have_ an .owner aren't broken after all. > > Acked-by: Johannes Berg <johannes@sipsolutions.net> True, this can be spread over two cycles. What I wanted to express, is that maintainers should not pick individual patches. Thanks for the Ack and apologies for a bit too big CC-list. I need to learn how to ask b4 to make Cc-per-patch for such case. Best regards, Krzysztof
diff --git a/arch/um/drivers/virt-pci.c b/arch/um/drivers/virt-pci.c index 97a37c062997..7cb503469bbd 100644 --- a/arch/um/drivers/virt-pci.c +++ b/arch/um/drivers/virt-pci.c @@ -752,7 +752,6 @@ MODULE_DEVICE_TABLE(virtio, id_table); static struct virtio_driver um_pci_virtio_driver = { .driver.name = "virtio-pci", - .driver.owner = THIS_MODULE, .id_table = id_table, .probe = um_pci_virtio_probe, .remove = um_pci_virtio_remove,
virtio core already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Depends on the first patch. --- arch/um/drivers/virt-pci.c | 1 - 1 file changed, 1 deletion(-)