| Message ID | 20240329-loongson1-dma-v7-1-37db58608de5@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for Loongson1 APB DMA | expand |
On Fri, Mar 29, 2024 at 07:26:57PM +0800, Keguang Zhang via B4 Relay wrote: > From: Keguang Zhang <keguang.zhang@gmail.com> > > Add devicetree binding document for Loongson-1 APB DMA. > > Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com> > --- > Changes in v7: > - Change the comptible to 'loongson,ls1*-apbdma' (suggested by Huacai Chen) > - Update the title and description part accordingly > - Rename the file to loongson,ls1b-apbdma.yaml > - Add a compatible string for LS1A > - Delete minItems of 'interrupts' > - Change patterns of 'interrupt-names' to const > > Changes in v6: > - Change the compatible to the fallback > - Some minor fixes > > Changes in v5: > - A newly added patch > --- > .../bindings/dma/loongson,ls1b-apbdma.yaml | 65 ++++++++++++++++++++++ > 1 file changed, 65 insertions(+) > > diff --git a/Documentation/devicetree/bindings/dma/loongson,ls1b-apbdma.yaml b/Documentation/devicetree/bindings/dma/loongson,ls1b-apbdma.yaml > new file mode 100644 > index 000000000000..449da9fc2de1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/dma/loongson,ls1b-apbdma.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/dma/loongson,ls1b-apbdma.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Loongson-1 APB DMA Controller > + > +maintainers: > + - Keguang Zhang <keguang.zhang@gmail.com> > + > +description: > + Loongson-1 APB DMA controller provides 3 independent channels for > + peripherals such as NAND, audio playback and capture. > + > +properties: > + compatible: > + oneOf: > + - const: loongson,ls1b-apbdma > + - items: > + - enum: > + - loongson,ls1a-apbdma > + - loongson,ls1c-apbdma > + - const: loongson,ls1b-apbdma > + > + reg: > + maxItems: 1 > + > + interrupts: > + description: Each channel has a dedicated interrupt line. If there's a respin, make this an items list. If you do, you can then drop the maxItems and description. Ideally with that change made, Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor.
diff --git a/Documentation/devicetree/bindings/dma/loongson,ls1b-apbdma.yaml b/Documentation/devicetree/bindings/dma/loongson,ls1b-apbdma.yaml new file mode 100644 index 000000000000..449da9fc2de1 --- /dev/null +++ b/Documentation/devicetree/bindings/dma/loongson,ls1b-apbdma.yaml @@ -0,0 +1,65 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/dma/loongson,ls1b-apbdma.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Loongson-1 APB DMA Controller + +maintainers: + - Keguang Zhang <keguang.zhang@gmail.com> + +description: + Loongson-1 APB DMA controller provides 3 independent channels for + peripherals such as NAND, audio playback and capture. + +properties: + compatible: + oneOf: + - const: loongson,ls1b-apbdma + - items: + - enum: + - loongson,ls1a-apbdma + - loongson,ls1c-apbdma + - const: loongson,ls1b-apbdma + + reg: + maxItems: 1 + + interrupts: + description: Each channel has a dedicated interrupt line. + maxItems: 3 + + interrupt-names: + items: + - const: ch0 + - const: ch1 + - const: ch2 + + '#dma-cells': + const: 1 + +required: + - compatible + - reg + - interrupts + - interrupt-names + - '#dma-cells' + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + dma-controller@1fd01160 { + compatible = "loongson,ls1b-apbdma"; + reg = <0x1fd01160 0x4>; + + interrupt-parent = <&intc0>; + interrupts = <13 IRQ_TYPE_EDGE_RISING>, + <14 IRQ_TYPE_EDGE_RISING>, + <15 IRQ_TYPE_EDGE_RISING>; + interrupt-names = "ch0", "ch1", "ch2"; + + #dma-cells = <1>; + };