| Message ID | 20240329075630.2069474-18-tzungbi@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fc87ba8e4525a10a8307fd50a1277dc5f7487972 |
| Headers | show |
| Series | platform/chrome: provide ID table for avoiding fallback match | expand |
On 29/03/2024 08:56, Tzung-Bi Shih wrote: > There is no platform driver in the file. Remove the redundant > MODULE_ALIAS(). > > Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org> > --- > drivers/platform/chrome/wilco_ec/event.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/platform/chrome/wilco_ec/event.c b/drivers/platform/chrome/wilco_ec/event.c > index 13291fb4214e..49043c644572 100644 > --- a/drivers/platform/chrome/wilco_ec/event.c > +++ b/drivers/platform/chrome/wilco_ec/event.c > @@ -575,4 +575,3 @@ module_exit(event_module_exit); > MODULE_AUTHOR("Nick Crews <ncrews@chromium.org>"); > MODULE_DESCRIPTION("Wilco EC ACPI event driver"); > MODULE_LICENSE("GPL"); > -MODULE_ALIAS("platform:" DRV_NAME); In this case some sort of alias, maybe not necessarily platform, could have sense. I see there ACPI ID table, so it is fine for me. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, Mar 29, 2024 at 03:56:29PM +0800, Tzung-Bi Shih wrote: > There is no platform driver in the file. Remove the redundant > MODULE_ALIAS(). > > Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org> Reviewed-by: Benson Leung <bleung@chromium.org> > --- > drivers/platform/chrome/wilco_ec/event.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/platform/chrome/wilco_ec/event.c b/drivers/platform/chrome/wilco_ec/event.c > index 13291fb4214e..49043c644572 100644 > --- a/drivers/platform/chrome/wilco_ec/event.c > +++ b/drivers/platform/chrome/wilco_ec/event.c > @@ -575,4 +575,3 @@ module_exit(event_module_exit); > MODULE_AUTHOR("Nick Crews <ncrews@chromium.org>"); > MODULE_DESCRIPTION("Wilco EC ACPI event driver"); > MODULE_LICENSE("GPL"); > -MODULE_ALIAS("platform:" DRV_NAME); > -- > 2.44.0.478.gd926399ef9-goog > >
diff --git a/drivers/platform/chrome/wilco_ec/event.c b/drivers/platform/chrome/wilco_ec/event.c index 13291fb4214e..49043c644572 100644 --- a/drivers/platform/chrome/wilco_ec/event.c +++ b/drivers/platform/chrome/wilco_ec/event.c @@ -575,4 +575,3 @@ module_exit(event_module_exit); MODULE_AUTHOR("Nick Crews <ncrews@chromium.org>"); MODULE_DESCRIPTION("Wilco EC ACPI event driver"); MODULE_LICENSE("GPL"); -MODULE_ALIAS("platform:" DRV_NAME);
There is no platform driver in the file. Remove the redundant MODULE_ALIAS(). Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org> --- drivers/platform/chrome/wilco_ec/event.c | 1 - 1 file changed, 1 deletion(-)