| Message ID | 20240324-imx95-blk-ctl-v5-0-7a706174078a@nxp.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add support i.MX95 BLK CTL module clock features | expand |
On 24/03/2024 08:51, Peng Fan (OSS) wrote: > i.MX95's several MIXes has BLK CTL module which could be used for > clk settings, QoS settings, Misc settings for a MIX. This patchset > is to add the clk feature support, including dt-bindings > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > Changes in v5: > - Merge bindings except the one has mux-controller > - Separate clock ID headers in a separate patch per Rob's comments Where did he suggest it? Best regards, Krzysztof
> Subject: Re: [PATCH v5 0/4] Add support i.MX95 BLK CTL module clock > features > > On 24/03/2024 08:51, Peng Fan (OSS) wrote: > > i.MX95's several MIXes has BLK CTL module which could be used for clk > > settings, QoS settings, Misc settings for a MIX. This patchset is to > > add the clk feature support, including dt-bindings > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > Changes in v5: > > - Merge bindings except the one has mux-controller > > - Separate clock ID headers in a separate patch per Rob's comments > > Where did he suggest it? See https://lore.kernel.org/all/20240315165422.GA1472059-robh@kernel.org/ Thanks, Peng. > > > > Best regards, > Krzysztof
On 31/03/2024 14:00, Peng Fan wrote: >> Subject: Re: [PATCH v5 0/4] Add support i.MX95 BLK CTL module clock >> features >> >> On 24/03/2024 08:51, Peng Fan (OSS) wrote: >>> i.MX95's several MIXes has BLK CTL module which could be used for clk >>> settings, QoS settings, Misc settings for a MIX. This patchset is to >>> add the clk feature support, including dt-bindings >>> >>> Signed-off-by: Peng Fan <peng.fan@nxp.com> >>> --- >>> Changes in v5: >>> - Merge bindings except the one has mux-controller >>> - Separate clock ID headers in a separate patch per Rob's comments >> >> Where did he suggest it? > > See https://lore.kernel.org/all/20240315165422.GA1472059-robh@kernel.org/ > He said under specific line about one specific define. There is absolutely nothing about splitting the header into new patch. NAK Best regards, Krzysztof
> Subject: Re: [PATCH v5 0/4] Add support i.MX95 BLK CTL module clock > features > > On 31/03/2024 14:00, Peng Fan wrote: > >> Subject: Re: [PATCH v5 0/4] Add support i.MX95 BLK CTL module clock > >> features > >> > >> On 24/03/2024 08:51, Peng Fan (OSS) wrote: > >>> i.MX95's several MIXes has BLK CTL module which could be used for > >>> clk settings, QoS settings, Misc settings for a MIX. This patchset > >>> is to add the clk feature support, including dt-bindings > >>> > >>> Signed-off-by: Peng Fan <peng.fan@nxp.com> > >>> --- > >>> Changes in v5: > >>> - Merge bindings except the one has mux-controller > >>> - Separate clock ID headers in a separate patch per Rob's comments > >> > >> Where did he suggest it? > > > > See > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore > > .kernel.org%2Fall%2F20240315165422.GA1472059- > robh%40kernel.org%2F&data > > > =05%7C02%7Cpeng.fan%40nxp.com%7C95289dc4bed24c3d125808dc51bc4 > 4e0%7C686 > > > ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638475116243825697%7 > CUnknown%7 > > > CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwi > LCJXV > > > CI6Mn0%3D%7C0%7C%7C%7C&sdata=Dt6KYhWwp%2B4NSwHJlXwUjyRqYU > CkN0MvlSOE22w > > vRE0%3D&reserved=0 > > > > He said under specific line about one specific define. There is absolutely > nothing about splitting the header into new patch. I misunderstood your point, I will put the header patch(patch 2/4) as the 1st patch V6. Thanks, Peng. > > NAK > > Best regards, > Krzysztof
i.MX95's several MIXes has BLK CTL module which could be used for clk settings, QoS settings, Misc settings for a MIX. This patchset is to add the clk feature support, including dt-bindings Signed-off-by: Peng Fan <peng.fan@nxp.com> --- Changes in v5: - Merge bindings except the one has mux-controller - Separate clock ID headers in a separate patch per Rob's comments - Link to v4: https://lore.kernel.org/r/20240314-imx95-blk-ctl-v4-0-d23de23b6ff2@nxp.com Changes in v4: - Separate binding doc for each modules, I still keep the syscon as node name, because the module is not just for clock - Pass dt-schema check - Update node compatibles - Link to v3: https://lore.kernel.org/r/20240228-imx95-blk-ctl-v3-0-40ceba01a211@nxp.com Changes in v3: - Correct example node compatible string - Pass "make ARCH=arm64 DT_CHECKER_FLAGS=-m -j32 dt_binding_check" - Link to v2: https://lore.kernel.org/r/20240228-imx95-blk-ctl-v2-0-ffb7eefb6dcd@nxp.com Changes in v2: - Correct example node compatible string - Link to v1: https://lore.kernel.org/r/20240228-imx95-blk-ctl-v1-0-9b5ae3c14d83@nxp.com --- Peng Fan (4): dt-bindings: clock: support i.MX95 BLK CTL module dt-bindings: clock: support i.MX95 Display Master CSR module dt-bindings: clock: add i.MX95 clock header clk: imx: add i.MX95 BLK CTL clk driver .../bindings/clock/nxp,imx95-blk-ctl.yaml | 56 +++ .../clock/nxp,imx95-display-master-csr.yaml | 64 +++ drivers/clk/imx/Kconfig | 7 + drivers/clk/imx/Makefile | 1 + drivers/clk/imx/clk-imx95-blk-ctl.c | 438 +++++++++++++++++++++ include/dt-bindings/clock/nxp,imx95-clock.h | 32 ++ 6 files changed, 598 insertions(+) --- base-commit: c9c32620af65fee2b1ac8390fe1349b33f9d0888 change-id: 20240228-imx95-blk-ctl-9ef8c1fc4c22 Best regards,