| Message ID | 20240329-misc-rhashtable-v1-1-5862383ff798@gmx.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8db2509faa331865903a81a92f15c449e821b1d7 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | rhashtable: Improve grammar | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On 3/29/24 09:26, Jonathan Neuschäfer via B4 Relay wrote: > From: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > > Change "a" to "an" according to the usual rules, fix an "if" that was > mistyped as "in", improve grammar in "considerable slow" -> > "considerably slower". > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> Reviewed-by: Randy Dunlap <rdunlap@infradead.org> Thanks. > --- > include/linux/rhashtable.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/linux/rhashtable.h b/include/linux/rhashtable.h > index 5b5357c0bd8c4..8463a128e2f48 100644 > --- a/include/linux/rhashtable.h > +++ b/include/linux/rhashtable.h > @@ -633,7 +633,7 @@ static inline struct rhash_head *__rhashtable_lookup( > * @params: hash table parameters > * > * Computes the hash value for the key and traverses the bucket chain looking > - * for a entry with an identical key. The first matching entry is returned. > + * for an entry with an identical key. The first matching entry is returned. > * > * This must only be called under the RCU read lock. > * > @@ -655,7 +655,7 @@ static inline void *rhashtable_lookup( > * @params: hash table parameters > * > * Computes the hash value for the key and traverses the bucket chain looking > - * for a entry with an identical key. The first matching entry is returned. > + * for an entry with an identical key. The first matching entry is returned. > * > * Only use this function when you have other mechanisms guaranteeing > * that the object won't go away after the RCU read lock is released. > @@ -682,7 +682,7 @@ static inline void *rhashtable_lookup_fast( > * @params: hash table parameters > * > * Computes the hash value for the key and traverses the bucket chain looking > - * for a entry with an identical key. All matching entries are returned > + * for an entry with an identical key. All matching entries are returned > * in a list. > * > * This must only be called under the RCU read lock. > @@ -699,7 +699,7 @@ static inline struct rhlist_head *rhltable_lookup( > } > > /* Internal function, please use rhashtable_insert_fast() instead. This > - * function returns the existing element already in hashes in there is a clash, > + * function returns the existing element already in hashes if there is a clash, > * otherwise it returns an error via ERR_PTR(). > */ > static inline void *__rhashtable_insert_fast( > @@ -1130,7 +1130,7 @@ static inline int rhashtable_remove_fast( > * > * Since the hash chain is single linked, the removal operation needs to > * walk the bucket chain upon removal. The removal operation is thus > - * considerable slow if the hash table is not correctly sized. > + * considerably slower if the hash table is not correctly sized. > * > * Will automatically shrink the table if permitted when residency drops > * below 30% > > --- > base-commit: 4cece764965020c22cff7665b18a012006359095 > change-id: 20240329-misc-rhashtable-d7578e8f2ed5 > > Best regards,
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 29 Mar 2024 17:26:27 +0100 you wrote: > From: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > > Change "a" to "an" according to the usual rules, fix an "if" that was > mistyped as "in", improve grammar in "considerable slow" -> > "considerably slower". > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net> > > [...] Here is the summary with links: - rhashtable: Improve grammar https://git.kernel.org/netdev/net-next/c/8db2509faa33 You are awesome, thank you!
diff --git a/include/linux/rhashtable.h b/include/linux/rhashtable.h index 5b5357c0bd8c4..8463a128e2f48 100644 --- a/include/linux/rhashtable.h +++ b/include/linux/rhashtable.h @@ -633,7 +633,7 @@ static inline struct rhash_head *__rhashtable_lookup( * @params: hash table parameters * * Computes the hash value for the key and traverses the bucket chain looking - * for a entry with an identical key. The first matching entry is returned. + * for an entry with an identical key. The first matching entry is returned. * * This must only be called under the RCU read lock. * @@ -655,7 +655,7 @@ static inline void *rhashtable_lookup( * @params: hash table parameters * * Computes the hash value for the key and traverses the bucket chain looking - * for a entry with an identical key. The first matching entry is returned. + * for an entry with an identical key. The first matching entry is returned. * * Only use this function when you have other mechanisms guaranteeing * that the object won't go away after the RCU read lock is released. @@ -682,7 +682,7 @@ static inline void *rhashtable_lookup_fast( * @params: hash table parameters * * Computes the hash value for the key and traverses the bucket chain looking - * for a entry with an identical key. All matching entries are returned + * for an entry with an identical key. All matching entries are returned * in a list. * * This must only be called under the RCU read lock. @@ -699,7 +699,7 @@ static inline struct rhlist_head *rhltable_lookup( } /* Internal function, please use rhashtable_insert_fast() instead. This - * function returns the existing element already in hashes in there is a clash, + * function returns the existing element already in hashes if there is a clash, * otherwise it returns an error via ERR_PTR(). */ static inline void *__rhashtable_insert_fast( @@ -1130,7 +1130,7 @@ static inline int rhashtable_remove_fast( * * Since the hash chain is single linked, the removal operation needs to * walk the bucket chain upon removal. The removal operation is thus - * considerable slow if the hash table is not correctly sized. + * considerably slower if the hash table is not correctly sized. * * Will automatically shrink the table if permitted when residency drops * below 30%