| Message ID | d753e684-43ee-45c2-a1fd-86222da204e1@moroto.mountain (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/panthor: Fix error code in panthor_gpu_init() | expand |
On Tue, 2 Apr 2024 12:56:19 +0300 Dan Carpenter <dan.carpenter@linaro.org> wrote: > This code accidentally returns zero/success on error because of a typo. > It should be "irq" instead of "ret". The other thing is that if > platform_get_irq_byname() were to return zero then the error code would > be cmplicated. Fortunately, it does not so we can just change <= to > < 0. > > Fixes: 5cd894e258c4 ("drm/panthor: Add the GPU logical block") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> > --- > drivers/gpu/drm/panthor/panthor_gpu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_gpu.c b/drivers/gpu/drm/panthor/panthor_gpu.c > index 0f7c962440d3..5251d8764e7d 100644 > --- a/drivers/gpu/drm/panthor/panthor_gpu.c > +++ b/drivers/gpu/drm/panthor/panthor_gpu.c > @@ -211,8 +211,8 @@ int panthor_gpu_init(struct panthor_device *ptdev) > return ret; > > irq = platform_get_irq_byname(to_platform_device(ptdev->base.dev), "gpu"); > - if (irq <= 0) > - return ret; > + if (irq < 0) > + return irq; > > ret = panthor_request_gpu_irq(ptdev, &ptdev->gpu->irq, irq, GPU_INTERRUPTS_MASK); > if (ret)
On Tue, 2 Apr 2024 12:56:19 +0300 Dan Carpenter <dan.carpenter@linaro.org> wrote: > This code accidentally returns zero/success on error because of a typo. > It should be "irq" instead of "ret". The other thing is that if > platform_get_irq_byname() were to return zero then the error code would > be cmplicated. Fortunately, it does not so we can just change <= to > < 0. > > Fixes: 5cd894e258c4 ("drm/panthor: Add the GPU logical block") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Queued to drm-misc-next. Thanks, Boris > --- > drivers/gpu/drm/panthor/panthor_gpu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_gpu.c b/drivers/gpu/drm/panthor/panthor_gpu.c > index 0f7c962440d3..5251d8764e7d 100644 > --- a/drivers/gpu/drm/panthor/panthor_gpu.c > +++ b/drivers/gpu/drm/panthor/panthor_gpu.c > @@ -211,8 +211,8 @@ int panthor_gpu_init(struct panthor_device *ptdev) > return ret; > > irq = platform_get_irq_byname(to_platform_device(ptdev->base.dev), "gpu"); > - if (irq <= 0) > - return ret; > + if (irq < 0) > + return irq; > > ret = panthor_request_gpu_irq(ptdev, &ptdev->gpu->irq, irq, GPU_INTERRUPTS_MASK); > if (ret)
diff --git a/drivers/gpu/drm/panthor/panthor_gpu.c b/drivers/gpu/drm/panthor/panthor_gpu.c index 0f7c962440d3..5251d8764e7d 100644 --- a/drivers/gpu/drm/panthor/panthor_gpu.c +++ b/drivers/gpu/drm/panthor/panthor_gpu.c @@ -211,8 +211,8 @@ int panthor_gpu_init(struct panthor_device *ptdev) return ret; irq = platform_get_irq_byname(to_platform_device(ptdev->base.dev), "gpu"); - if (irq <= 0) - return ret; + if (irq < 0) + return irq; ret = panthor_request_gpu_irq(ptdev, &ptdev->gpu->irq, irq, GPU_INTERRUPTS_MASK); if (ret)
This code accidentally returns zero/success on error because of a typo. It should be "irq" instead of "ret". The other thing is that if platform_get_irq_byname() were to return zero then the error code would be cmplicated. Fortunately, it does not so we can just change <= to < 0. Fixes: 5cd894e258c4 ("drm/panthor: Add the GPU logical block") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/gpu/drm/panthor/panthor_gpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)