| Message ID | 20240329-module-owner-sdio-v1-6-e4010b11ccaa@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | mmc/wifi/bluetooth: store owner from modules with sdio_register_driver() | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | fail | "Bluetooth: " prefix is not specified in the subject |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
On Fri, Mar 29, 2024 at 06:24:36PM +0100, Krzysztof Kozlowski wrote: > Core in sdio_register_driver() already sets the .owner, so driver does > not need to. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes: > Core in sdio_register_driver() already sets the .owner, so driver does > not need to. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> The preferred title format is: wifi: mwifiex: drop driver owner initialization But that's just cosmetics. Feel free to take this via sdio tree: Acked-by: Kalle Valo <kvalo@kernel.org>
diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c index e1b58ca1b3ba..588140453821 100644 --- a/drivers/net/wireless/marvell/mwifiex/sdio.c +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c @@ -979,7 +979,6 @@ static struct sdio_driver mwifiex_sdio = { .probe = mwifiex_sdio_probe, .remove = mwifiex_sdio_remove, .drv = { - .owner = THIS_MODULE, .coredump = mwifiex_sdio_coredump, .pm = &mwifiex_sdio_pm_ops, }
Core in sdio_register_driver() already sets the .owner, so driver does not need to. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Depends on the first patch. --- drivers/net/wireless/marvell/mwifiex/sdio.c | 1 - 1 file changed, 1 deletion(-)