mbox series

[v4,iwl-next,00/12] Introduce ETH56G PHY model for E825C products

Message ID 20240329161730.47777-14-karol.kolacinski@intel.com (mailing list archive)
Headers show
Series Introduce ETH56G PHY model for E825C products | expand

Message

Karol Kolacinski March 29, 2024, 4:09 p.m. UTC
E825C products have a different PHY model than E822, E823 and E810 products.
This PHY is ETH56G and its support is necessary to have functional PTP stack
for E825C products.

Grzegorz Nitka (2):
  ice: Add NAC Topology device capability parser
  ice: Adjust PTP init for 2x50G E825C devices

Jacob Keller (2):
  ice: Introduce helper to get tmr_cmd_reg values
  ice: Introduce ice_get_base_incval() helper

Karol Kolacinski (4):
  ice: Introduce ice_ptp_hw struct
  ice: Add PHY OFFSET_READY register clearing
  ice: Change CGU regs struct to anonymous
  ice: Support 2XNAC configuration using auxbus

Michal Michalik (1):
  ice: Add support for E825-C TS PLL handling

Sergey Temerkhanov (3):
  ice: Implement Tx interrupt enablement functions
  ice: Move CGU block
  ice: Introduce ETH56G PHY model for E825C products

 drivers/net/ethernet/intel/ice/ice.h          |   23 +-
 .../net/ethernet/intel/ice/ice_adminq_cmd.h   |    1 +
 drivers/net/ethernet/intel/ice/ice_cgu_regs.h |   77 +-
 drivers/net/ethernet/intel/ice/ice_common.c   |   58 +-
 drivers/net/ethernet/intel/ice/ice_common.h   |    2 +
 .../net/ethernet/intel/ice/ice_hw_autogen.h   |    4 +
 drivers/net/ethernet/intel/ice/ice_ptp.c      |  263 +-
 drivers/net/ethernet/intel/ice/ice_ptp.h      |    1 +
 .../net/ethernet/intel/ice/ice_ptp_consts.h   |  402 ++
 drivers/net/ethernet/intel/ice/ice_ptp_hw.c   | 3659 +++++++++++++----
 drivers/net/ethernet/intel/ice/ice_ptp_hw.h   |  286 +-
 drivers/net/ethernet/intel/ice/ice_sbq_cmd.h  |   10 +-
 drivers/net/ethernet/intel/ice/ice_type.h     |   60 +-
 13 files changed, 3912 insertions(+), 934 deletions(-)


base-commit: ab4851b5e85f6c55f3d6ebd18134d43746b1f7ce

Comments

Tony Nguyen March 29, 2024, 4:23 p.m. UTC | #1
On 3/29/2024 9:09 AM, Karol Kolacinski wrote:
> E825C products have a different PHY model than E822, E823 and E810 products.
> This PHY is ETH56G and its support is necessary to have functional PTP stack
> for E825C products.

It hasn't been 24 hours since the v3 [1]; for larger changes, you should 
wait longer than that [2].

Also, where's the changelog?

Thanks,
Tony

[1] 
https://docs.kernel.org/process/maintainer-netdev.html#resending-after-review

[2] 
https://lore.kernel.org/intel-wired-lan/20240327075015.7c13a71b@kernel.org/
Karol Kolacinski April 2, 2024, 12:31 p.m. UTC | #2
Hi Anthony,

On 3/29/2024 9:23 AM, Anthony L Nguyen wrote:
> It hasn't been 24 hours since the v3 [1]; for larger changes, you should
> wait longer than that [2].

I'm really sorry, I forgot about 24h rule.


> Also, where's the changelog?

The only thing that changed between V1 and V4 was patch 07/12, which had
only minor changes and it has the changelog.
Should I also include which patches were changed in the cover letter?

Thanks,
Karol
Tony Nguyen April 3, 2024, 11:24 p.m. UTC | #3
On 4/2/2024 5:31 AM, Kolacinski, Karol wrote:
> 
> The only thing that changed between V1 and V4 was patch 07/12, which had
> only minor changes and it has the changelog.
> Should I also include which patches were changed in the cover letter?

Yes, please. It's nice to be able to see what changed without having to 
look for a changelog in each patch.

Thanks,
Tony

> Thanks,
> Karol