[v1,1/2] dt-bindings: net: bluetooth: btnxpuart: Add firmware-name property

Commit Message

Neeraj Sanjay Kale April 5, 2024, 9:01 a.m. UTC

This adds a new optional device tree property called firware-name.
If this property is specified, the driver overrides the firmware
name hardcoded in the driver source code.

Signed-off-by: Neeraj Sanjay Kale <[e-mail]>
---
 .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

[e-mail] April 5, 2024, 9:32 a.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=841719

---Test result---

Test Summary:
CheckPatch                    PASS      1.32 seconds
GitLint                       PASS      0.66 seconds
SubjectPrefix                 FAIL      0.44 seconds
BuildKernel                   PASS      32.47 seconds
CheckAllWarning               PASS      32.98 seconds
CheckSparse                   PASS      38.54 seconds
CheckSmatch                   FAIL      35.09 seconds
BuildKernel32                 PASS      29.36 seconds
TestRunnerSetup               PASS      529.51 seconds
TestRunner_l2cap-tester       PASS      18.48 seconds
TestRunner_iso-tester         FAIL      30.79 seconds
TestRunner_bnep-tester        PASS      4.69 seconds
TestRunner_mgmt-tester        PASS      115.71 seconds
TestRunner_rfcomm-tester      PASS      7.26 seconds
TestRunner_sco-tester         PASS      14.94 seconds
TestRunner_ioctl-tester       PASS      7.66 seconds
TestRunner_mesh-tester        PASS      5.86 seconds
TestRunner_smp-tester         PASS      6.75 seconds
TestRunner_userchan-tester    PASS      4.94 seconds
IncrementalBuild              PASS      32.86 seconds

Details
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:

Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: net] Error 2
make[2]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 121, Passed: 120 (99.2%), Failed: 1, Not Run: 0

Failed Test Cases
ISO Connect2 Suspend - Success                       Failed       4.223 seconds


---
Regards,
Linux Bluetooth

Krzysztof Kozlowski April 5, 2024, 9:39 a.m. UTC | #2

On 05/04/2024 11:01, Neeraj Sanjay Kale wrote:
> This adds a new optional device tree property called firware-name.
> If this property is specified, the driver overrides the firmware
> name hardcoded in the driver source code.
> 
> Signed-off-by: Neeraj Sanjay Kale <[e-mail]>
> ---
>  .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> index f01a3988538c..25c258212bcd 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> @@ -31,6 +31,13 @@ properties:
>        This property depends on the module vendor's
>        configuration.
>  
> +  firmware-name:
> +    $ref: /schemas/types.yaml#/definitions/string

drop, missing maxItems. Look at recent code.

> +    description:
> +      Specify firmware file name, prepended with nxp/.

Why with nxp? What if firmware is stored somewhere else?


> +      This property overrides the firmware names hardcoded
> +      in the driver source code.

Drop, you now describe current OS policy. What if U-boot treats it
differently?

Best regards,
Krzysztof

Patch

diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
index f01a3988538c..25c258212bcd 100644
--- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
+++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
@@ -31,6 +31,13 @@  properties:
       This property depends on the module vendor's
       configuration.
 
+  firmware-name:
+    $ref: /schemas/types.yaml#/definitions/string
+    description:
+      Specify firmware file name, prepended with nxp/.
+      This property overrides the firmware names hardcoded
+      in the driver source code.
+
 required:
   - compatible
 
@@ -42,5 +49,6 @@  examples:
         bluetooth {
             compatible = "nxp,88w8987-bt";
             fw-init-baudrate = <3000000>;
+            firmware-name = "nxp/uartuart8987_bt_v0.bin";
         };
     };