diff mbox series

[1/6] dt-bindings: net: snps,dwmac: remove tx-sched-sp property

Message ID 20240405152800.638461-2-f.suligoi@asem.it (mailing list archive)
State Superseded
Headers show
Series Remove stmmac tx-sched-sp property from documentation and DT | expand

Commit Message

Flavio Suligoi April 5, 2024, 3:27 p.m. UTC
The property "tx-sched-sp" no longer exists, as it was removed from the
file:

drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c

by the commit:

commit aed6864035b1 ("net: stmmac: platform: Delete a redundant condition
branch")

Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
---
 .../devicetree/bindings/net/snps,dwmac.yaml        | 14 --------------
 1 file changed, 14 deletions(-)

Comments

Krzysztof Kozlowski April 5, 2024, 3:49 p.m. UTC | #1
On 05/04/2024 17:27, Flavio Suligoi wrote:
> The property "tx-sched-sp" no longer exists, as it was removed from the
> file:
> 
> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> 
> by the commit:

Keep syntax as asked by submitting patches, so "by the commit sha ("foo
bar").

> 
> commit aed6864035b1 ("net: stmmac: platform: Delete a redundant condition
> branch")
> 
> Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
> ---
>  .../devicetree/bindings/net/snps,dwmac.yaml        | 14 --------------
>  1 file changed, 14 deletions(-)

This means by default we have tx-sched-sp... I guess it is fine,
assuming there are no other users (projects) of this binding property.

Acked-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof
Krzysztof Kozlowski April 5, 2024, 3:50 p.m. UTC | #2
On 05/04/2024 17:27, Flavio Suligoi wrote:
> The property "tx-sched-sp" no longer exists, as it was removed from the
> file:
> 
> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> 
> by the commit:
> 
> commit aed6864035b1 ("net: stmmac: platform: Delete a redundant condition
> branch")
> 
> Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
> ---
>  .../devicetree/bindings/net/snps,dwmac.yaml        | 14 --------------
>  1 file changed, 14 deletions(-)

One more thought though:
1. Missing net-next patch annotation,
2. Please split DTS from net. DTS goes via separate trees.

Best regards,
Krzysztof
Flavio Suligoi April 10, 2024, 2:46 p.m. UTC | #3
Hi Krzysztof,

...

> On 05/04/2024 17:27, Flavio Suligoi wrote:
> > The property "tx-sched-sp" no longer exists, as it was removed from
> the
> > file:
> >
> > drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> >
> > by the commit:
> >
> > commit aed6864035b1 ("net: stmmac: platform: Delete a redundant
> condition
> > branch")
> >
> > Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
> > ---
> >  .../devicetree/bindings/net/snps,dwmac.yaml        | 14 -------------
> -
> >  1 file changed, 14 deletions(-)
> 
> One more thought though:
> 1. Missing net-next patch annotation,
> 2. Please split DTS from net. DTS goes via separate trees.

Thanks for all your suggestions.
I'll resend the patches, with your suggested changes and
splitting the DTS-related patches in a separate series.

> 
> Best regards,
> Krzysztof

Best regards,
Flavio
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 15073627c53a..21cc27e75f50 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -328,9 +328,6 @@  properties:
       snps,tx-sched-dwrr:
         type: boolean
         description: Deficit Weighted Round Robin
-      snps,tx-sched-sp:
-        type: boolean
-        description: Strict priority
     allOf:
       - if:
           required:
@@ -339,7 +336,6 @@  properties:
           properties:
             snps,tx-sched-wfq: false
             snps,tx-sched-dwrr: false
-            snps,tx-sched-sp: false
       - if:
           required:
             - snps,tx-sched-wfq
@@ -347,7 +343,6 @@  properties:
           properties:
             snps,tx-sched-wrr: false
             snps,tx-sched-dwrr: false
-            snps,tx-sched-sp: false
       - if:
           required:
             - snps,tx-sched-dwrr
@@ -355,15 +350,6 @@  properties:
           properties:
             snps,tx-sched-wrr: false
             snps,tx-sched-wfq: false
-            snps,tx-sched-sp: false
-      - if:
-          required:
-            - snps,tx-sched-sp
-        then:
-          properties:
-            snps,tx-sched-wrr: false
-            snps,tx-sched-wfq: false
-            snps,tx-sched-dwrr: false
     patternProperties:
       "^queue[0-9]$":
         description: Each subnode represents a queue.