| Message ID | 20240404123435.2684819-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | platform/x86: quickstart: fix Kconfig selects | expand |
Am 04.04.24 um 14:34 schrieb Arnd Bergmann: > From: Arnd Bergmann <arnd@arndb.de> > > The new driver Kconfig entry has a typo that causes a link failure > when CONFIG_INPUT_SPARSEKMAP is disabled: > > x86_64-linux-ld: drivers/platform/x86/quickstart.o: in function `quickstart_notify': > quickstart.c:(.text+0x96): undefined reference to `sparse_keymap_report_event' > x86_64-linux-ld: drivers/platform/x86/quickstart.o: in function `quickstart_probe': > quickstart.c:(.text+0x1da): undefined reference to `sparse_keymap_setup' > > Select this symbol instead of the incorrect INPUT_SPARSE_KEYMAP. > > Fixes: afd66f2a739e ("platform/x86: Add ACPI quickstart button (PNP0C32) driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/platform/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index ba88a7f259f1..21a37f1b73ab 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -647,7 +647,7 @@ config ACPI_QUICKSTART > tristate "ACPI Quickstart button driver" > depends on ACPI > depends on INPUT > - select INPUT_SPARSE_KEYMAP > + select INPUT_SPARSEKMAP > help > This driver adds support for ACPI quickstart button (PNP0C32) devices. > The button emits a manufacturer-specific key value when pressed, so Reviewed-by: Armin Wolf <W_Armin@gmx.de>
On 4/4/24 5:34 AM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The new driver Kconfig entry has a typo that causes a link failure > when CONFIG_INPUT_SPARSEKMAP is disabled: > > x86_64-linux-ld: drivers/platform/x86/quickstart.o: in function `quickstart_notify': > quickstart.c:(.text+0x96): undefined reference to `sparse_keymap_report_event' > x86_64-linux-ld: drivers/platform/x86/quickstart.o: in function `quickstart_probe': > quickstart.c:(.text+0x1da): undefined reference to `sparse_keymap_setup' > > Select this symbol instead of the incorrect INPUT_SPARSE_KEYMAP. > > Fixes: afd66f2a739e ("platform/x86: Add ACPI quickstart button (PNP0C32) driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- LGTM Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> > drivers/platform/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index ba88a7f259f1..21a37f1b73ab 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -647,7 +647,7 @@ config ACPI_QUICKSTART > tristate "ACPI Quickstart button driver" > depends on ACPI > depends on INPUT > - select INPUT_SPARSE_KEYMAP > + select INPUT_SPARSEKMAP > help > This driver adds support for ACPI quickstart button (PNP0C32) devices. > The button emits a manufacturer-specific key value when pressed, so
Hi, On 4/4/24 2:34 PM, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The new driver Kconfig entry has a typo that causes a link failure > when CONFIG_INPUT_SPARSEKMAP is disabled: > > x86_64-linux-ld: drivers/platform/x86/quickstart.o: in function `quickstart_notify': > quickstart.c:(.text+0x96): undefined reference to `sparse_keymap_report_event' > x86_64-linux-ld: drivers/platform/x86/quickstart.o: in function `quickstart_probe': > quickstart.c:(.text+0x1da): undefined reference to `sparse_keymap_setup' > > Select this symbol instead of the incorrect INPUT_SPARSE_KEYMAP. > > Fixes: afd66f2a739e ("platform/x86: Add ACPI quickstart button (PNP0C32) driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index ba88a7f259f1..21a37f1b73ab 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -647,7 +647,7 @@ config ACPI_QUICKSTART > tristate "ACPI Quickstart button driver" > depends on ACPI > depends on INPUT > - select INPUT_SPARSE_KEYMAP > + select INPUT_SPARSEKMAP > help > This driver adds support for ACPI quickstart button (PNP0C32) devices. > The button emits a manufacturer-specific key value when pressed, so
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index ba88a7f259f1..21a37f1b73ab 100644 --- a/drivers/platform/x86/Kconfig +++ b/drivers/platform/x86/Kconfig @@ -647,7 +647,7 @@ config ACPI_QUICKSTART tristate "ACPI Quickstart button driver" depends on ACPI depends on INPUT - select INPUT_SPARSE_KEYMAP + select INPUT_SPARSEKMAP help This driver adds support for ACPI quickstart button (PNP0C32) devices. The button emits a manufacturer-specific key value when pressed, so