Message ID | 20240406074449.563704-1-sangyun.kim@snu.ac.kr (mailing list archive) |
---|---|
State | New |
Headers | show
Return-Path: <owner-linux-mm@kvack.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1449C67861 for <linux-mm@archiver.kernel.org>; Tue, 9 Apr 2024 09:27:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A0616B00A6; Tue, 9 Apr 2024 05:27:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 350C96B00A7; Tue, 9 Apr 2024 05:27:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F1B46B00A8; Tue, 9 Apr 2024 05:27:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EF3396B00A6 for <linux-mm@kvack.org>; Tue, 9 Apr 2024 05:27:55 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B74E81A02CA for <linux-mm@kvack.org>; Tue, 9 Apr 2024 09:27:55 +0000 (UTC) X-FDA: 81989466510.20.CD666F0 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf22.hostedemail.com (Postfix) with ESMTP id 0D0A3C0009 for <linux-mm@kvack.org>; Tue, 9 Apr 2024 09:27:52 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=snu.ac.kr (policy=none); spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712654873; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: resent-to:resent-from:resent-message-id:in-reply-to:references; bh=FfM6bwCPNBuCVqt7hQupQZM7S7lz7NOtLge1I68/si4=; b=FHypEmVIOyWk/AQeadw1INfn75PT3BBSehI9snbOi8Wt3sjuyRUF3Egmo8Ji6N3KeXWqxP SBTR3K8HvdiiWPOs56VuSsDq8DeJZF35Lmt1LHbPDsOSGd4g62F61kYKuROUcQ0cEJl5nE 5mHHiSgiYLo8EAqBUFgkelBGfMQQ6bk= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=snu.ac.kr (policy=none); spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712654873; a=rsa-sha256; cv=none; b=buhD1kMD6zAWkvzWUAGjXunrJENcdjZ3RnSZ7Vg5mPV6FG634d8cMrPUhIqQ8nmDk8V07/ l7dY8u2QX9tdmFCtp1Arm1pYwpnm+5G0LgfKBH5CvaY1+YX6dM1Fphe/WW7naJVyTHkmBl 3kasXoYJVCiB44ql9LG5R3mipkw+XcY= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3065F208ED for <linux-mm@kvack.org>; Tue, 9 Apr 2024 09:27:50 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 27FE1136D9 for <linux-mm@kvack.org>; Tue, 9 Apr 2024 09:27:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id uo1wCRYKFWbsWwAAD6G6ig (envelope-from <vbabka@suse.cz>) for <linux-mm@kvack.org>; Tue, 09 Apr 2024 09:27:50 +0000 Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by imap2.dmz-prg2.suse.org with LMTPS id aLy7FZb9EGbeWwAAn2gu4w (envelope-from <sangyun.kim@snu.ac.kr>) for <vbabka>; Sat, 06 Apr 2024 07:45:26 +0000 Received: from smtp-in1.suse.de ([10.150.64.33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by dovecot-director2.suse.de with LMTPS id KGoIFZb9EGYQEgAAxW7PVg (envelope-from <sangyun.kim@snu.ac.kr>) for <vbabka@imap.suse.de>; Sat, 06 Apr 2024 07:45:26 +0000 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by smtp-in1.suse.de (Postfix) with ESMTPS id 4VBS7k4NppzZvG for <vbabka@suse.cz>; Sat, 6 Apr 2024 07:45:22 +0000 (UTC) Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1e3ca546d40so9421425ad.3 for <vbabka@suse.cz>; Sat, 06 Apr 2024 00:45:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712389520; x=1712994320; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FfM6bwCPNBuCVqt7hQupQZM7S7lz7NOtLge1I68/si4=; b=mJwOvArRiivSJWu+oM6n3rQz4I0YVnF385Sfpemev3gi+haAcm7gR2WRXfjuntZLmM S20HUqeSsysxm2FsU6jfoGIbj3XrW4WyUqq5wWd5r6ubSnHM413uraIREtdIkBa9fNYS 0Mqic2N5ELS4jq03fONLpJ7LFOvtoPiEAaZG5R8FDRSZRLXphOThzXPu52zLKJ9eDbg+ VbMiefzWJzyrJDmAB66Qz4hdTH3XPR0Mlcl3Q/nBbntcpQ0fXILd4Zlf6330x9rWnEgB zpqv5m1xDdTuMT+eWSNNhofM4w9QpW/2vGNYkyr8ihcFlYbyNttLmxwkWwjMb3o62BlO PcpA== X-Forwarded-Encrypted: i=1; AJvYcCXdhy8qkNkHeJtkI5m/peO4u5bFmHbdxuwSfOlFTvuxogW8hG/xLmgobsTHvIhbYtlgXxgZkAMDrUSHjyfQzg== X-Gm-Message-State: AOJu0Yzcy/fB4VyA2u4MtCxadYSZLUs9Vpf2je+YwgXObcylCYwW10HC RL2rEhIdjb/DLANgPfPhlgtnIzL+5alKPXZM1kwUxYYIwoFnEOuaE6abDAs/G+I= X-Google-Smtp-Source: AGHT+IF0SbuzsPcYrTB4Y6YXPcTY+8eHxJFRWS02s+dPaoex+DdT+h7M6b+lXcTfQQsXmKTLXSFiUA== X-Received: by 2002:a17:902:f813:b0:1dd:c288:899f with SMTP id ix19-20020a170902f81300b001ddc288899fmr3037152plb.18.1712389520316; Sat, 06 Apr 2024 00:45:20 -0700 (PDT) Received: from localhost.localdomain ([147.46.121.48]) by smtp.gmail.com with ESMTPSA id n8-20020a170902e54800b001e26b7a6785sm2844232plf.86.2024.04.06.00.45.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 00:45:19 -0700 (PDT) From: Sangyun Kim <sangyun.kim@snu.ac.kr> To: linux-mm@kvack.org Cc: Christoph Lameter <cl@linux.com>, Pekka Enberg <penberg@kernel.org>, David Rientjes <rientjes@google.com>, Joonsoo Kim <iamjoonsoo.kim@lge.com>, Andrew Morton <akpm@linux-foundation.org>, Vlastimil Babka <vbabka@suse.cz>, Roman Gushchin <roman.gushchin@linux.dev>, Hyeonggon Yoo <42.hyeyoo@gmail.com>, Sangyun Kim <sangyun.kim@snu.ac.kr>, Hyunmin Lee <hyunminlr@gmail.com>, Jeungwoo Yoo <casionwoo@gmail.com>, Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> Subject: [PATCH] mm/slub: remove duplicate initialization for early_kmem_cache_node_alloc() Date: Sat, 6 Apr 2024 16:44:49 +0900 Message-Id: <20240406074449.563704-1-sangyun.kim@snu.ac.kr> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Bar: +++++++ X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: karhis61xghf9esktj4g18xk389kdt1x X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0D0A3C0009 X-HE-Tag: 1712654872-856425 X-HE-Meta: U2FsdGVkX1/nPC7yLb9+OMaxTcX0KFRMIG9WBqGK6RLfK0n/52gjalGI6XrP4g6PMqNispE97g+raDVQSTdJMc1JV3X8dd2I+Edz8l7HwG2RpYK6TXZULYr7pLNNAVIC/zdO13QxSfq1Gy1lSmrsf3+l+zakfqFr2sQmDP/Q5IBIix99M+B4tjzrKCXj+LtOaGxDndXxiDw7WSf5yIhGNfQGWxJY1vRsvWcJ4IVag883A0i4ofXM7HGGa+Fq9SdIqnYb7wVp3qo+zCZ+Cja01i0xCkDIuwjc3C4CFhdstFpCnycChftip4u3MiCLVZz66pmhm1QEEgEaLwEcvISZn9DxCREVPmgllpDXR/KYBKkCK2F/1Kz7LkfroE72lFs4syqUqcEIZgZyZ8qhNEWU4m/LQhEAbfo13TkK300jwWUYISfPvOemF4j3uYN+6kzOAP5RMU64mUIK1ic4lefWmEi+JIieXMH9UpYERUriRhUusFVDzblLHjjsOtymkUMV7jJ4UM5xl+dMaLpWVq9YbbC5h6tpWooAtU2b5eL2QJzRRmiQ30SFC1aIfmmMz4caFq6ff0JC6qMXgDVQmu76/2R1BQzI3+Q23NTIvbk6Qfa9poD3qfu9DllD9loz8VKkSVGOjrbHVMA3/GSlIKTNDn+Kx9x18jHqlX5JlpWleTHRJxLd6FZWJF2RaSufKuVEQNsNM/Zwr8a1yUzMLOaDkG/9iMc7T7lNTQ5penuTgfzMMKoL2lwVnMnt2bOEa7uw9b9lqCK+LLAcnjSAuT6DuG3DK+aH33w8uRzrghHnSdHVLrhrKNWVrerx3nt3VfuNuUFxS3n2PsMaT/OQNdR/QsmqmoBKDzjgMjN0qqg5JqD9XDrziQsxzOgeeXX3VHGAWfsoE4Ob7nPx9o1nifGNK+FaisI3QWkVU6+nYG1LcCYTJ0VVy0NgpeKas6N75Kidgl7Fu3RSl8ssdYeCsXT B0pgeIdV vrT/dDj/j81SgRvuFKQygTaoLRCTOdiCWcXsZ0u6yUG7eMc8FnfcDNrg0jaI9am8MCiruVv43/k1Pyot8k2jQC2DBctuU5YNYInA+Ptj8C5EM+10DPIj9mwj2pPa3raCavNiMLXdFFwvQxzqirvudz2O2Ek7L9TFRVqOUF91vDdR2sc1vWqihZSvjF5ogRlXD68e0RA/NF2ZB1qh04l3xjAzllLVujW9OOfwbTlWY145yTCxdd/Y/3s44dYl7yRmYFp3s4vpErOywdQ0nry4tDghRpbWtjF/MuvfW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: <linux-mm.kvack.org> List-Subscribe: <mailto:majordomo@kvack.org> List-Unsubscribe: <mailto:majordomo@kvack.org> |
Series |
mm/slub: remove duplicate initialization for early_kmem_cache_node_alloc()
|
expand
|
On 4/8/24 7:14 PM, Christoph Lameter (Ampere) wrote: > On Sun, 7 Apr 2024, David Rientjes wrote: > >> What user observable effect does this have given it would only make a >> difference when slab_state == DOWN? > > It reduces the kernel text size and removes a line from source code. Yeah it's not helpful to have redundant code, it may mislead people that it's actually important. Merged to slab/for-next, thanks
diff --git a/mm/slub.c b/mm/slub.c index 0dfc0c18a78b..5ffe46843b36 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -4938,7 +4938,6 @@ static void early_kmem_cache_node_alloc(int node) BUG_ON(!n); #ifdef CONFIG_SLUB_DEBUG init_object(kmem_cache_node, n, SLUB_RED_ACTIVE); - init_tracking(kmem_cache_node, n); #endif n = kasan_slab_alloc(kmem_cache_node, n, GFP_KERNEL, false); slab->freelist = get_freepointer(kmem_cache_node, n);