[v4,0/4] page_owner: Fix refcount imbalance and print fixup

Message

Oscar Salvador April 4, 2024, 7:06 a.m. UTC

This series consists of a refactoring/correctness of updating the metadata
of tail pages, a couple of fixups for the refcounting part and a fixup for
the stack_start() function.

From this series on, instead of counting the stacks, we count the outstanding
nr_base_pages each stack has, which gives us a much better memory overview.
The other fixup is for the migration part.

A more detailed explanation can be found in the changelog of the respective
patches.

v3 -> v4:
 - Fix some typos remarked by Vlastimil
 - Add Reviewed-by tag from Vlastimil and Tested-by tag from Alexandre Ghiti
   (closed a syzbot report for RISC)

Oscar Salvador (4):
  mm,page_owner: Update metadata for tail pages
  mm,page_owner: Fix refcount imbalance
  mm,page_owner: Fix accounting of pages when migrating
  mm,page_owner: Fix printing of stack records

 Documentation/mm/page_owner.rst |  73 +++++++------
 mm/page_owner.c                 | 188 ++++++++++++++++++--------------
 2 files changed, 147 insertions(+), 114 deletions(-)

Comments

Vlastimil Babka April 4, 2024, 7:15 a.m. UTC | #1

On 4/4/24 9:06 AM, Oscar Salvador wrote:
> This series consists of a refactoring/correctness of updating the metadata
> of tail pages, a couple of fixups for the refcounting part and a fixup for
> the stack_start() function.
> 
> From this series on, instead of counting the stacks, we count the outstanding
> nr_base_pages each stack has, which gives us a much better memory overview.
> The other fixup is for the migration part.
> 
> A more detailed explanation can be found in the changelog of the respective
> patches.

It's best to be explicit that this fixes issues in 6.9-rc1 and thus should
be in mm-hotfixes(-unstable). Also you can use e.g. [PATCH mm-hotfixes]
prefix to that effect next time.

> v3 -> v4:
>  - Fix some typos remarked by Vlastimil
>  - Add Reviewed-by tag from Vlastimil and Tested-by tag from Alexandre Ghiti
>    (closed a syzbot report for RISC)
> 
> Oscar Salvador (4):
>   mm,page_owner: Update metadata for tail pages
>   mm,page_owner: Fix refcount imbalance
>   mm,page_owner: Fix accounting of pages when migrating
>   mm,page_owner: Fix printing of stack records
> 
>  Documentation/mm/page_owner.rst |  73 +++++++------
>  mm/page_owner.c                 | 188 ++++++++++++++++++--------------
>  2 files changed, 147 insertions(+), 114 deletions(-)
>

Kefeng Wang April 9, 2024, 1:32 p.m. UTC | #2

On 2024/4/4 15:06, Oscar Salvador wrote:
> This series consists of a refactoring/correctness of updating the metadata
> of tail pages, a couple of fixups for the refcounting part and a fixup for
> the stack_start() function.
> 
>>From this series on, instead of counting the stacks, we count the outstanding
> nr_base_pages each stack has, which gives us a much better memory overview.
> The other fixup is for the migration part.
> 
> A more detailed explanation can be found in the changelog of the respective
> patches.

I think this also should be merged into 6.9-rc1 asap, it is easy to 
occur when migration.

Tested-by: Kefeng Wang <[e-mail]>

> 
> v3 -> v4:
>   - Fix some typos remarked by Vlastimil
>   - Add Reviewed-by tag from Vlastimil and Tested-by tag from Alexandre Ghiti
>     (closed a syzbot report for RISC)
> 
> Oscar Salvador (4):
>    mm,page_owner: Update metadata for tail pages
>    mm,page_owner: Fix refcount imbalance
>    mm,page_owner: Fix accounting of pages when migrating
>    mm,page_owner: Fix printing of stack records
> 
>   Documentation/mm/page_owner.rst |  73 +++++++------
>   mm/page_owner.c                 | 188 ++++++++++++++++++--------------
>   2 files changed, 147 insertions(+), 114 deletions(-)
>