| Message ID | 20240408-ep93xx-clk-v1-0-1d0f4c324647@maquefel.me (mailing list archive) |
|---|---|
| Headers | show |
| Series | DONOTMERGE: ep93xx-clk from ep93xx device tree conversion | expand |
On Mon, Apr 08, 2024 at 11:09:52AM +0300, Nikita Shubin via B4 Relay wrote: > The goal is to recieve ACKs. I dont see a maintainers entry in -rc1 for the drivers/soc/cirrus portion. Who is gonna give you an Ack for that portion? If you intended maintaining that driver, should you not add a MAINTAINERS entry for it? Thanks, Conor. > > This is a fraction of v9 "ep93xx device tree conversion" series: > > https://lore.kernel.org/all/20240326-ep93xx-v9-0-156e2ae5dfc8@maquefel.me/ > > The clk driver for ep93xx was converted to AUX device, as suggested > originally by Stephen Boyd. > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > --- > Nikita Shubin (4): > ARM: ep93xx: add regmap aux_dev > clk: ep93xx: add DT support for Cirrus EP93xx > dt-bindings: soc: Add Cirrus EP93xx > soc: Add SoC driver for Cirrus ep93xx > > .../bindings/arm/cirrus/cirrus,ep9301.yaml | 38 + > .../bindings/soc/cirrus/cirrus,ep9301-syscon.yaml | 94 +++ > drivers/clk/Kconfig | 8 + > drivers/clk/Makefile | 1 + > drivers/clk/clk-ep93xx.c | 840 +++++++++++++++++++++ > drivers/soc/Kconfig | 1 + > drivers/soc/Makefile | 1 + > drivers/soc/cirrus/Kconfig | 13 + > drivers/soc/cirrus/Makefile | 2 + > drivers/soc/cirrus/soc-ep93xx.c | 240 ++++++ > include/dt-bindings/clock/cirrus,ep9301-syscon.h | 46 ++ > include/linux/soc/cirrus/ep93xx.h | 26 + > 12 files changed, 1310 insertions(+) > --- > base-commit: fec50db7033ea478773b159e0e2efb135270e3b7 > change-id: 20240408-ep93xx-clk-657a1357de67 > > Best regards, > -- > Nikita Shubin <nikita.shubin@maquefel.me> > >
Hello Conor! On Mon, 2024-04-08 at 18:03 +0100, Conor Dooley wrote: > On Mon, Apr 08, 2024 at 11:09:52AM +0300, Nikita Shubin via B4 Relay > wrote: > > The goal is to recieve ACKs. > > I dont see a maintainers entry in -rc1 for the drivers/soc/cirrus > portion. Who is gonna give you an Ack for that portion? If you > intended > maintaining that driver, should you not add a MAINTAINERS entry for > it? drivers/soc/cirrus got it's ACK from ep93xx MAINTAINER - Alexander Sverdlin. Arnd, Alexander - should we add it now ? But i still require ACK for "clk: ep93xx: add DT support for Cirrus EP93xx" which is clk subsystems. > > Thanks, > Conor. > > > > > This is a fraction of v9 "ep93xx device tree conversion" series: > > > > https://lore.kernel.org/all/20240326-ep93xx-v9-0-156e2ae5dfc8@maquefel.me/ > > > > The clk driver for ep93xx was converted to AUX device, as suggested > > originally by Stephen Boyd. > > > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> > > --- > > Nikita Shubin (4): > > ARM: ep93xx: add regmap aux_dev > > clk: ep93xx: add DT support for Cirrus EP93xx > > dt-bindings: soc: Add Cirrus EP93xx > > soc: Add SoC driver for Cirrus ep93xx > > > > .../bindings/arm/cirrus/cirrus,ep9301.yaml | 38 + > > .../bindings/soc/cirrus/cirrus,ep9301-syscon.yaml | 94 +++ > > drivers/clk/Kconfig | 8 + > > drivers/clk/Makefile | 1 + > > drivers/clk/clk-ep93xx.c | 840 > > +++++++++++++++++++++ > > drivers/soc/Kconfig | 1 + > > drivers/soc/Makefile | 1 + > > drivers/soc/cirrus/Kconfig | 13 + > > drivers/soc/cirrus/Makefile | 2 + > > drivers/soc/cirrus/soc-ep93xx.c | 240 ++++++ > > include/dt-bindings/clock/cirrus,ep9301-syscon.h | 46 ++ > > include/linux/soc/cirrus/ep93xx.h | 26 + > > 12 files changed, 1310 insertions(+) > > --- > > base-commit: fec50db7033ea478773b159e0e2efb135270e3b7 > > change-id: 20240408-ep93xx-clk-657a1357de67 > > > > Best regards, > > -- > > Nikita Shubin <nikita.shubin@maquefel.me> > > > >
Hi Nikita, On Tue, 2024-04-09 at 14:48 +0300, Nikita Shubin wrote: > On Mon, 2024-04-08 at 18:03 +0100, Conor Dooley wrote: > > On Mon, Apr 08, 2024 at 11:09:52AM +0300, Nikita Shubin via B4 Relay > > wrote: > > > The goal is to recieve ACKs. > > > > I dont see a maintainers entry in -rc1 for the drivers/soc/cirrus > > portion. Who is gonna give you an Ack for that portion? If you > > intended > > maintaining that driver, should you not add a MAINTAINERS entry for > > it? > > drivers/soc/cirrus got it's ACK from ep93xx MAINTAINER - Alexander > Sverdlin. > > Arnd, Alexander - should we add it now ? seems that we have couple of things to fix: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 WARNING: please write a help paragraph that fully describes the config symbol #60: FILE: drivers/soc/cirrus/Kconfig:5: +config EP93XX_SOC + bool "Cirrus EP93xx chips SoC" + select SOC_BUS + select AUXILIARY_BUS + default y if !EP93XX_SOC_COMMON + help + Support SoC for Cirrus EP93xx chips. + total: 0 errors, 2 warnings, 269 lines checked
On Tue, Apr 09, 2024 at 05:09:35PM +0200, Alexander Sverdlin wrote: > Hi Nikita, > > On Tue, 2024-04-09 at 14:48 +0300, Nikita Shubin wrote: > > On Mon, 2024-04-08 at 18:03 +0100, Conor Dooley wrote: > > > On Mon, Apr 08, 2024 at 11:09:52AM +0300, Nikita Shubin via B4 Relay > > > wrote: > > > > The goal is to recieve ACKs. > > > > > > I dont see a maintainers entry in -rc1 for the drivers/soc/cirrus > > > portion. Who is gonna give you an Ack for that portion? If you > > > intended > > > maintaining that driver, should you not add a MAINTAINERS entry for > > > it? > > > > drivers/soc/cirrus got it's ACK from ep93xx MAINTAINER - Alexander > > Sverdlin. > > > > Arnd, Alexander - should we add it now ? > > seems that we have couple of things to fix: > > WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? > #51: > new file mode 100644 > > WARNING: please write a help paragraph that fully describes the config symbol > #60: FILE: drivers/soc/cirrus/Kconfig:5: > +config EP93XX_SOC > + bool "Cirrus EP93xx chips SoC" > + select SOC_BUS > + select AUXILIARY_BUS > + default y if !EP93XX_SOC_COMMON > + help > + Support SoC for Cirrus EP93xx chips. > + > > total: 0 errors, 2 warnings, 269 lines checked FWIW, I wouldn't be too worried about meeting the minimum line check for the Kconfig option that checkpatch requires - but the description here is not clear what the driver does.
The goal is to recieve ACKs. This is a fraction of v9 "ep93xx device tree conversion" series: https://lore.kernel.org/all/20240326-ep93xx-v9-0-156e2ae5dfc8@maquefel.me/ The clk driver for ep93xx was converted to AUX device, as suggested originally by Stephen Boyd. Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me> --- Nikita Shubin (4): ARM: ep93xx: add regmap aux_dev clk: ep93xx: add DT support for Cirrus EP93xx dt-bindings: soc: Add Cirrus EP93xx soc: Add SoC driver for Cirrus ep93xx .../bindings/arm/cirrus/cirrus,ep9301.yaml | 38 + .../bindings/soc/cirrus/cirrus,ep9301-syscon.yaml | 94 +++ drivers/clk/Kconfig | 8 + drivers/clk/Makefile | 1 + drivers/clk/clk-ep93xx.c | 840 +++++++++++++++++++++ drivers/soc/Kconfig | 1 + drivers/soc/Makefile | 1 + drivers/soc/cirrus/Kconfig | 13 + drivers/soc/cirrus/Makefile | 2 + drivers/soc/cirrus/soc-ep93xx.c | 240 ++++++ include/dt-bindings/clock/cirrus,ep9301-syscon.h | 46 ++ include/linux/soc/cirrus/ep93xx.h | 26 + 12 files changed, 1310 insertions(+) --- base-commit: fec50db7033ea478773b159e0e2efb135270e3b7 change-id: 20240408-ep93xx-clk-657a1357de67 Best regards,