Message ID | cover.1712714407.git.tanggeliang@kylinos.cn (mailing list archive) |
---|---|
Headers | show |
Series | refactor mptcp bpf tests | expand |
Hi Geliang, Thank you for your modifications, that's great! Our CI did some validations and here is its report: - KVM Validation: normal: Success! ✅ - KVM Validation: debug: Success! ✅ - KVM Validation: btf (only bpftest_all): Success! ✅ - Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/8625025591 Initiator: Patchew Applier Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/af9fda70e97a Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=843048 If there are some issues, you can reproduce them using the same environment as the one used by the CI thanks to a docker image, e.g.: $ cd [kernel source code] $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \ --pull always mptcp/mptcp-upstream-virtme-docker:latest \ auto-normal For more details: https://github.com/multipath-tcp/mptcp-upstream-virtme-docker Please note that despite all the efforts that have been already done to have a stable tests suite when executed on a public CI like here, it is possible some reported issues are not due to your modifications. Still, do not hesitate to help us improve that ;-) Cheers, MPTCP GH Action bot Bot operated by Matthieu Baerts (NGI0 Core)
Hi Geliang, On 10/04/2024 04:05, Geliang Tang wrote: > From: Geliang Tang <tanggeliang@kylinos.cn> > > v8: > - change argument types of send_data_and_verify from strings to > booleans as Matt suggested. The v8 looks OK to me, but I prefer to wait for Mat's feedback regarding patch 4/9: https://lore.kernel.org/mptcp/f44d5960-8aa3-4914-bae3-4f0c072e07b4@kernel.org/ Cheers, Matt
From: Geliang Tang <tanggeliang@kylinos.cn> v8: - change argument types of send_data_and_verify from strings to booleans as Matt suggested. v7: - address Matt's comments in v6 (thanks) - add more commit logs. - use WITH_DATA/WITHOUT_DATA instead of 1/0. - make patch 3 as a squash-to patch. v6: - drop patch 1 in v5 and rebased. v5: - drop patch 5 in v4: Squash to "selftests/bpf: Add bpf scheduler test" 4 cleanup v4: - add set_nonblock to make BPF tests stable. - split 'Squash to "selftests/bpf: Add bpf scheduler test"' into 4 patches. v3: - part 1, bpf schedulers. v2: - add two more helpers, send_single_byte and send_recv_data. Refactor mptcp bpf tests using newly added macros MPTCP_BASE_TEST, RUN_MPTCP_TEST and MPTCP_SCHED_TEST macro. Geliang Tang (9): selftests/bpf: Add RUN_MPTCP_TEST macro Squash to "selftests/bpf: Add bpf scheduler test" 1 verify Squash to "selftests/bpf: Add bpf scheduler test" 2 time Squash to "selftests/bpf: Add bpf scheduler test" 3 MPTCP_SCHED_TEST Squash to "selftests/bpf: Add bpf_first scheduler & test" Squash to "selftests/bpf: Add bpf_bkup scheduler & test" Squash to "selftests/bpf: Add bpf_rr scheduler & test" Squash to "selftests/bpf: Add bpf_red scheduler & test" Squash to "selftests/bpf: Add bpf_burst scheduler & test" .../testing/selftests/bpf/prog_tests/mptcp.c | 267 +++++------------- .../selftests/bpf/progs/mptcp_bpf_bkup.c | 1 + .../selftests/bpf/progs/mptcp_bpf_burst.c | 1 + .../selftests/bpf/progs/mptcp_bpf_first.c | 1 + .../selftests/bpf/progs/mptcp_bpf_red.c | 1 + .../selftests/bpf/progs/mptcp_bpf_rr.c | 1 + 6 files changed, 79 insertions(+), 193 deletions(-)