| Message ID | 20240409092812.3999785-1-liuhangbin@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8750539ba3178c2bb0d178a30ce57dae132cbbb8 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: team: fix incorrect maxattr | expand |
On Tue, Apr 09, 2024 at 05:28:12PM +0800, Hangbin Liu wrote: > The maxattr should be the latest attr value, i.e. array size - 1, > not total array size. > > Reported-by: syzbot+ecd7e07b4be038658c9f@syzkaller.appspotmail.com > Fixes: 948dbafc15da ("net: team: use policy generated by YAML spec") > Suggested-by: Jakub Kicinski <kuba@kernel.org> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> > --- > drivers/net/team/team_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/team/team_core.c b/drivers/net/team/team_core.c > index 4e3c8d404957..8c7dbaf7c22e 100644 > --- a/drivers/net/team/team_core.c > +++ b/drivers/net/team/team_core.c > @@ -2808,7 +2808,7 @@ static const struct genl_multicast_group team_nl_mcgrps[] = { > static struct genl_family team_nl_family __ro_after_init = { > .name = TEAM_GENL_NAME, > .version = TEAM_GENL_VERSION, > - .maxattr = ARRAY_SIZE(team_nl_policy), > + .maxattr = ARRAY_SIZE(team_nl_policy) - 1, > .policy = team_nl_policy, > .netnsok = true, > .module = THIS_MODULE, > -- > 2.43.0 > #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git main
Hello,
syzbot tried to test the proposed patch but the build/boot failed:
gistered new interface driver port100
[ 8.605288][ T1] usbcore: registered new interface driver nfcmrvl
[ 8.612384][ T1] Loading iSCSI transport class v2.0-870.
[ 8.632743][ T1] virtio_scsi virtio0: 1/0/0 default/read/poll queues
[ 8.649045][ T1] ------------[ cut here ]------------
[ 8.651103][ T1] refcount_t: decrement hit 0; leaking memory.
[ 8.653196][ T1] WARNING: CPU: 0 PID: 1 at lib/refcount.c:31 refcount_warn_saturate+0xfa/0x1d0
[ 8.656346][ T1] Modules linked in:
[ 8.658418][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.9.0-rc2-syzkaller-00751-g811b83628577 #0
[ 8.661088][ T1] Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
[ 8.663945][ T1] RIP: 0010:refcount_warn_saturate+0xfa/0x1d0
[ 8.666244][ T1] Code: b2 00 00 00 e8 f7 ca e7 fc 5b 5d c3 cc cc cc cc e8 eb ca e7 fc c6 05 ed 2e e6 0a 01 90 48 c7 c7 60 53 1f 8c e8 f7 65 aa fc 90 <0f> 0b 90 90 eb d9 e8 cb ca e7 fc c6 05 ca 2e e6 0a 01 90 48 c7 c7
[ 8.672287][ T1] RSP: 0000:ffffc90000066e18 EFLAGS: 00010246
[ 8.674145][ T1] RAX: e9d1be24727a8200 RBX: ffff888140706ffc RCX: ffff8880166d0000
[ 8.676538][ T1] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
[ 8.679139][ T1] RBP: 0000000000000004 R08: ffffffff8157ff62 R09: fffffbfff1c39af8
[ 8.682784][ T1] R10: dffffc0000000000 R11: fffffbfff1c39af8 R12: ffffea000501ddc0
[ 8.684849][ T1] R13: ffffea000501ddc8 R14: 1ffffd4000a03bb9 R15: 0000000000000000
[ 8.687096][ T1] FS: 0000000000000000(0000) GS:ffff8880b9400000(0000) knlGS:0000000000000000
[ 8.690385][ T1] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 8.692275][ T1] CR2: ffff88823ffff000 CR3: 000000000e134000 CR4: 00000000003506f0
[ 8.694842][ T1] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 8.697463][ T1] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 8.699145][ T1] Call Trace:
[ 8.699945][ T1] <TASK>
[ 8.700721][ T1] ? __warn+0x163/0x4e0
[ 8.701507][ T1] ? refcount_warn_saturate+0xfa/0x1d0
[ 8.703186][ T1] ? report_bug+0x2b3/0x500
[ 8.704498][ T1] ? refcount_warn_saturate+0xfa/0x1d0
[ 8.706166][ T1] ? handle_bug+0x3e/0x70
[ 8.707260][ T1] ? exc_invalid_op+0x1a/0x50
[ 8.708055][ T1] ? asm_exc_invalid_op+0x1a/0x20
[ 8.709269][ T1] ? __warn_printk+0x292/0x360
[ 8.710533][ T1] ? refcount_warn_saturate+0xfa/0x1d0
[ 8.712248][ T1] ? refcount_warn_saturate+0xf9/0x1d0
[ 8.714123][ T1] __free_pages_ok+0xc60/0xd90
[ 8.715511][ T1] make_alloc_exact+0xa3/0xf0
[ 8.716981][ T1] vring_alloc_queue_split+0x20a/0x600
[ 8.718319][ T1] ? __pfx_vring_alloc_queue_split+0x10/0x10
[ 8.720194][ T1] ? vp_find_vqs+0x4c/0x4e0
[ 8.721462][ T1] ? virtscsi_probe+0x3ea/0xf60
[ 8.722932][ T1] ? virtio_dev_probe+0x991/0xaf0
[ 8.724571][ T1] ? really_probe+0x2b8/0xad0
[ 8.725948][ T1] ? driver_probe_device+0x50/0x430
[ 8.727795][ T1] vring_create_virtqueue_split+0xc6/0x310
[ 8.729706][ T1] ? ret_from_fork+0x4b/0x80
[ 8.731360][ T1] ? __pfx_vring_create_virtqueue_split+0x10/0x10
[ 8.733405][ T1] vring_create_virtqueue+0xca/0x110
[ 8.735009][ T1] ? __pfx_vp_notify+0x10/0x10
[ 8.736149][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.737338][ T1] setup_vq+0xe9/0x2d0
[ 8.738378][ T1] ? __pfx_vp_notify+0x10/0x10
[ 8.739626][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.741097][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.743341][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.745685][ T1] vp_setup_vq+0xbf/0x330
[ 8.747110][ T1] ? __pfx_vp_config_changed+0x10/0x10
[ 8.748754][ T1] ? ioread16+0x2f/0x90
[ 8.749696][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.751335][ T1] vp_find_vqs_msix+0x8b2/0xc80
[ 8.752882][ T1] vp_find_vqs+0x4c/0x4e0
[ 8.754279][ T1] virtscsi_init+0x8db/0xd00
[ 8.755286][ T1] ? __pfx_virtscsi_init+0x10/0x10
[ 8.756448][ T1] ? __pfx_default_calc_sets+0x10/0x10
[ 8.757687][ T1] ? scsi_host_alloc+0xa57/0xea0
[ 8.758997][ T1] ? vp_get+0xfd/0x140
[ 8.760105][ T1] virtscsi_probe+0x3ea/0xf60
[ 8.761249][ T1] ? __pfx_virtscsi_probe+0x10/0x10
[ 8.763039][ T1] ? vp_modern_admin_cmd_exec+0x5cd/0x820
[ 8.764646][ T1] ? __pfx_vp_set_status+0x10/0x10
[ 8.766479][ T1] ? vp_set_status+0x1a/0x40
[ 8.767568][ T1] ? virtio_no_restricted_mem_acc+0x9/0x10
[ 8.770008][ T1] ? virtio_features_ok+0x10c/0x270
[ 8.771947][ T1] virtio_dev_probe+0x991/0xaf0
[ 8.772988][ T1] ? __pfx_virtio_dev_probe+0x10/0x10
[ 8.774056][ T1] really_probe+0x2b8/0xad0
[ 8.775076][ T1] __driver_probe_device+0x1a2/0x390
[ 8.776233][ T1] driver_probe_device+0x50/0x430
[ 8.777117][ T1] __driver_attach+0x45f/0x710
[ 8.777974][ T1] ? __pfx___driver_attach+0x10/0x10
[ 8.779233][ T1] bus_for_each_dev+0x239/0x2b0
[ 8.780598][ T1] ? __pfx___driver_attach+0x10/0x10
[ 8.781797][ T1] ? __pfx_bus_for_each_dev+0x10/0x10
[ 8.783335][ T1] ? do_raw_spin_unlock+0x13c/0x8b0
[ 8.784745][ T1] bus_add_driver+0x347/0x620
[ 8.785738][ T1] driver_register+0x23a/0x320
[ 8.787433][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 8.789446][ T1] virtio_scsi_init+0x65/0xe0
[ 8.790926][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 8.792609][ T1] do_one_initcall+0x248/0x880
[ 8.793941][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 8.795386][ T1] ? __pfx_lockdep_hardirqs_on_prepare+0x10/0x10
[ 8.797023][ T1] ? __pfx_do_one_initcall+0x10/0x10
[ 8.798339][ T1] ? __pfx_parse_args+0x10/0x10
[ 8.799797][ T1] ? do_initcalls+0x1c/0x80
[ 8.800781][ T1] ? rcu_is_watching+0x15/0xb0
[ 8.802366][ T1] do_initcall_level+0x157/0x210
[ 8.803925][ T1] do_initcalls+0x3f/0x80
[ 8.805248][ T1] kernel_init_freeable+0x435/0x5d0
[ 8.806706][ T1] ? __pfx_kernel_init_freeable+0x10/0x10
[ 8.809002][ T1] ? __pfx_lockdep_hardirqs_on_prepare+0x10/0x10
[ 8.810542][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.812134][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.813888][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.815517][ T1] kernel_init+0x1d/0x2b0
[ 8.817233][ T1] ret_from_fork+0x4b/0x80
[ 8.818982][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.820333][ T1] ret_from_fork_asm+0x1a/0x30
[ 8.821668][ T1] </TASK>
[ 8.822521][ T1] Kernel panic - not syncing: kernel: panic_on_warn set ...
[ 8.824148][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.9.0-rc2-syzkaller-00751-g811b83628577 #0
[ 8.825595][ T1] Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
[ 8.825595][ T1] Call Trace:
[ 8.825595][ T1] <TASK>
[ 8.825595][ T1] dump_stack_lvl+0x241/0x360
[ 8.825595][ T1] ? __pfx_dump_stack_lvl+0x10/0x10
[ 8.825595][ T1] ? __pfx__printk+0x10/0x10
[ 8.825595][ T1] ? _printk+0xd5/0x120
[ 8.825595][ T1] ? vscnprintf+0x5d/0x90
[ 8.825595][ T1] panic+0x349/0x860
[ 8.825595][ T1] ? __warn+0x172/0x4e0
[ 8.825595][ T1] ? __pfx_panic+0x10/0x10
[ 8.825595][ T1] ? show_trace_log_lvl+0x4e6/0x520
[ 8.825595][ T1] ? ret_from_fork_asm+0x1a/0x30
[ 8.825595][ T1] __warn+0x346/0x4e0
[ 8.825595][ T1] ? refcount_warn_saturate+0xfa/0x1d0
[ 8.825595][ T1] report_bug+0x2b3/0x500
[ 8.825595][ T1] ? refcount_warn_saturate+0xfa/0x1d0
[ 8.825595][ T1] handle_bug+0x3e/0x70
[ 8.825595][ T1] exc_invalid_op+0x1a/0x50
[ 8.825595][ T1] asm_exc_invalid_op+0x1a/0x20
[ 8.825595][ T1] RIP: 0010:refcount_warn_saturate+0xfa/0x1d0
[ 8.825595][ T1] Code: b2 00 00 00 e8 f7 ca e7 fc 5b 5d c3 cc cc cc cc e8 eb ca e7 fc c6 05 ed 2e e6 0a 01 90 48 c7 c7 60 53 1f 8c e8 f7 65 aa fc 90 <0f> 0b 90 90 eb d9 e8 cb ca e7 fc c6 05 ca 2e e6 0a 01 90 48 c7 c7
[ 8.865888][ T1] RSP: 0000:ffffc90000066e18 EFLAGS: 00010246
[ 8.865888][ T1] RAX: e9d1be24727a8200 RBX: ffff888140706ffc RCX: ffff8880166d0000
[ 8.865888][ T1] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
[ 8.865888][ T1] RBP: 0000000000000004 R08: ffffffff8157ff62 R09: fffffbfff1c39af8
[ 8.865888][ T1] R10: dffffc0000000000 R11: fffffbfff1c39af8 R12: ffffea000501ddc0
[ 8.865888][ T1] R13: ffffea000501ddc8 R14: 1ffffd4000a03bb9 R15: 0000000000000000
[ 8.865888][ T1] ? __warn_printk+0x292/0x360
[ 8.865888][ T1] ? refcount_warn_saturate+0xf9/0x1d0
[ 8.865888][ T1] __free_pages_ok+0xc60/0xd90
[ 8.865888][ T1] make_alloc_exact+0xa3/0xf0
[ 8.865888][ T1] vring_alloc_queue_split+0x20a/0x600
[ 8.865888][ T1] ? __pfx_vring_alloc_queue_split+0x10/0x10
[ 8.865888][ T1] ? vp_find_vqs+0x4c/0x4e0
[ 8.865888][ T1] ? virtscsi_probe+0x3ea/0xf60
[ 8.865888][ T1] ? virtio_dev_probe+0x991/0xaf0
[ 8.865888][ T1] ? really_probe+0x2b8/0xad0
[ 8.865888][ T1] ? driver_probe_device+0x50/0x430
[ 8.865888][ T1] vring_create_virtqueue_split+0xc6/0x310
[ 8.865888][ T1] ? ret_from_fork+0x4b/0x80
[ 8.865888][ T1] ? __pfx_vring_create_virtqueue_split+0x10/0x10
[ 8.865888][ T1] vring_create_virtqueue+0xca/0x110
[ 8.865888][ T1] ? __pfx_vp_notify+0x10/0x10
[ 8.865888][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.865888][ T1] setup_vq+0xe9/0x2d0
[ 8.865888][ T1] ? __pfx_vp_notify+0x10/0x10
[ 8.865888][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.865888][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.865888][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.865888][ T1] vp_setup_vq+0xbf/0x330
[ 8.865888][ T1] ? __pfx_vp_config_changed+0x10/0x10
[ 8.865888][ T1] ? ioread16+0x2f/0x90
[ 8.915813][ T1] ? __pfx_virtscsi_ctrl_done+0x10/0x10
[ 8.915813][ T1] vp_find_vqs_msix+0x8b2/0xc80
[ 8.915813][ T1] vp_find_vqs+0x4c/0x4e0
[ 8.915813][ T1] virtscsi_init+0x8db/0xd00
[ 8.915813][ T1] ? __pfx_virtscsi_init+0x10/0x10
[ 8.915813][ T1] ? __pfx_default_calc_sets+0x10/0x10
[ 8.915813][ T1] ? scsi_host_alloc+0xa57/0xea0
[ 8.915813][ T1] ? vp_get+0xfd/0x140
[ 8.915813][ T1] virtscsi_probe+0x3ea/0xf60
[ 8.915813][ T1] ? __pfx_virtscsi_probe+0x10/0x10
[ 8.915813][ T1] ? vp_modern_admin_cmd_exec+0x5cd/0x820
[ 8.915813][ T1] ? __pfx_vp_set_status+0x10/0x10
[ 8.915813][ T1] ? vp_set_status+0x1a/0x40
[ 8.915813][ T1] ? virtio_no_restricted_mem_acc+0x9/0x10
[ 8.915813][ T1] ? virtio_features_ok+0x10c/0x270
[ 8.915813][ T1] virtio_dev_probe+0x991/0xaf0
[ 8.915813][ T1] ? __pfx_virtio_dev_probe+0x10/0x10
[ 8.915813][ T1] really_probe+0x2b8/0xad0
[ 8.915813][ T1] __driver_probe_device+0x1a2/0x390
[ 8.915813][ T1] driver_probe_device+0x50/0x430
[ 8.915813][ T1] __driver_attach+0x45f/0x710
[ 8.915813][ T1] ? __pfx___driver_attach+0x10/0x10
[ 8.915813][ T1] bus_for_each_dev+0x239/0x2b0
[ 8.915813][ T1] ? __pfx___driver_attach+0x10/0x10
[ 8.915813][ T1] ? __pfx_bus_for_each_dev+0x10/0x10
[ 8.915813][ T1] ? do_raw_spin_unlock+0x13c/0x8b0
[ 8.915813][ T1] bus_add_driver+0x347/0x620
[ 8.915813][ T1] driver_register+0x23a/0x320
[ 8.915813][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 8.915813][ T1] virtio_scsi_init+0x65/0xe0
[ 8.965813][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 8.965813][ T1] do_one_initcall+0x248/0x880
[ 8.965813][ T1] ? __pfx_virtio_scsi_init+0x10/0x10
[ 8.965813][ T1] ? __pfx_lockdep_hardirqs_on_prepare+0x10/0x10
[ 8.965813][ T1] ? __pfx_do_one_initcall+0x10/0x10
[ 8.965813][ T1] ? __pfx_parse_args+0x10/0x10
[ 8.965813][ T1] ? do_initcalls+0x1c/0x80
[ 8.965813][ T1] ? rcu_is_watching+0x15/0xb0
[ 8.965813][ T1] do_initcall_level+0x157/0x210
[ 8.965813][ T1] do_initcalls+0x3f/0x80
[ 8.965813][ T1] kernel_init_freeable+0x435/0x5d0
[ 8.965813][ T1] ? __pfx_kernel_init_freeable+0x10/0x10
[ 8.965813][ T1] ? __pfx_lockdep_hardirqs_on_prepare+0x10/0x10
[ 8.965813][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.965813][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.965813][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.965813][ T1] kernel_init+0x1d/0x2b0
[ 8.965813][ T1] ret_from_fork+0x4b/0x80
[ 8.965813][ T1] ? __pfx_kernel_init+0x10/0x10
[ 8.965813][ T1] ret_from_fork_asm+0x1a/0x30
[ 8.965813][ T1] </TASK>
[ 8.965813][ T1] Kernel Offset: disabled
[ 8.965813][ T1] Rebooting in 86400 seconds..
syzkaller build log:
go env (err=<nil>)
GO111MODULE='auto'
GOARCH='amd64'
GOBIN=''
GOCACHE='/syzkaller/.cache/go-build'
GOENV='/syzkaller/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/syzkaller/jobs/linux/gopath/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/syzkaller/jobs/linux/gopath'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/local/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/local/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.21.4'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/syzkaller/jobs/linux/gopath/src/github.com/google/syzkaller/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build1094773893=/tmp/go-build -gno-record-gcc-switches'
git status (err=<nil>)
HEAD detached at ca620dd8f
nothing to commit, working tree clean
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
Makefile:31: run command via tools/syz-env for best compatibility, see:
Makefile:32: https://github.com/google/syzkaller/blob/master/docs/contributing.md#using-syz-env
go list -f '{{.Stale}}' ./sys/syz-sysgen | grep -q false || go install ./sys/syz-sysgen
make .descriptions
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
Makefile:31: run command via tools/syz-env for best compatibility, see:
Makefile:32: https://github.com/google/syzkaller/blob/master/docs/contributing.md#using-syz-env
bin/syz-sysgen
touch .descriptions
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=ca620dd8f97f5b3a9134b687b5584203019518fb -X 'github.com/google/syzkaller/prog.gitRevisionDate=20240405-142321'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-fuzzer github.com/google/syzkaller/syz-fuzzer
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=ca620dd8f97f5b3a9134b687b5584203019518fb -X 'github.com/google/syzkaller/prog.gitRevisionDate=20240405-142321'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-execprog github.com/google/syzkaller/tools/syz-execprog
GOOS=linux GOARCH=amd64 go build "-ldflags=-s -w -X github.com/google/syzkaller/prog.GitRevision=ca620dd8f97f5b3a9134b687b5584203019518fb -X 'github.com/google/syzkaller/prog.gitRevisionDate=20240405-142321'" "-tags=syz_target syz_os_linux syz_arch_amd64 " -o ./bin/linux_amd64/syz-stress github.com/google/syzkaller/tools/syz-stress
mkdir -p ./bin/linux_amd64
gcc -o ./bin/linux_amd64/syz-executor executor/executor.cc \
-m64 -O2 -pthread -Wall -Werror -Wparentheses -Wunused-const-variable -Wframe-larger-than=16384 -Wno-stringop-overflow -Wno-array-bounds -Wno-format-overflow -Wno-unused-but-set-variable -Wno-unused-command-line-argument -static-pie -fpermissive -w -DGOOS_linux=1 -DGOARCH_amd64=1 \
-DHOSTGOOS_linux=1 -DGIT_REVISION=\"ca620dd8f97f5b3a9134b687b5584203019518fb\"
Error text is too large and was truncated, full error text is at:
https://syzkaller.appspot.com/x/error.txt?x=11a13da9180000
Tested on:
commit: 811b8362 Merge branch 'minor-cleanups-to-skb-frag-ref-..
git tree: git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git main
kernel config: https://syzkaller.appspot.com/x/.config?x=537dc8b4992a9fba
dashboard link: https://syzkaller.appspot.com/bug?extid=ecd7e07b4be038658c9f
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
Note: no patches were applied.
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 9 Apr 2024 17:28:12 +0800 you wrote: > The maxattr should be the latest attr value, i.e. array size - 1, > not total array size. > > Reported-by: syzbot+ecd7e07b4be038658c9f@syzkaller.appspotmail.com > Fixes: 948dbafc15da ("net: team: use policy generated by YAML spec") > Suggested-by: Jakub Kicinski <kuba@kernel.org> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> > > [...] Here is the summary with links: - [net-next] net: team: fix incorrect maxattr https://git.kernel.org/netdev/net-next/c/8750539ba317 You are awesome, thank you!
diff --git a/drivers/net/team/team_core.c b/drivers/net/team/team_core.c index 4e3c8d404957..8c7dbaf7c22e 100644 --- a/drivers/net/team/team_core.c +++ b/drivers/net/team/team_core.c @@ -2808,7 +2808,7 @@ static const struct genl_multicast_group team_nl_mcgrps[] = { static struct genl_family team_nl_family __ro_after_init = { .name = TEAM_GENL_NAME, .version = TEAM_GENL_VERSION, - .maxattr = ARRAY_SIZE(team_nl_policy), + .maxattr = ARRAY_SIZE(team_nl_policy) - 1, .policy = team_nl_policy, .netnsok = true, .module = THIS_MODULE,
The maxattr should be the latest attr value, i.e. array size - 1, not total array size. Reported-by: syzbot+ecd7e07b4be038658c9f@syzkaller.appspotmail.com Fixes: 948dbafc15da ("net: team: use policy generated by YAML spec") Suggested-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> --- drivers/net/team/team_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)