diff mbox series

[v3,2/2] dma: dt-bindings: fsl-edma: clean up unused "fsl,imx8qm-adma" compatible string

Message ID 20240412030436.2976233-3-joy.zou@nxp.com (mailing list archive)
State Superseded
Headers show
Series clean up unused "fsl,imx8qm-adma" compatible string | expand

Commit Message

Joy Zou April 12, 2024, 3:04 a.m. UTC
The eDMA hardware issue only exist imx8QM A0. A0 never mass production.
The compatible string "fsl,imx8qm-adma" is unused. So remove the
workaround safely.

Signed-off-by: Joy Zou <joy.zou@nxp.com>
---
Changes for v3:
1. modify the commit message.
2. remove the unused compatible string "fsl,imx8qm-adma" from allOf property.
---
 Documentation/devicetree/bindings/dma/fsl,edma.yaml | 2 --
 1 file changed, 2 deletions(-)

Comments

Frank Li April 12, 2024, 3:06 a.m. UTC | #1
On Fri, Apr 12, 2024 at 11:04:36AM +0800, Joy Zou wrote:
> The eDMA hardware issue only exist imx8QM A0. A0 never mass production.
> The compatible string "fsl,imx8qm-adma" is unused. So remove the
> workaround safely.


You missed change subject:

dt-bindings: fsl-edma: clean up unused "fsl,imx8qm-adma" compatible string

dt-bindings should be first patch, then driver code.

I suggest use the same words, "clean up" or "Remove". keep consistent for
both patches

Frank

> 
> Signed-off-by: Joy Zou <joy.zou@nxp.com>
> ---
> Changes for v3:
> 1. modify the commit message.
> 2. remove the unused compatible string "fsl,imx8qm-adma" from allOf property.
> ---
>  Documentation/devicetree/bindings/dma/fsl,edma.yaml | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> index 825f4715499e..cf97ea86a7a2 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> @@ -21,7 +21,6 @@ properties:
>        - enum:
>            - fsl,vf610-edma
>            - fsl,imx7ulp-edma
> -          - fsl,imx8qm-adma
>            - fsl,imx8qm-edma
>            - fsl,imx8ulp-edma
>            - fsl,imx93-edma3
> @@ -92,7 +91,6 @@ allOf:
>          compatible:
>            contains:
>              enum:
> -              - fsl,imx8qm-adma
>                - fsl,imx8qm-edma
>                - fsl,imx93-edma3
>                - fsl,imx93-edma4
> -- 
> 2.37.1
>
Joy Zou April 12, 2024, 6:11 a.m. UTC | #2
> -----Original Message-----
> From: Frank Li <frank.li@nxp.com>
> Sent: 2024年4月12日 11:07
> To: Joy Zou <joy.zou@nxp.com>
> Cc: Peng Fan <peng.fan@nxp.com>; vkoul@kernel.org; robh@kernel.org;
> krzk+dt@kernel.org; conor+dt@kernel.org; imx@lists.linux.dev;
> dmaengine@vger.kernel.org; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH v3 2/2] dma: dt-bindings: fsl-edma: clean up unused
> "fsl,imx8qm-adma" compatible string
> 
> On Fri, Apr 12, 2024 at 11:04:36AM +0800, Joy Zou wrote:
> > The eDMA hardware issue only exist imx8QM A0. A0 never mass
> production.
> > The compatible string "fsl,imx8qm-adma" is unused. So remove the
> > workaround safely.
> 
> 
> You missed change subject:
> 
> dt-bindings: fsl-edma: clean up unused "fsl,imx8qm-adma" compatible string
> 
> dt-bindings should be first patch, then driver code.
> 
> I suggest use the same words, "clean up" or "Remove". keep consistent for
> both patches
Thanks your comments!
Yeah, sorry for forgetting to change it. Will change in next version.
BR
Joy Zou
> 
> Frank
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
index 825f4715499e..cf97ea86a7a2 100644
--- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
+++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
@@ -21,7 +21,6 @@  properties:
       - enum:
           - fsl,vf610-edma
           - fsl,imx7ulp-edma
-          - fsl,imx8qm-adma
           - fsl,imx8qm-edma
           - fsl,imx8ulp-edma
           - fsl,imx93-edma3
@@ -92,7 +91,6 @@  allOf:
         compatible:
           contains:
             enum:
-              - fsl,imx8qm-adma
               - fsl,imx8qm-edma
               - fsl,imx93-edma3
               - fsl,imx93-edma4