| Message ID | 20240325175133.19393-1-macroalpha82@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | User Requested Fixes for Powkiddy RK3566 Devices | expand |
Hello Chris, On 2024-03-25 18:51, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Users have requested fixes for Powkiddy devices to help with some > intermittent WiFi issues by adding additional properties to the > SDMMC2 node. They have also requested that the model name be > represented consistently with both the manufacturer name and model > name. Lastly, there exists a second configuration of the RGB30 with > a slightly different regulator layout we need to describe. > > I have added the new/additional property of "chasis-type" as well. Shouldn't this series be labeled as v2? By the way, regarding renaming the mmcX aliases, maybe that would actually be doable, but only if you have full control over software that runs on these devices. > Chris Morgan (4): > dts: rockchip: Add chasis-type for Powkiddy rk3566 devices > arm64: dts: rockchip: Update sdmmc node for wifi on powkiddy rk3566 > arm64: dts: rockchip: Correct model name for Powkiddy RK3566 Devices > arm64: dts: rockchip: Describe Alternate Regulator Config on RGB30 > > .../dts/rockchip/rk3566-powkiddy-rgb30.dts | 30 ++++++++++++++++++- > .../dts/rockchip/rk3566-powkiddy-rk2023.dts | 6 +++- > .../dts/rockchip/rk3566-powkiddy-rk2023.dtsi | 4 +++ > .../boot/dts/rockchip/rk3566-powkiddy-x55.dts | 4 +++ > 4 files changed, 42 insertions(+), 2 deletions(-)
Am Montag, 25. März 2024, 18:57:06 CET schrieb Dragan Simic: > Hello Chris, > > On 2024-03-25 18:51, Chris Morgan wrote: > > From: Chris Morgan <macromorgan@hotmail.com> > > > > Users have requested fixes for Powkiddy devices to help with some > > intermittent WiFi issues by adding additional properties to the > > SDMMC2 node. They have also requested that the model name be > > represented consistently with both the manufacturer name and model > > name. Lastly, there exists a second configuration of the RGB30 with > > a slightly different regulator layout we need to describe. > > > > I have added the new/additional property of "chasis-type" as well. > > Shouldn't this series be labeled as v2? I think this is for Powkiddy handhelds, the other series was for Anberic ones. Somehow they design and build seemingly dozens of somewhat similar handhelds around the rk3566 ;-) > By the way, regarding renaming the mmcX aliases, maybe that would > actually be doable, but only if you have full control over software > that runs on these devices. > > > Chris Morgan (4): > > dts: rockchip: Add chasis-type for Powkiddy rk3566 devices > > arm64: dts: rockchip: Update sdmmc node for wifi on powkiddy rk3566 > > arm64: dts: rockchip: Correct model name for Powkiddy RK3566 Devices > > arm64: dts: rockchip: Describe Alternate Regulator Config on RGB30 > > > > .../dts/rockchip/rk3566-powkiddy-rgb30.dts | 30 ++++++++++++++++++- > > .../dts/rockchip/rk3566-powkiddy-rk2023.dts | 6 +++- > > .../dts/rockchip/rk3566-powkiddy-rk2023.dtsi | 4 +++ > > .../boot/dts/rockchip/rk3566-powkiddy-x55.dts | 4 +++ > > 4 files changed, 42 insertions(+), 2 deletions(-) >
Hello Heiko, On 2024-03-25 22:53, Heiko Stübner wrote: > Am Montag, 25. März 2024, 18:57:06 CET schrieb Dragan Simic: >> Hello Chris, >> >> On 2024-03-25 18:51, Chris Morgan wrote: >> > From: Chris Morgan <macromorgan@hotmail.com> >> > >> > Users have requested fixes for Powkiddy devices to help with some >> > intermittent WiFi issues by adding additional properties to the >> > SDMMC2 node. They have also requested that the model name be >> > represented consistently with both the manufacturer name and model >> > name. Lastly, there exists a second configuration of the RGB30 with >> > a slightly different regulator layout we need to describe. >> > >> > I have added the new/additional property of "chasis-type" as well. >> >> Shouldn't this series be labeled as v2? > > I think this is for Powkiddy handhelds, the other series was > for Anberic ones. > > Somehow they design and build seemingly dozens of somewhat > similar handhelds around the rk3566 ;-) Ah, you're right, I was wrong. It's quite easy to become confused a bit with such similar devices and similar patches. :) >> By the way, regarding renaming the mmcX aliases, maybe that would >> actually be doable, but only if you have full control over software >> that runs on these devices. >> >> > Chris Morgan (4): >> > dts: rockchip: Add chasis-type for Powkiddy rk3566 devices >> > arm64: dts: rockchip: Update sdmmc node for wifi on powkiddy rk3566 >> > arm64: dts: rockchip: Correct model name for Powkiddy RK3566 Devices >> > arm64: dts: rockchip: Describe Alternate Regulator Config on RGB30 >> > >> > .../dts/rockchip/rk3566-powkiddy-rgb30.dts | 30 ++++++++++++++++++- >> > .../dts/rockchip/rk3566-powkiddy-rk2023.dts | 6 +++- >> > .../dts/rockchip/rk3566-powkiddy-rk2023.dtsi | 4 +++ >> > .../boot/dts/rockchip/rk3566-powkiddy-x55.dts | 4 +++ >> > 4 files changed, 42 insertions(+), 2 deletions(-) >> > > > > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
On Mon, Mar 25, 2024 at 10:53:02PM +0100, Heiko Stübner wrote: > Am Montag, 25. März 2024, 18:57:06 CET schrieb Dragan Simic: > > Hello Chris, > > > > On 2024-03-25 18:51, Chris Morgan wrote: > > > From: Chris Morgan <macromorgan@hotmail.com> > > > > > > Users have requested fixes for Powkiddy devices to help with some > > > intermittent WiFi issues by adding additional properties to the > > > SDMMC2 node. They have also requested that the model name be > > > represented consistently with both the manufacturer name and model > > > name. Lastly, there exists a second configuration of the RGB30 with > > > a slightly different regulator layout we need to describe. > > > > > > I have added the new/additional property of "chasis-type" as well. > > > > Shouldn't this series be labeled as v2? > > I think this is for Powkiddy handhelds, the other series was > for Anberic ones. > > Somehow they design and build seemingly dozens of somewhat > similar handhelds around the rk3566 ;-) Yes they do, and unfortunately in the case of some of the devices they love to make changes and not tell anyone (like the regulator change for the RGB30) In regards to that specific change, let me know if it's not appropriate to put that in the devicetree the way I did. Ideally I'll do a fixup of sorts with U-Boot, but it might be easier if I have a disabled node to work with already... Otherwise these fixes try to resolve some wifi issues for all the devices along with fixing the inconsistent names. I have some additional fixes (coming when I can get them finished and tested) for the Powkiddy devices as some of the screens have slightly shifted pixels. Thank you. > > > > By the way, regarding renaming the mmcX aliases, maybe that would > > actually be doable, but only if you have full control over software > > that runs on these devices. > > > > > Chris Morgan (4): > > > dts: rockchip: Add chasis-type for Powkiddy rk3566 devices > > > arm64: dts: rockchip: Update sdmmc node for wifi on powkiddy rk3566 > > > arm64: dts: rockchip: Correct model name for Powkiddy RK3566 Devices > > > arm64: dts: rockchip: Describe Alternate Regulator Config on RGB30 > > > > > > .../dts/rockchip/rk3566-powkiddy-rgb30.dts | 30 ++++++++++++++++++- > > > .../dts/rockchip/rk3566-powkiddy-rk2023.dts | 6 +++- > > > .../dts/rockchip/rk3566-powkiddy-rk2023.dtsi | 4 +++ > > > .../boot/dts/rockchip/rk3566-powkiddy-x55.dts | 4 +++ > > > 4 files changed, 42 insertions(+), 2 deletions(-) > > > > > >
On Mon, 25 Mar 2024 12:51:29 -0500, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Users have requested fixes for Powkiddy devices to help with some > intermittent WiFi issues by adding additional properties to the > SDMMC2 node. They have also requested that the model name be > represented consistently with both the manufacturer name and model > name. Lastly, there exists a second configuration of the RGB30 with > a slightly different regulator layout we need to describe. > > [...] Applied, thanks! [1/4] dts: rockchip: Add chasis-type for Powkiddy rk3566 devices commit: 9d3d2be86c7d4b1bc16b65a06ba06886913de7e8 [3/4] arm64: dts: rockchip: Correct model name for Powkiddy RK3566 Devices commit: 1b76d86dbc5faf907d74343e1b15daa84ab8322c Best regards,
On Thu, Apr 11, 2024 at 08:29:53PM +0200, Heiko Stuebner wrote: > On Mon, 25 Mar 2024 12:51:29 -0500, Chris Morgan wrote: > > From: Chris Morgan <macromorgan@hotmail.com> > > > > Users have requested fixes for Powkiddy devices to help with some > > intermittent WiFi issues by adding additional properties to the > > SDMMC2 node. They have also requested that the model name be > > represented consistently with both the manufacturer name and model > > name. Lastly, there exists a second configuration of the RGB30 with > > a slightly different regulator layout we need to describe. > > > > [...] > > Applied, thanks! > > [1/4] dts: rockchip: Add chasis-type for Powkiddy rk3566 devices > commit: 9d3d2be86c7d4b1bc16b65a06ba06886913de7e8 > [3/4] arm64: dts: rockchip: Correct model name for Powkiddy RK3566 Devices > commit: 1b76d86dbc5faf907d74343e1b15daa84ab8322c Thank you. Like the other devices as long as we can make the wifi location consistent (mmc3) the rest of the aliases aren't as important. I understand about the regulator stuff, I'll try to fix it up with the bootloader. I just didn't know if there was any proper way/benefit of flagging it this way versus doing a different board revision (even though there is absolutely nothing user visible about the change). > > Best regards, > -- > Heiko Stuebner <heiko@sntech.de>
From: Chris Morgan <macromorgan@hotmail.com> Users have requested fixes for Powkiddy devices to help with some intermittent WiFi issues by adding additional properties to the SDMMC2 node. They have also requested that the model name be represented consistently with both the manufacturer name and model name. Lastly, there exists a second configuration of the RGB30 with a slightly different regulator layout we need to describe. I have added the new/additional property of "chasis-type" as well. Chris Morgan (4): dts: rockchip: Add chasis-type for Powkiddy rk3566 devices arm64: dts: rockchip: Update sdmmc node for wifi on powkiddy rk3566 arm64: dts: rockchip: Correct model name for Powkiddy RK3566 Devices arm64: dts: rockchip: Describe Alternate Regulator Config on RGB30 .../dts/rockchip/rk3566-powkiddy-rgb30.dts | 30 ++++++++++++++++++- .../dts/rockchip/rk3566-powkiddy-rk2023.dts | 6 +++- .../dts/rockchip/rk3566-powkiddy-rk2023.dtsi | 4 +++ .../boot/dts/rockchip/rk3566-powkiddy-x55.dts | 4 +++ 4 files changed, 42 insertions(+), 2 deletions(-)