| Message ID | 20240409113646.305105-1-angelogioacchino.delregno@collabora.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3461e02066758b78a0731eb71faecfb1eccd0e6c |
| Headers | show |
| Series | usb: typec: mux: it5205: Fix ChipID value typo | expand |
On Tue, Apr 09, 2024 at 01:36:46PM +0200, AngeloGioacchino Del Regno wrote: > The ChipID bytes are read in inverse order: invert the ChipID value > defined as IT5205FN_CHIP_ID and used for validating the same. > > Fixes: 41fe9ea1696c ("usb: typec: mux: Add ITE IT5205 Alternate Mode Passive MUX driver") > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/mux/it5205.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/mux/it5205.c b/drivers/usb/typec/mux/it5205.c > index 5535932e42cd..4357cc67a867 100644 > --- a/drivers/usb/typec/mux/it5205.c > +++ b/drivers/usb/typec/mux/it5205.c > @@ -22,7 +22,7 @@ > #include <linux/usb/typec_mux.h> > > #define IT5205_REG_CHIP_ID(x) (0x4 + (x)) > -#define IT5205FN_CHIP_ID 0x35323035 /* "5205" */ > +#define IT5205FN_CHIP_ID 0x35303235 /* "5025" -> "5205" */ > > /* MUX power down register */ > #define IT5205_REG_MUXPDR 0x10 > -- > 2.44.0
diff --git a/drivers/usb/typec/mux/it5205.c b/drivers/usb/typec/mux/it5205.c index 5535932e42cd..4357cc67a867 100644 --- a/drivers/usb/typec/mux/it5205.c +++ b/drivers/usb/typec/mux/it5205.c @@ -22,7 +22,7 @@ #include <linux/usb/typec_mux.h> #define IT5205_REG_CHIP_ID(x) (0x4 + (x)) -#define IT5205FN_CHIP_ID 0x35323035 /* "5205" */ +#define IT5205FN_CHIP_ID 0x35303235 /* "5025" -> "5205" */ /* MUX power down register */ #define IT5205_REG_MUXPDR 0x10
The ChipID bytes are read in inverse order: invert the ChipID value defined as IT5205FN_CHIP_ID and used for validating the same. Fixes: 41fe9ea1696c ("usb: typec: mux: Add ITE IT5205 Alternate Mode Passive MUX driver") Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- drivers/usb/typec/mux/it5205.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)