[net-next,v3,0/4] flower: validate control flags

Message

Asbjørn Sloth Tønnesen April 11, 2024, 10:52 a.m. UTC

I have reviewed the flower control flags code.
In all, but one (sfc), the flags field wasn't
checked properly for unsupported flags.

In this series I have only included a single example
user for each helper function. Once the helpers are in,
I will submit patches for all other drivers implementing
flower.

After which there will be:
- 6 drivers using flow_rule_is_supp_control_flags()
- 8 drivers using flow_rule_has_control_flags()
- 11 drivers using flow_rule_match_has_control_flags()

---
Changelog:

v3:
- Added Reviewed-by from Louis Peens (first two patches)
- Properly fixed kernel-doc format

v2: https://lore.kernel.org/netdev/[e-mail]/
- Squashed the 3 helper functions to one commmit (requested by Baowen Zheng)
- Renamed helper functions to avoid double negatives (suggested by Louis Peens)
- Reverse booleans in some functions and callsites to align with new names
- Fix autodoc format

v1: https://lore.kernel.org/netdev/[e-mail]/

Asbjørn Sloth Tønnesen (4):
  flow_offload: add control flag checking helpers
  nfp: flower: fix check for unsupported control flags
  net: prestera: flower: validate control flags
  net: dsa: microchip: ksz9477: flower: validate control flags

 drivers/net/dsa/microchip/ksz9477_tc_flower.c |  3 +
 .../marvell/prestera/prestera_flower.c        |  4 ++
 .../ethernet/netronome/nfp/flower/offload.c   |  6 +-
 include/net/flow_offload.h                    | 55 +++++++++++++++++++
 4 files changed, 65 insertions(+), 3 deletions(-)

Comments

[e-mail] April 15, 2024, 9:40 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by David S. Miller <[e-mail]>:

On Thu, 11 Apr 2024 10:52:53 +0000 you wrote:
> I have reviewed the flower control flags code.
> In all, but one (sfc), the flags field wasn't
> checked properly for unsupported flags.
> 
> In this series I have only included a single example
> user for each helper function. Once the helpers are in,
> I will submit patches for all other drivers implementing
> flower.
> 
> [...]

Here is the summary with links:
  - [net-next,v3,1/4] flow_offload: add control flag checking helpers
    https://git.kernel.org/netdev/net-next/c/d11e63119432
  - [net-next,v3,2/4] nfp: flower: fix check for unsupported control flags
    https://git.kernel.org/netdev/net-next/c/e36245dacd2c
  - [net-next,v3,3/4] net: prestera: flower: validate control flags
    https://git.kernel.org/netdev/net-next/c/f8a5ea8c2a7f
  - [net-next,v3,4/4] net: dsa: microchip: ksz9477: flower: validate control flags
    https://git.kernel.org/netdev/net-next/c/d9a1249e715b

You are awesome, thank you!