diff mbox series

[1/2] dt-bindings: net/nfc: ti,trf7970a: Add rx-gain-reduction option

Message ID AM0PR09MB267553535F7A85EA639D739C95082@AM0PR09MB2675.eurprd09.prod.outlook.com (mailing list archive)
State Changes Requested
Delegated to: Netdev Maintainers
Headers show
Series trf7970a: Device tree option for RX gain reduction | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 8 this patch: 8
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers warning 1 maintainers not CCed: krzysztof.kozlowski@linaro.org
netdev/build_clang success Errors and warnings before: 8 this patch: 8
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 17 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-04-17--09-00 (tests: 959)

Commit Message

Paul Geurts April 16, 2024, 10:18 p.m. UTC 
Add option to reduce the RX antenna gain to be able to reduce the
sensitivity.

Signed-off-by: Paul Geurts <paul_geurts@live.nl>
---
 Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Krzysztof Kozlowski April 17, 2024, 1:12 p.m. UTC | #1 
On 17/04/2024 00:18, Paul Geurts wrote:
> Add option to reduce the RX antenna gain to be able to reduce the
> sensitivity.
> 
> Signed-off-by: Paul Geurts <paul_geurts@live.nl>
> ---
>  Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
> index d0332eb76ad2..bbd045f6cf04 100644
> --- a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
> +++ b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
> @@ -55,6 +55,11 @@ properties:
>      description: |
>        Regulator for supply voltage to VIN pin
>  
> +  rx-gain-reduction:

Missing vendor prefix.

> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: |

Do not need '|' unless you need to preserve formatting.

> +      Specify a RX gain reduction to reduce antenna sensitivity.

Reduction by what? What are the units?


Best regards,
Krzysztof
Paul Geurts April 19, 2024, 7:30 a.m. UTC | #2 
On 17-04-2024 15:12, Krzysztof Kozlowski wrote:
> On 17/04/2024 00:18, Paul Geurts wrote:
>> Add option to reduce the RX antenna gain to be able to reduce the
>> sensitivity.
>>
>> Signed-off-by: Paul Geurts <paul_geurts@live.nl>
>> ---
>>  Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
>> index d0332eb76ad2..bbd045f6cf04 100644
>> --- a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
>> +++ b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
>> @@ -55,6 +55,11 @@ properties:
>>      description: |
>>        Regulator for supply voltage to VIN pin
>>  
>> +  rx-gain-reduction:
> Missing vendor prefix.
>
>> +    $ref: /schemas/types.yaml#/definitions/uint32
>> +    description: |
> Do not need '|' unless you need to preserve formatting.
>
>> +      Specify a RX gain reduction to reduce antenna sensitivity.
> Reduction by what? What are the units?

Yes, this is a bit unclear indeed. Will clarify this.

>
>
> Best regards,
> Krzysztof

Thanks!

br,

Paul
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
index d0332eb76ad2..bbd045f6cf04 100644
--- a/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
+++ b/Documentation/devicetree/bindings/net/nfc/ti,trf7970a.yaml
@@ -55,6 +55,11 @@  properties:
     description: |
       Regulator for supply voltage to VIN pin
 
+  rx-gain-reduction:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description: |
+      Specify a RX gain reduction to reduce antenna sensitivity.
+
 required:
   - compatible
   - interrupts
@@ -95,5 +100,6 @@  examples:
             irq-status-read-quirk;
             en2-rf-quirk;
             clock-frequency = <27120000>;
+            rx-gain-reduction = <3>;
         };
     };