| Message ID | 20240417140013.12575-1-fancer.lancer@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: stmmac: Fix MAC-capabilities procedure | expand |
On Wed, 17 Apr 2024 17:00:06 +0300 Serge Semin wrote: > The series got born as a result of the discussions around the recent > Yanteng' series adding the Loongson LS7A1000, LS2K1000, LS7A2000, LS2K2000 > MACs support: > Link: https://lore.kernel.org/netdev/fu3f6uoakylnb6eijllakeu5i4okcyqq7sfafhp5efaocbsrwe@w74xe7gb6x7p > > In particular the Yanteng' patchset needed to implement the Loongson > MAC-specific constraints applied to the link speed and link duplex mode. > As a result of the discussion with Russel the next preliminary patch was > born: > Link: https://lore.kernel.org/netdev/df31e8bcf74b3b4ddb7ddf5a1c371390f16a2ad5.1712917541.git.siyanteng@loongson.cn > > The patch above was a temporal solution utilized by Yanteng for further > developments and to move on with the on-going review. This patchset is a > refactored version of that single patch with formatting required for the > fixes patches. > > The main part of the series has already been merged in on v1 stage. The > leftover is the cleanup patches which rename > stmmac_ops::phylink_get_caps() callback to stmmac_ops::update_caps() and > move the MAC-capabilities init/re-init to the phylink MAC-capabilities > getter. According to the build bot it didn't apply at the time of posting :S It does apply now but the bot doesn't have a "retry now" button. Could you repost?
On Thu, Apr 18, 2024 at 06:53:28PM -0700, Jakub Kicinski wrote: > On Wed, 17 Apr 2024 17:00:06 +0300 Serge Semin wrote: > > The series got born as a result of the discussions around the recent > > Yanteng' series adding the Loongson LS7A1000, LS2K1000, LS7A2000, LS2K2000 > > MACs support: > > Link: https://lore.kernel.org/netdev/fu3f6uoakylnb6eijllakeu5i4okcyqq7sfafhp5efaocbsrwe@w74xe7gb6x7p > > > > In particular the Yanteng' patchset needed to implement the Loongson > > MAC-specific constraints applied to the link speed and link duplex mode. > > As a result of the discussion with Russel the next preliminary patch was > > born: > > Link: https://lore.kernel.org/netdev/df31e8bcf74b3b4ddb7ddf5a1c371390f16a2ad5.1712917541.git.siyanteng@loongson.cn > > > > The patch above was a temporal solution utilized by Yanteng for further > > developments and to move on with the on-going review. This patchset is a > > refactored version of that single patch with formatting required for the > > fixes patches. > > > > The main part of the series has already been merged in on v1 stage. The > > leftover is the cleanup patches which rename > > stmmac_ops::phylink_get_caps() callback to stmmac_ops::update_caps() and > > move the MAC-capabilities init/re-init to the phylink MAC-capabilities > > getter. > > According to the build bot it didn't apply at the time of posting :S Most likely it happened because the first three patches https://lore.kernel.org/netdev/20240412180340.7965-1-fancer.lancer@gmail.com/ hadn't been merged in yet back then. They are now. > It does apply now but the bot doesn't have a "retry now" button. > Could you repost? Sure. I'll do that in an instant. -Serge(y) > -- > pw-bot: cr
The series got born as a result of the discussions around the recent Yanteng' series adding the Loongson LS7A1000, LS2K1000, LS7A2000, LS2K2000 MACs support: Link: https://lore.kernel.org/netdev/fu3f6uoakylnb6eijllakeu5i4okcyqq7sfafhp5efaocbsrwe@w74xe7gb6x7p In particular the Yanteng' patchset needed to implement the Loongson MAC-specific constraints applied to the link speed and link duplex mode. As a result of the discussion with Russel the next preliminary patch was born: Link: https://lore.kernel.org/netdev/df31e8bcf74b3b4ddb7ddf5a1c371390f16a2ad5.1712917541.git.siyanteng@loongson.cn The patch above was a temporal solution utilized by Yanteng for further developments and to move on with the on-going review. This patchset is a refactored version of that single patch with formatting required for the fixes patches. The main part of the series has already been merged in on v1 stage. The leftover is the cleanup patches which rename stmmac_ops::phylink_get_caps() callback to stmmac_ops::update_caps() and move the MAC-capabilities init/re-init to the phylink MAC-capabilities getter. Link: https://lore.kernel.org/netdev/20240412180340.7965-1-fancer.lancer@gmail.com/ Changelog v2: - Add a new patch (Romain): [PATCH net-next v2 1/2] net: stmmac: Rename phylink_get_caps() callback to update_caps() - Resubmit the leftover patches to net-next tree (Paolo). Signed-off-by: Serge Semin <fancer.lancer@gmail.com> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: Simon Horman <horms@kernel.org> Cc: Huacai Chen <chenhuacai@kernel.org> Cc: Chen-Yu Tsai <wens@csie.org> Cc: Jernej Skrabec <jernej.skrabec@gmail.com> Cc: Samuel Holland <samuel@sholland.org> Cc: netdev@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-sunxi@lists.linux.dev Cc: linux-kernel@vger.kernel.org Serge Semin (2): net: stmmac: Rename phylink_get_caps() callback to update_caps() net: stmmac: Move MAC caps init to phylink MAC caps getter .../net/ethernet/stmicro/stmmac/dwmac4_core.c | 8 ++--- drivers/net/ethernet/stmicro/stmmac/hwif.h | 8 ++--- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 36 +++++++++---------- 3 files changed, 25 insertions(+), 27 deletions(-)