| Message ID | 20240418102321.95384-4-xni@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | mdadm tests fix and enhance | expand |
On Thu, 18 Apr 2024 18:23:19 +0800 Xiao Ni <xni@redhat.com> wrote: > After removing dev0, the recovery starts because it already has a spare > disk. It's good to check recovery. But it's not right to check recovery > after adding dev3. Because the recovery may finish. It depends on the > recovery performance of the testing machine. If the recovery finishes, > it will fail. But dev3 is only added as a spare disk, we can't expect > there is a recovery happens. > > So remove the codes about adding dev3. > > Signed-off-by: Xiao Ni <xni@redhat.com> > --- LGTM. Mariusz
On Thu, 18 Apr 2024 18:23:19 +0800 Xiao Ni <xni@redhat.com> wrote: > After removing dev0, the recovery starts because it already has a spare > disk. It's good to check recovery. But it's not right to check recovery > after adding dev3. Because the recovery may finish. It depends on the > recovery performance of the testing machine. If the recovery finishes, > it will fail. But dev3 is only added as a spare disk, we can't expect > there is a recovery happens. > > So remove the codes about adding dev3. > > Signed-off-by: Xiao Ni <xni@redhat.com> > --- Applying this one! Thanks, Mariusz
diff --git a/tests/01r5fail b/tests/01r5fail index 873dba585e58..c210d6e747f2 100644 --- a/tests/01r5fail +++ b/tests/01r5fail @@ -17,11 +17,7 @@ check wait mdadm $md0 --fail $dev0 mdadm $md0 --remove $dev3 $dev0 check recovery -check state _UUU - -mdadm $md0 -a $dev3 -check recovery check wait check state UUUU -mdadm -S $md0 \ No newline at end of file +mdadm -S $md0
After removing dev0, the recovery starts because it already has a spare disk. It's good to check recovery. But it's not right to check recovery after adding dev3. Because the recovery may finish. It depends on the recovery performance of the testing machine. If the recovery finishes, it will fail. But dev3 is only added as a spare disk, we can't expect there is a recovery happens. So remove the codes about adding dev3. Signed-off-by: Xiao Ni <xni@redhat.com> --- tests/01r5fail | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)