| Message ID | 20240419164458.36078-1-steve.schrock@getcruise.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 279b04c15127499e52532ac08d947d45a48605e6 |
| Headers | show |
| Series | [1/8] qmi unit: Link to dl | expand |
Hi Steve, > One of my VMs was getting a linker error when building > test-qmimodem-qmi in maintainer mode: > undefined reference to `dladdr' > > Add -ldl to fix this. > --- > Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile.am b/Makefile.am > index 9a6f82c39552..a4880036eaf5 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -932,7 +932,7 @@ unit_objects += $(unit_test_mbim_OBJECTS) > unit_test_qmimodem_qmi_SOURCES = unit/test-qmimodem-qmi.c src/common.c \ > src/util.c src/log.c \ > drivers/qmimodem/qmi.c > -unit_test_qmimodem_qmi_LDADD = @GLIB_LIBS@ $(ell_ldadd) > +unit_test_qmimodem_qmi_LDADD = @GLIB_LIBS@ $(ell_ldadd) -ldl this depends on HAVE_BACKTRACE. Regards Marcel
Thanks for the explanation, Marcel. That makes sense -- the VM that had the linker error is a fairly minimal installation. Steve On Fri, Apr 19, 2024 at 11:53 AM Marcel Holtmann <marcel@holtmann.org> wrote: > > Hi Steve, > > > One of my VMs was getting a linker error when building > > test-qmimodem-qmi in maintainer mode: > > undefined reference to `dladdr' > > > > Add -ldl to fix this. > > --- > > Makefile.am | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Makefile.am b/Makefile.am > > index 9a6f82c39552..a4880036eaf5 100644 > > --- a/Makefile.am > > +++ b/Makefile.am > > @@ -932,7 +932,7 @@ unit_objects += $(unit_test_mbim_OBJECTS) > > unit_test_qmimodem_qmi_SOURCES = unit/test-qmimodem-qmi.c src/common.c \ > > src/util.c src/log.c \ > > drivers/qmimodem/qmi.c > > -unit_test_qmimodem_qmi_LDADD = @GLIB_LIBS@ $(ell_ldadd) > > +unit_test_qmimodem_qmi_LDADD = @GLIB_LIBS@ $(ell_ldadd) -ldl > > this depends on HAVE_BACKTRACE. > > Regards > > Marcel >
Hello: This series was applied to ofono.git (master) by Denis Kenzior <denkenz@gmail.com>: On Fri, 19 Apr 2024 16:44:51 +0000 you wrote: > One of my VMs was getting a linker error when building > test-qmimodem-qmi in maintainer mode: > undefined reference to `dladdr' > > Add -ldl to fix this. > --- > Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [1/8] qmi unit: Link to dl https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=279b04c15127 - [2/8] qmi: Eliminate atomic ref counting https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=39b7437a0044 - [3/8] qmi: Create a better client service abstraction https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=6131bfc81468 - [4/8] qmi: Eliminate unnecessary casting to unsigned int https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=28d60206ba2d - [5/8] qmi: Prevent clients from unregistering for others https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=e13fb8f498cc - [6/8] qmi unit: Validate creation of services of the same type https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=af2718346a28 - [7/8] qmi unit: Validate destroyed services do not notify https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=2d4e571d1598 - [8/8] qmi unit: Validate notifications are independent https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=1c999cd5a0a8 You are awesome, thank you!
diff --git a/Makefile.am b/Makefile.am index 9a6f82c39552..a4880036eaf5 100644 --- a/Makefile.am +++ b/Makefile.am @@ -932,7 +932,7 @@ unit_objects += $(unit_test_mbim_OBJECTS) unit_test_qmimodem_qmi_SOURCES = unit/test-qmimodem-qmi.c src/common.c \ src/util.c src/log.c \ drivers/qmimodem/qmi.c -unit_test_qmimodem_qmi_LDADD = @GLIB_LIBS@ $(ell_ldadd) +unit_test_qmimodem_qmi_LDADD = @GLIB_LIBS@ $(ell_ldadd) -ldl unit_objects += $(unit_test_qmimodem_qmi_OBJECTS) unit/test-provision.db: unit/test-provision.json