| Message ID | 1713564212-21725-1-git-send-email-quic_zijuhu@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix two regression issues for QCA controllers | expand |
On 20/04/2024 00:03, Zijun Hu wrote: > This patch series are to fix below 2 regression issues for QCA controllers > 1) BT can't be enabled once BT was ever enabled for QCA_QCA6390 > 2) BT can't be enabled after disable then warm reboot for QCA_QCA6390 > > the links for these issues are shown below: > https://bugzilla.kernel.org/show_bug.cgi?id=218726 > https://lore.kernel.org/linux-bluetooth/ea20 Provide changelog, either in cover letter or in individual patches under ---. Do not attach (thread) your patchsets to some other threads (unrelated or older versions). This buries them deep in the mailbox and might interfere with applying entire sets. Best regards, Krzysztof
On 20/04/2024 13:01, Krzysztof Kozlowski wrote: > On 20/04/2024 00:03, Zijun Hu wrote: >> This patch series are to fix below 2 regression issues for QCA controllers >> 1) BT can't be enabled once BT was ever enabled for QCA_QCA6390 >> 2) BT can't be enabled after disable then warm reboot for QCA_QCA6390 >> >> the links for these issues are shown below: >> https://bugzilla.kernel.org/show_bug.cgi?id=218726 >> https://lore.kernel.org/linux-bluetooth/ea20 > > > Provide changelog, either in cover letter or in individual patches under > ---. > > Do not attach (thread) your patchsets to some other threads (unrelated > or older versions). This buries them deep in the mailbox and might > interfere with applying entire sets. > How did you implement these two feedbacks? v4 and v5 are still bad. Best regards, Krzysztof
On 4/22/2024 3:44 PM, Krzysztof Kozlowski wrote: > On 20/04/2024 13:01, Krzysztof Kozlowski wrote: >> On 20/04/2024 00:03, Zijun Hu wrote: >>> This patch series are to fix below 2 regression issues for QCA controllers >>> 1) BT can't be enabled once BT was ever enabled for QCA_QCA6390 >>> 2) BT can't be enabled after disable then warm reboot for QCA_QCA6390 >>> >>> the links for these issues are shown below: >>> https://bugzilla.kernel.org/show_bug.cgi?id=218726 >>> https://lore.kernel.org/linux-bluetooth/ea20 >> >> >> Provide changelog, either in cover letter or in individual patches under >> ---. >> >> Do not attach (thread) your patchsets to some other threads (unrelated >> or older versions). This buries them deep in the mailbox and might >> interfere with applying entire sets. >> > sorry, not notice this. in order to send vN patch sets. do i need to --in-reply-to v(N-1) cover letter or v0 cover-letter ? > How did you implement these two feedbacks? > actually. i don't understand that two feedbacks so ask above questions. > v4 and v5 are still bad. > > Best regards, > Krzysztof >
On 22/04/2024 10:07, quic_zijuhu wrote: > On 4/22/2024 3:44 PM, Krzysztof Kozlowski wrote: >> On 20/04/2024 13:01, Krzysztof Kozlowski wrote: >>> On 20/04/2024 00:03, Zijun Hu wrote: >>>> This patch series are to fix below 2 regression issues for QCA controllers >>>> 1) BT can't be enabled once BT was ever enabled for QCA_QCA6390 >>>> 2) BT can't be enabled after disable then warm reboot for QCA_QCA6390 >>>> >>>> the links for these issues are shown below: >>>> https://bugzilla.kernel.org/show_bug.cgi?id=218726 >>>> https://lore.kernel.org/linux-bluetooth/ea20 >>> >>> >>> Provide changelog, either in cover letter or in individual patches under >>> ---. >>> >>> Do not attach (thread) your patchsets to some other threads (unrelated >>> or older versions). This buries them deep in the mailbox and might >>> interfere with applying entire sets. >>> >> > sorry, not notice this. > in order to send vN patch sets. > do i need to --in-reply-to v(N-1) cover letter or v0 cover-letter ? No. b4 or git send-email handle everything correctly. Read go/upstream before posting. If you ask such question, I doubt that you read it. Eventually get someone experienced to help you with this. > >> How did you implement these two feedbacks? >> > actually. i don't understand that two feedbacks so ask above questions. You did not ask questions. You ignored that feedback and kept sending patches, pushing for your point of view and responding to review with unrelated sentences. Best regards, Krzysztof
On 4/22/2024 4:11 PM, Krzysztof Kozlowski wrote: > On 22/04/2024 10:07, quic_zijuhu wrote: >> On 4/22/2024 3:44 PM, Krzysztof Kozlowski wrote: >>> On 20/04/2024 13:01, Krzysztof Kozlowski wrote: >>>> On 20/04/2024 00:03, Zijun Hu wrote: >>>>> This patch series are to fix below 2 regression issues for QCA controllers >>>>> 1) BT can't be enabled once BT was ever enabled for QCA_QCA6390 >>>>> 2) BT can't be enabled after disable then warm reboot for QCA_QCA6390 >>>>> >>>>> the links for these issues are shown below: >>>>> https://bugzilla.kernel.org/show_bug.cgi?id=218726 >>>>> https://lore.kernel.org/linux-bluetooth/ea20 >>>> >>>> >>>> Provide changelog, either in cover letter or in individual patches under >>>> ---. >>>> >>>> Do not attach (thread) your patchsets to some other threads (unrelated >>>> or older versions). This buries them deep in the mailbox and might >>>> interfere with applying entire sets. >>>> >>> >> sorry, not notice this. >> in order to send vN patch sets. >> do i need to --in-reply-to v(N-1) cover letter or v0 cover-letter ? > > No. b4 or git send-email handle everything correctly. Read go/upstream > before posting. If you ask such question, I doubt that you read it. > Eventually get someone experienced to help you with this. > actually. i have read go/upstream many times. but b4 is hard for me to use. so i always use git send-email to send patches and use thunderbird to reply mails. we get someone to help. >> >>> How did you implement these two feedbacks? >>> >> actually. i don't understand that two feedbacks so ask above questions. > > You did not ask questions. You ignored that feedback and kept sending > patches, pushing for your point of view and responding to review with > unrelated sentences. > i now understood your feedbacks and concerns about format. > Best regards, > Krzysztof >
This patch series are to fix below 2 regression issues for QCA controllers 1) BT can't be enabled once BT was ever enabled for QCA_QCA6390 2) BT can't be enabled after disable then warm reboot for QCA_QCA6390 the links for these issues are shown below: https://bugzilla.kernel.org/show_bug.cgi?id=218726 https://lore.kernel.org/linux-bluetooth/ea20bb9b-6b60-47fc-ae42-5eed918ad7b4@quicinc.com/T/#m73d6a71d2f454bb03588c66f3ef7912274d37c6f Zijun Hu (2): Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 Bluetooth: qca: Fix BT enable failure for QCA_QCA6390 after disable then warm reboot drivers/bluetooth/hci_qca.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)