| Message ID | 7f5110805a5180fb910d735f631c6f3b9a19dee4.1713624621.git.pav@iki.fi (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8e5f3433dc5f88164aeba8e077cd125717146e34 |
| Headers | show |
| Series | [BlueZ] bap: call select_cb on bt_bap_cancel_select() to clean up | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | warning | WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '41d6c4e1c92f', maybe rebased or not pulled? #96: Fixes: 41d6c4e1c92f ("bap: cancel ongoing SelectProperties() before freeing the ep") /github/workspace/src/src/13637159.patch total: 0 errors, 1 warnings, 7 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/src/13637159.patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=846336
---Test result---
Test Summary:
CheckPatch FAIL 0.51 seconds
GitLint PASS 0.21 seconds
BuildEll PASS 24.36 seconds
BluezMake PASS 1655.16 seconds
MakeCheck PASS 12.74 seconds
MakeDistcheck PASS 175.12 seconds
CheckValgrind PASS 244.96 seconds
CheckSmatch PASS 348.65 seconds
bluezmakeextell PASS 118.36 seconds
IncrementalBuild PASS 1442.54 seconds
ScanBuild PASS 982.82 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ] bap: call select_cb on bt_bap_cancel_select() to clean up
WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '41d6c4e1c92f', maybe rebased or not pulled?
#96:
Fixes: 41d6c4e1c92f ("bap: cancel ongoing SelectProperties() before freeing the ep")
/github/workspace/src/src/13637159.patch total: 0 errors, 1 warnings, 7 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13637159.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Sat, 20 Apr 2024 17:52:48 +0300 you wrote: > Have bt_bap_cancel_select() to trigger the callback function with error > code, simplifying the cleanup when ep is freed while SelectProperties is > ongoing. > > Fixes bap_data->selecting not being decremented when ep setup is > canceled, which results to transports not being created thereafter. > > [...] Here is the summary with links: - [BlueZ] bap: call select_cb on bt_bap_cancel_select() to clean up https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8e5f3433dc5f You are awesome, thank you!
diff --git a/profiles/audio/media.c b/profiles/audio/media.c index 144f6bfc4..07147a25d 100644 --- a/profiles/audio/media.c +++ b/profiles/audio/media.c @@ -1055,7 +1055,6 @@ static void pac_cancel_select(struct bt_bap_pac *lpac, bt_bap_pac_select_t cb, continue; } - req->cb = NULL; media_endpoint_cancel(req); l = endpoint->requests; }
Have bt_bap_cancel_select() to trigger the callback function with error code, simplifying the cleanup when ep is freed while SelectProperties is ongoing. Fixes bap_data->selecting not being decremented when ep setup is canceled, which results to transports not being created thereafter. Fixes: 41d6c4e1c92f ("bap: cancel ongoing SelectProperties() before freeing the ep") --- profiles/audio/media.c | 1 - 1 file changed, 1 deletion(-)