| Message ID | 20240420020827.3288615-1-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a44f2eb106a46f2275a79de54ce0ea63e4f3d8c8 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] tools: ynl: don't ignore errors in NLMSG_DONE messages | expand |
Jakub Kicinski <kuba@kernel.org> writes: > NLMSG_DONE contains an error code, it has to be extracted. > Prior to this change all dumps will end in success, > and in case of failure the result is silently truncated. > > Fixes: e4b48ed460d3 ("tools: ynl: add a completely generic client") > Signed-off-by: Jakub Kicinski <kuba@kernel.org> Reviewed-by: Donald Hunter <donald.hunter@gmail.com> > --- > CC: donald.hunter@gmail.com > CC: jiri@resnulli.us > CC: sdf@google.com > --- > tools/net/ynl/lib/ynl.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/net/ynl/lib/ynl.py b/tools/net/ynl/lib/ynl.py > index a67f7b6fef92..a9e4d588baf6 100644 > --- a/tools/net/ynl/lib/ynl.py > +++ b/tools/net/ynl/lib/ynl.py > @@ -203,6 +203,7 @@ from .nlspec import SpecFamily > self.done = 1 > extack_off = 20 > elif self.nl_type == Netlink.NLMSG_DONE: > + self.error = struct.unpack("i", self.raw[0:4])[0] > self.done = 1 > extack_off = 4
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni <pabeni@redhat.com>: On Fri, 19 Apr 2024 19:08:26 -0700 you wrote: > NLMSG_DONE contains an error code, it has to be extracted. > Prior to this change all dumps will end in success, > and in case of failure the result is silently truncated. > > Fixes: e4b48ed460d3 ("tools: ynl: add a completely generic client") > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > > [...] Here is the summary with links: - [net] tools: ynl: don't ignore errors in NLMSG_DONE messages https://git.kernel.org/netdev/net/c/a44f2eb106a4 You are awesome, thank you!
diff --git a/tools/net/ynl/lib/ynl.py b/tools/net/ynl/lib/ynl.py index a67f7b6fef92..a9e4d588baf6 100644 --- a/tools/net/ynl/lib/ynl.py +++ b/tools/net/ynl/lib/ynl.py @@ -203,6 +203,7 @@ from .nlspec import SpecFamily self.done = 1 extack_off = 20 elif self.nl_type == Netlink.NLMSG_DONE: + self.error = struct.unpack("i", self.raw[0:4])[0] self.done = 1 extack_off = 4
NLMSG_DONE contains an error code, it has to be extracted. Prior to this change all dumps will end in success, and in case of failure the result is silently truncated. Fixes: e4b48ed460d3 ("tools: ynl: add a completely generic client") Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- CC: donald.hunter@gmail.com CC: jiri@resnulli.us CC: sdf@google.com --- tools/net/ynl/lib/ynl.py | 1 + 1 file changed, 1 insertion(+)