| Message ID | 20240420025029.2166544-14-willy@infradead.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Remove PG_error flag | expand |
On Sat 20-04-24 03:50:08, Matthew Wilcox (Oracle) wrote: > Nobody checks the error flag on isofs folios, so stop setting and > clearing it. > > Cc: Jan Kara <jack@suse.cz> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> Do you plan to merge this together or should I pick this up myself? Feel free to add: Acked-by: Jan Kara <jack@suse.cz> Honza > --- > fs/isofs/compress.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/fs/isofs/compress.c b/fs/isofs/compress.c > index c4da3f634b92..34d5baa5d88a 100644 > --- a/fs/isofs/compress.c > +++ b/fs/isofs/compress.c > @@ -346,8 +346,6 @@ static int zisofs_read_folio(struct file *file, struct folio *folio) > for (i = 0; i < pcount; i++, index++) { > if (i != full_page) > pages[i] = grab_cache_page_nowait(mapping, index); > - if (pages[i]) > - ClearPageError(pages[i]); > } > > err = zisofs_fill_pages(inode, full_page, pcount, pages); > @@ -356,8 +354,6 @@ static int zisofs_read_folio(struct file *file, struct folio *folio) > for (i = 0; i < pcount; i++) { > if (pages[i]) { > flush_dcache_page(pages[i]); > - if (i == full_page && err) > - SetPageError(pages[i]); > unlock_page(pages[i]); > if (i != full_page) > put_page(pages[i]); > -- > 2.43.0 >
On Mon, Apr 22, 2024 at 11:57:53PM +0200, Jan Kara wrote: > On Sat 20-04-24 03:50:08, Matthew Wilcox (Oracle) wrote: > > Nobody checks the error flag on isofs folios, so stop setting and > > clearing it. > > > > Cc: Jan Kara <jack@suse.cz> > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > > Do you plan to merge this together or should I pick this up myself? Please take it through your tree; I'll prepare a pull request for the remainder, but having more patches go through fs maintainers means better testing.
On Tue 23-04-24 18:51:46, Matthew Wilcox wrote: > On Mon, Apr 22, 2024 at 11:57:53PM +0200, Jan Kara wrote: > > On Sat 20-04-24 03:50:08, Matthew Wilcox (Oracle) wrote: > > > Nobody checks the error flag on isofs folios, so stop setting and > > > clearing it. > > > > > > Cc: Jan Kara <jack@suse.cz> > > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > > > > Do you plan to merge this together or should I pick this up myself? > > Please take it through your tree; I'll prepare a pull request for the > remainder, but having more patches go through fs maintainers means > better testing. OK, picked up ext2 and isofs patches into my tree. Honza
diff --git a/fs/isofs/compress.c b/fs/isofs/compress.c index c4da3f634b92..34d5baa5d88a 100644 --- a/fs/isofs/compress.c +++ b/fs/isofs/compress.c @@ -346,8 +346,6 @@ static int zisofs_read_folio(struct file *file, struct folio *folio) for (i = 0; i < pcount; i++, index++) { if (i != full_page) pages[i] = grab_cache_page_nowait(mapping, index); - if (pages[i]) - ClearPageError(pages[i]); } err = zisofs_fill_pages(inode, full_page, pcount, pages); @@ -356,8 +354,6 @@ static int zisofs_read_folio(struct file *file, struct folio *folio) for (i = 0; i < pcount; i++) { if (pages[i]) { flush_dcache_page(pages[i]); - if (i == full_page && err) - SetPageError(pages[i]); unlock_page(pages[i]); if (i != full_page) put_page(pages[i]);
Nobody checks the error flag on isofs folios, so stop setting and clearing it. Cc: Jan Kara <jack@suse.cz> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- fs/isofs/compress.c | 4 ---- 1 file changed, 4 deletions(-)