| Message ID | 20240423073751.52706-1-jun.gu@easystack.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 66270920f90fadb8f29477eb2b83cfb821bac621 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: openvswitch: Release reference to netdev | expand |
Jun Gu <jun.gu@easystack.cn> writes: > dev_get_by_name will provide a reference on the netdev. So ensure that > the reference of netdev is released after completed. > > Fixes: 2540088b836f ("net: openvswitch: Check vport netdev name") > Signed-off-by: Jun Gu <jun.gu@easystack.cn> > --- Thanks! Reviewed-by: Aaron Conole <aconole@redhat.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 23 Apr 2024 15:37:51 +0800 you wrote: > dev_get_by_name will provide a reference on the netdev. So ensure that > the reference of netdev is released after completed. > > Fixes: 2540088b836f ("net: openvswitch: Check vport netdev name") > Signed-off-by: Jun Gu <jun.gu@easystack.cn> > --- > net/openvswitch/vport-netdev.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Here is the summary with links: - [net-next] net: openvswitch: Release reference to netdev https://git.kernel.org/netdev/net-next/c/66270920f90f You are awesome, thank you!
diff --git a/net/openvswitch/vport-netdev.c b/net/openvswitch/vport-netdev.c index 618edc346c0f..91a11067e458 100644 --- a/net/openvswitch/vport-netdev.c +++ b/net/openvswitch/vport-netdev.c @@ -78,12 +78,16 @@ struct vport *ovs_netdev_link(struct vport *vport, const char *name) int err; vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name); + if (!vport->dev) { + err = -ENODEV; + goto error_free_vport; + } /* Ensure that the device exists and that the provided * name is not one of its aliases. */ - if (!vport->dev || strcmp(name, ovs_vport_name(vport))) { + if (strcmp(name, ovs_vport_name(vport))) { err = -ENODEV; - goto error_free_vport; + goto error_put; } netdev_tracker_alloc(vport->dev, &vport->dev_tracker, GFP_KERNEL); if (vport->dev->flags & IFF_LOOPBACK ||
dev_get_by_name will provide a reference on the netdev. So ensure that the reference of netdev is released after completed. Fixes: 2540088b836f ("net: openvswitch: Check vport netdev name") Signed-off-by: Jun Gu <jun.gu@easystack.cn> --- net/openvswitch/vport-netdev.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)