| Message ID | 20240425094829.1.Ia0a99d90acb512aa020a6e7a8cca8cc1b71f1759@changeid (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ARM: st: use a correct pwr compatible for stm32mp15 | expand |
On 25/04/2024 09:48, Patrick Delaunay wrote: > Remove the unexpected comma in the compatible "st,stm32mp1,pwr-reg" > and define the new compatible "st,stm32mp1-pwr-reg". > The old compatible is only keep for compatibility with old device trees. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > --- > > .../devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml b/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml > index c9586d277f41..2a52f9e769c2 100644 > --- a/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml > +++ b/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml > @@ -11,7 +11,9 @@ maintainers: > > properties: > compatible: > - const: st,stm32mp1,pwr-reg > + enum: > + - st,stm32mp1-pwr-reg > + - st,stm32mp1,pwr-reg Please make it oneOf: - const: new one - const: old one deprecated: true Best regards, Krzysztof
Hi, On 4/25/24 10:52, Krzysztof Kozlowski wrote: > On 25/04/2024 09:48, Patrick Delaunay wrote: >> Remove the unexpected comma in the compatible "st,stm32mp1,pwr-reg" >> and define the new compatible "st,stm32mp1-pwr-reg". >> The old compatible is only keep for compatibility with old device trees. >> >> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> >> --- >> >> .../devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml b/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml >> index c9586d277f41..2a52f9e769c2 100644 >> --- a/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml >> +++ b/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml >> @@ -11,7 +11,9 @@ maintainers: >> >> properties: >> compatible: >> - const: st,stm32mp1,pwr-reg >> + enum: >> + - st,stm32mp1-pwr-reg >> + - st,stm32mp1,pwr-reg > Please make it oneOf: > - const: new one > - const: old one > deprecated: true ok, I push a V2 soon. > > Best regards, > Krzysztof Regards Patrick
diff --git a/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml b/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml index c9586d277f41..2a52f9e769c2 100644 --- a/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml +++ b/Documentation/devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml @@ -11,7 +11,9 @@ maintainers: properties: compatible: - const: st,stm32mp1,pwr-reg + enum: + - st,stm32mp1-pwr-reg + - st,stm32mp1,pwr-reg reg: maxItems: 1 @@ -37,7 +39,7 @@ additionalProperties: false examples: - | pwr@50001000 { - compatible = "st,stm32mp1,pwr-reg"; + compatible = "st,stm32mp1-pwr-reg"; reg = <0x50001000 0x10>; vdd-supply = <&vdd>; vdd_3v3_usbfs-supply = <&vdd_usb>;
Remove the unexpected comma in the compatible "st,stm32mp1,pwr-reg" and define the new compatible "st,stm32mp1-pwr-reg". The old compatible is only keep for compatibility with old device trees. Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> --- .../devicetree/bindings/regulator/st,stm32mp1-pwr-reg.yaml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)