[net-next,0/4] selftests: drv-net: round some sharp edges

Message

Jakub Kicinski April 24, 2024, 10:14 p.m. UTC

I had to explain how to run the driver tests twice already.
Improve the README so we can just point to it.
Also fix a potential problem with the SSH remote sessions.

Jakub Kicinski (4):
  selftests: drv-net: force pseudo-terminal allocation in ssh
  selftests: drv-net: extend the README with more info and example
  selftests: drv-net: reimplement the config parser
  selftests: drv-net: validate the environment

 .../testing/selftests/drivers/net/README.rst  | 95 ++++++++++++++++---
 .../selftests/drivers/net/lib/py/env.py       | 46 ++++++---
 .../drivers/net/lib/py/remote_ssh.py          |  2 +-
 3 files changed, 118 insertions(+), 25 deletions(-)

Comments

Willem de Bruijn April 25, 2024, 1:45 a.m. UTC | #1

Jakub Kicinski wrote:
> I had to explain how to run the driver tests twice already.
> Improve the README so we can just point to it.
> Also fix a potential problem with the SSH remote sessions.
> 
> Jakub Kicinski (4):
>   selftests: drv-net: force pseudo-terminal allocation in ssh
>   selftests: drv-net: extend the README with more info and example
>   selftests: drv-net: reimplement the config parser
>   selftests: drv-net: validate the environment
> 
>  .../testing/selftests/drivers/net/README.rst  | 95 ++++++++++++++++---
>  .../selftests/drivers/net/lib/py/env.py       | 46 ++++++---
>  .../drivers/net/lib/py/remote_ssh.py          |  2 +-
>  3 files changed, 118 insertions(+), 25 deletions(-)

Left two minor points comments inline, but nothing important.
The clear documentation is really helpful, thanks.

Reviewed-by: Willem de Bruijn <[e-mail]>

Jakub Kicinski April 25, 2024, 10:22 p.m. UTC | #2

On Wed, 24 Apr 2024 21:45:49 -0400 Willem de Bruijn wrote:
> Left two minor points comments inline, but nothing important.

I'll respin, apply your suggestions and drop the unfortunate patch.